EVOgeek
/
Vmeda.Online
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MOBILE-3371 search: Remove search results count 

Given some issues with the LMS webservices (they return inconsistent totalcount depending on the page), we've decided to remove this information from the UI to avoid confusion.
main
Noel De Martin 2023-10-05 17:46:15 +02:00
parent 9b04cda897
commit 0474d694e7
4 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
scripts/langindex.json
View File

@ -685,7 +685,6 @@
"addon.mod_forum.removefromfavourites": "forum", "addon.mod_forum.removefromfavourites": "forum",
"addon.mod_forum.reply": "forum", "addon.mod_forum.reply": "forum",
"addon.mod_forum.replyplaceholder": "forum", "addon.mod_forum.replyplaceholder": "forum",
"addon.mod_forum.searchresults": "course",
"addon.mod_forum.subject": "forum", "addon.mod_forum.subject": "forum",
"addon.mod_forum.tagarea_forum_posts": "forum", "addon.mod_forum.tagarea_forum_posts": "forum",
"addon.mod_forum.thisforumhasduedate": "forum", "addon.mod_forum.thisforumhasduedate": "forum",

1
src/addons/mod/forum/lang.json
View File

@ -59,7 +59,6 @@
"removefromfavourites": "Unstar this discussion", "removefromfavourites": "Unstar this discussion",
"reply": "Reply", "reply": "Reply",
"replyplaceholder": "Write your reply...", "replyplaceholder": "Write your reply...",
"searchresults": "Search results: {{$a}}",
"subject": "Subject", "subject": "Subject",
"tagarea_forum_posts": "Forum posts", "tagarea_forum_posts": "Forum posts",
"thisforumhasduedate": "The due date for posting to this forum is {{$a}}.", "thisforumhasduedate": "The due date for posting to this forum is {{$a}}.",

4
src/addons/mod/forum/pages/search/search.html
View File

@ -23,10 +23,6 @@
<core-search-box (onSubmit)="search($event)" (onClear)="clearSearch()" [placeholder]="'core.search' | translate" <core-search-box (onSubmit)="search($event)" (onClear)="clearSearch()" [placeholder]="'core.search' | translate"
[searchLabel]="'core.search' | translate" [autoFocus]="true" [searchArea]="searchAreaId"></core-search-box> [searchLabel]="'core.search' | translate" [autoFocus]="true" [searchArea]="searchAreaId"></core-search-box>
<div *ngIf="!resultsSource.isEmpty()" class="results-count">
{{ 'addon.mod_forum.searchresults' | translate: { $a: resultsSource.getTotalResults() } }}
</div>
<ion-list *ngIf="resultsSource.isLoaded()"> <ion-list *ngIf="resultsSource.isLoaded()">
<core-search-global-search-result *ngFor="let result of resultsSource.getItems()" [result]="result" [showCourse]="false" <core-search-global-search-result *ngFor="let result of resultsSource.getItems()" [result]="result" [showCourse]="false"
(onClick)="visitResult(result)"> (onClick)="visitResult(result)">

3
src/addons/mod/forum/tests/behat/search.feature
View File

@ -46,6 +46,5 @@ Feature: Test Forum Search
When I set the field "Search" to "message" in the app When I set the field "Search" to "message" in the app
And I press "Search" "button" in the app And I press "Search" "button" in the app
Then I should find "Search results: 2" in the app Then I should find "Test forum 1" in the app
And I should find "Test forum 1" in the app
And I should find "Test forum 2" in the app And I should find "Test forum 2" in the app