From 0474d694e7437e46abc713f63c656e2690c6137f Mon Sep 17 00:00:00 2001
From: Noel De Martin <noel@moodle.com>
Date: Thu, 5 Oct 2023 17:46:15 +0200
Subject: [PATCH] MOBILE-3371 search: Remove search results count

Given some issues with the LMS webservices (they return inconsistent totalcount depending on the page), we've decided to remove this information from the UI to avoid confusion.
---
 scripts/langindex.json                          | 1 -
 src/addons/mod/forum/lang.json                  | 1 -
 src/addons/mod/forum/pages/search/search.html   | 4 ----
 src/addons/mod/forum/tests/behat/search.feature | 3 +--
 4 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/scripts/langindex.json b/scripts/langindex.json
index 2ad44374b..5233adbf0 100644
--- a/scripts/langindex.json
+++ b/scripts/langindex.json
@@ -685,7 +685,6 @@
   "addon.mod_forum.removefromfavourites": "forum",
   "addon.mod_forum.reply": "forum",
   "addon.mod_forum.replyplaceholder": "forum",
-  "addon.mod_forum.searchresults": "course",
   "addon.mod_forum.subject": "forum",
   "addon.mod_forum.tagarea_forum_posts": "forum",
   "addon.mod_forum.thisforumhasduedate": "forum",
diff --git a/src/addons/mod/forum/lang.json b/src/addons/mod/forum/lang.json
index 42c33b92a..46277f2df 100644
--- a/src/addons/mod/forum/lang.json
+++ b/src/addons/mod/forum/lang.json
@@ -59,7 +59,6 @@
     "removefromfavourites": "Unstar this discussion",
     "reply": "Reply",
     "replyplaceholder": "Write your reply...",
-    "searchresults": "Search results: {{$a}}",
     "subject": "Subject",
     "tagarea_forum_posts": "Forum posts",
     "thisforumhasduedate": "The due date for posting to this forum is {{$a}}.",
diff --git a/src/addons/mod/forum/pages/search/search.html b/src/addons/mod/forum/pages/search/search.html
index 24274aa3c..c33244429 100644
--- a/src/addons/mod/forum/pages/search/search.html
+++ b/src/addons/mod/forum/pages/search/search.html
@@ -23,10 +23,6 @@
         <core-search-box (onSubmit)="search($event)" (onClear)="clearSearch()" [placeholder]="'core.search' | translate"
             [searchLabel]="'core.search' | translate" [autoFocus]="true" [searchArea]="searchAreaId"></core-search-box>
 
-        <div *ngIf="!resultsSource.isEmpty()" class="results-count">
-            {{ 'addon.mod_forum.searchresults' | translate: { $a: resultsSource.getTotalResults() } }}
-        </div>
-
         <ion-list *ngIf="resultsSource.isLoaded()">
             <core-search-global-search-result *ngFor="let result of resultsSource.getItems()" [result]="result" [showCourse]="false"
                 (onClick)="visitResult(result)">
diff --git a/src/addons/mod/forum/tests/behat/search.feature b/src/addons/mod/forum/tests/behat/search.feature
index f9cde8dc2..b6471d5d3 100644
--- a/src/addons/mod/forum/tests/behat/search.feature
+++ b/src/addons/mod/forum/tests/behat/search.feature
@@ -46,6 +46,5 @@ Feature: Test Forum Search
 
     When I set the field "Search" to "message" in the app
     And I press "Search" "button" in the app
-    Then I should find "Search results: 2" in the app
-    And I should find "Test forum 1" in the app
+    Then I should find "Test forum 1" in the app
     And I should find "Test forum 2" in the app