CIT/Vmeda.Online
3
0
Fork 1
forked from EVOgeek/Vmeda.Online
Code Pull Requests Activity

MOBILE-4081 chore: Mixed Code smell fixes

Browse Source
This commit is contained in:
Pau Ferrer Ocaña 2022-09-01 11:28:39 +02:00
parent 16a4e62f3b
commit 3a9b10a90c
4 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/addons/mod/glossary/services/glossary.ts
View File

@ -673,7 +673,7 @@ export class AddonModGlossaryProvider {
* @return Promise resolved with all entrries. * @return Promise resolved with all entrries.
*/ */
fetchAllEntries( fetchAllEntries(
fetchFunction: (options?: AddonModGlossaryGetEntriesOptions) => AddonModGlossaryGetEntriesWSResponse, fetchFunction: (options?: AddonModGlossaryGetEntriesOptions) => Promise<AddonModGlossaryGetEntriesWSResponse>,
options: CoreCourseCommonModWSOptions = {}, options: CoreCourseCommonModWSOptions = {},
): Promise<AddonModGlossaryEntry[]> { ): Promise<AddonModGlossaryEntry[]> {
options.siteId = options.siteId || CoreSites.getCurrentSiteId(); options.siteId = options.siteId || CoreSites.getCurrentSiteId();
@ -681,7 +681,7 @@ export class AddonModGlossaryProvider {
const entries: AddonModGlossaryEntry[] = []; const entries: AddonModGlossaryEntry[] = [];
const fetchMoreEntries = async (): Promise<AddonModGlossaryEntry[]> => { const fetchMoreEntries = async (): Promise<AddonModGlossaryEntry[]> => {
const result = fetchFunction({ const result = await fetchFunction({
from: entries.length, from: entries.length,
...options, // Include all options. ...options, // Include all options.
}); });

0
src/app/app.component.scss
View File

1
src/app/app.component.ts
View File

@ -41,7 +41,6 @@ const MOODLEAPP_VERSION_PREFIX = 'moodleapp-';
@Component({ @Component({
selector: 'app-root', selector: 'app-root',
templateUrl: 'app.component.html', templateUrl: 'app.component.html',
styleUrls: ['app.component.scss'],
}) })
export class AppComponent implements OnInit, AfterViewInit { export class AppComponent implements OnInit, AfterViewInit {

2
src/core/features/grades/pages/course/course.html
View File

@ -16,7 +16,7 @@
<core-empty-box *ngIf="rows && rows.length === 0" icon="fas-chart-bar" [message]="'core.grades.nogradesreturned' | translate"> <core-empty-box *ngIf="rows && rows.length === 0" icon="fas-chart-bar" [message]="'core.grades.nogradesreturned' | translate">
</core-empty-box> </core-empty-box>
<div *ngIf="rows && rows.length > 0" class="core-grades-container"> <div *ngIf="rows && rows.length > 0" class="core-grades-container">
<table cellspacing="0" cellpadding="0" class="core-grades-table" [class.summary]="showSummary"> <table class="core-grades-table" [class.summary]="showSummary">
<thead> <thead>
<tr> <tr>
<th *ngFor="let column of columns" id="{{column.name}}" class="ion-text-start" <th *ngFor="let column of columns" id="{{column.name}}" class="ion-text-start"