From 3a9b10a90c8825fa5f80c589c50b63d595c39fee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= <crazyserver@gmail.com>
Date: Thu, 1 Sep 2022 11:28:39 +0200
Subject: [PATCH] MOBILE-4081 chore: Mixed Code smell fixes

---
 src/addons/mod/glossary/services/glossary.ts      | 4 ++--
 src/app/app.component.scss                        | 0
 src/app/app.component.ts                          | 1 -
 src/core/features/grades/pages/course/course.html | 2 +-
 4 files changed, 3 insertions(+), 4 deletions(-)
 delete mode 100644 src/app/app.component.scss

diff --git a/src/addons/mod/glossary/services/glossary.ts b/src/addons/mod/glossary/services/glossary.ts
index 53ef5b21f..4b31042e5 100644
--- a/src/addons/mod/glossary/services/glossary.ts
+++ b/src/addons/mod/glossary/services/glossary.ts
@@ -673,7 +673,7 @@ export class AddonModGlossaryProvider {
      * @return Promise resolved with all entrries.
      */
     fetchAllEntries(
-        fetchFunction: (options?: AddonModGlossaryGetEntriesOptions) => AddonModGlossaryGetEntriesWSResponse,
+        fetchFunction: (options?: AddonModGlossaryGetEntriesOptions) => Promise<AddonModGlossaryGetEntriesWSResponse>,
         options: CoreCourseCommonModWSOptions = {},
     ): Promise<AddonModGlossaryEntry[]> {
         options.siteId = options.siteId || CoreSites.getCurrentSiteId();
@@ -681,7 +681,7 @@ export class AddonModGlossaryProvider {
         const entries: AddonModGlossaryEntry[] = [];
 
         const fetchMoreEntries = async (): Promise<AddonModGlossaryEntry[]> => {
-            const result = fetchFunction({
+            const result = await fetchFunction({
                 from: entries.length,
                 ...options, // Include all options.
             });
diff --git a/src/app/app.component.scss b/src/app/app.component.scss
deleted file mode 100644
index e69de29bb..000000000
diff --git a/src/app/app.component.ts b/src/app/app.component.ts
index a4f2c7c0f..9535bbc78 100644
--- a/src/app/app.component.ts
+++ b/src/app/app.component.ts
@@ -41,7 +41,6 @@ const MOODLEAPP_VERSION_PREFIX = 'moodleapp-';
 @Component({
     selector: 'app-root',
     templateUrl: 'app.component.html',
-    styleUrls: ['app.component.scss'],
 })
 export class AppComponent implements OnInit, AfterViewInit {
 
diff --git a/src/core/features/grades/pages/course/course.html b/src/core/features/grades/pages/course/course.html
index de30057bd..bf4835c89 100644
--- a/src/core/features/grades/pages/course/course.html
+++ b/src/core/features/grades/pages/course/course.html
@@ -16,7 +16,7 @@
         <core-empty-box *ngIf="rows && rows.length === 0" icon="fas-chart-bar" [message]="'core.grades.nogradesreturned' | translate">
         </core-empty-box>
         <div *ngIf="rows && rows.length > 0" class="core-grades-container">
-            <table cellspacing="0" cellpadding="0" class="core-grades-table" [class.summary]="showSummary">
+            <table class="core-grades-table" [class.summary]="showSummary">
                 <thead>
                     <tr>
                         <th *ngFor="let column of columns" id="{{column.name}}" class="ion-text-start"