MOBILE-4653 login: Improvements to easily change classes and logins

src/core/features/login/services/login-helper.ts

@@ -796,20 +796,20 @@ export class CoreLoginHelperProvider {
         launchUrl = launchUrl || siteUrl + '/admin/tool/mobile/launch.php';
 
         const passport = Math.random() * 1000;
-        let loginUrl = launchUrl + '?service=' + service;
 
-        loginUrl += '&passport=' + passport;
+        const additionalParams = Object.assign(urlParams || {}, {
-        loginUrl += '&urlscheme=' + CoreConstants.CONFIG.customurlscheme;
+            service,
+            passport,
+            urlscheme: CoreConstants.CONFIG.customurlscheme,
+        });
 
-        if (urlParams) {
+        const loginUrl = CoreUrl.addParamsToUrl(launchUrl, additionalParams);
-            loginUrl = CoreUrl.addParamsToUrl(loginUrl, urlParams);
-        }
 
         // Store the siteurl and passport in CoreConfig for persistence.
         // We are "configuring" the app to wait for an SSO. CoreConfig shouldn't be used as a temporary storage.
         await CoreConfig.set(CoreConstants.LOGIN_LAUNCH_DATA, JSON.stringify(<StoredLoginLaunchData> {
-            siteUrl: siteUrl,
+            siteUrl,
-            passport: passport,
+            passport,
             ...redirectData,
             ssoUrlParams: urlParams || {},
         }));

src/core/singletons/html-classes.ts

@@ -89,7 +89,7 @@ export class CoreHTMLClasses {
      *
      * @param prefixes Prefixes of the class mode to be removed.
      */
-    protected static removeModeClasses(prefixes: string[]): void {
+    static removeModeClasses(prefixes: string[]): void {
         for (const modeClass of CoreHTMLClasses.getModeClasses()) {
             if (!prefixes.some((prefix) => modeClass.startsWith(prefix))) {
                 continue;