Merge pull request #1767 from dpalou/MOBILE-2861

MOBILE-2861 core: Fix error when dismissing a loading modal twice

src/providers/utils/dom.ts

@@ -1161,7 +1161,20 @@ export class CoreDomUtilsProvider {
 
         const loader = this.loadingCtrl.create({
                 content: text
-        });
+            }),
+            dismiss = loader.dismiss.bind(loader);
+        let isDismissed = false;
+
+        // Override dismiss to prevent dismissing a modal twice (it can throw an error and cause problems).
+        loader.dismiss = (data, role, navOptions): Promise<any> => {
+            if (isDismissed) {
+                return Promise.resolve();
+            }
+
+            isDismissed = true;
+
+            return dismiss(data, role, navOptions);
+        };
 
         loader.present();