GuzhavinAleksey/Vmeda.Online
1
0
Fork 0
forked from CIT/Vmeda.Online
Code Pull Requests Activity

MOBILE-3245 grades: Fix network methods calls when populating grades

Browse Source
This commit is contained in:
Noel De Martin 2019-12-11 13:32:00 +01:00
parent 5337c77b7e
commit accb83b339
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/core/grades/providers/helper.ts
View File

@ -200,15 +200,22 @@ export class CoreGradesHelperProvider {
*/ */
async getGradesCourseData(grades: any[]): Promise<any> { async getGradesCourseData(grades: any[]): Promise<any> {
// Obtain courses from cache to prevent network requests. // Obtain courses from cache to prevent network requests.
const courses = await this.coursesProvider.getUserCourses(undefined, undefined, ReadingStrategy.OnlyCache); let coursesWereMissing;
const coursesMap = this.utils.arrayToObject(courses, 'id'); try {
const coursesWereMissing = this.addCourseData(grades, coursesMap); const courses = await this.coursesProvider.getUserCourses(undefined, undefined, ReadingStrategy.OnlyCache);
const coursesMap = this.utils.arrayToObject(courses, 'id');
coursesWereMissing = this.addCourseData(grades, coursesMap);
} catch (error) {
coursesWereMissing = true;
}
// If any course wasn't found, make a network request. // If any course wasn't found, make a network request.
if (coursesWereMissing) { if (coursesWereMissing) {
const coursesPromise = this.coursesProvider.isGetCoursesByFieldAvailable() const coursesPromise = this.coursesProvider.isGetCoursesByFieldAvailable()
? this.coursesProvider.getCoursesByField('ids', grades.map((grade) => grade.courseid)) ? this.coursesProvider.getCoursesByField('ids', grades.map((grade) => grade.courseid).join(','))
: this.coursesProvider.getUserCourses(undefined, undefined, ReadingStrategy.PreferNetwork); : this.coursesProvider.getUserCourses(undefined, undefined, ReadingStrategy.PreferNetwork);
const courses = await coursesPromise; const courses = await coursesPromise;