GuzhavinAleksey/Vmeda.Online
1
0
Fork 0
forked from CIT/Vmeda.Online
Code Pull Requests Activity

MOBILE-3752 a11y: Fix darkmode on some screens

Browse Source
This commit is contained in:
Pau Ferrer Ocaña 2021-05-13 11:48:54 +02:00
parent 8542e3c279
commit 9c2a235745
6 changed files with 27 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/addons/block/learningplans/services/block-handler.ts
View File

@ -34,8 +34,6 @@ export class AddonBlockLearningPlansHandlerService extends CoreBlockBaseHandler
* @return Data or promise resolved with the data.
*/
getDisplayData(): CoreBlockHandlerData {
// @todo
return {
title: 'addon.block_learningplans.pluginname',
class: 'addon-block-learning-plans',

2
src/addons/competency/pages/plan/plan.html
View File

@ -65,7 +65,7 @@
</ion-card>
<ion-card *ngIf="plan">
<ion-card-header class="ion-text-wrap">
<h2>{{ 'addon.competency.learningplancompetencies' | translate }}</h2>
<ion-card-title>{{ 'addon.competency.learningplancompetencies' | translate }}</ion-card-title>
</ion-card-header>
<ion-list>
<ion-item class="ion-text-wrap" *ngIf="plan.competencycount == 0">

2
src/addons/mod/forum/services/forum.ts
View File

@ -49,8 +49,6 @@ declare module '@singletons/events' {
/**
* Service that provides some features for forums.
*
* @todo Add all content.
*/
@Injectable({ providedIn: 'root' })
export class AddonModForumProvider {

4
src/addons/mod/quiz/pages/review/review.html
View File

@ -23,8 +23,8 @@
<ion-card *ngIf="attempt">
<ion-card-header class="ion-text-wrap">
<ion-card-title>
<span *ngIf="attempt.preview">{{ 'addon.mod_quiz.reviewofpreview' | translate }}</span>
<span *ngIf="!attempt.preview">{{ 'addon.mod_quiz.reviewofattempt' | translate:{$a: attempt.attempt} }}</span>
<ng-container *ngIf="attempt.preview">{{ 'addon.mod_quiz.reviewofpreview' | translate }}</ng-container>
<ng-container *ngIf="!attempt.preview">{{ 'addon.mod_quiz.reviewofattempt' | translate:{$a: attempt.attempt} }}</ng-container>
</ion-card-title>
</ion-card-header>
<ion-list lines="none">

2
src/addons/mod/workshop/workshop-lazy.module.ts
View File

@ -35,7 +35,7 @@ const routes: Routes = [
canDeactivate: [CanLeaveGuard],
},
{
path: ':courseId/:cmId/:submissionId/edit', // @todo
path: ':courseId/:cmId/:submissionId/edit',
component: AddonModWorkshopEditSubmissionPage,
canDeactivate: [CanLeaveGuard],
},

54
src/core/features/grades/pages/course/course.scss
View File

@ -1,7 +1,18 @@
@import "~theme/globals";
// @todo darkmode
// @todo RTL layout
:host {
--header-background: var(--white);
--odd-cell-background: var(--gray-lighter);
--even-cell-background: var(--white);
--icon-color: #999999;
}
:host-context(body.dark) {
--header-background: var(--black);
--odd-cell-background: var(--gray-darker);
--even-cell-background: var(--black);
--icon-color: #eeeeee;
}
:host-context(ion-app.md) {
--border-color: var(--ion-item-border-color, var(--ion-border-color, var(--ion-color-step-150, rgba(0, 0, 0, .13))));
@ -18,16 +29,12 @@
font-size: 16px;
color: var(--ion-text-color);
// @include darkmode() {
// color: $core-dark-text-color;
// }
tr {
border-bottom: 1px solid var(--border-color);
}
th, td {
padding: 10px 0 10px 10px;
@include padding(10px, 10px, 10px, null);
vertical-align: top;
white-space: normal;
text-align: start;
@ -36,11 +43,7 @@
thead th {
vertical-align: bottom;
font-weight: bold;
background-color: var(--white);
// @include darkmode() {
// background-color: $black;
// }
background-color: var(--header-background);
}
tbody th {
@ -48,15 +51,15 @@
}
#gradeitem {
padding-left: 5px;
@include padding(null, null, null, 5px);
}
.core-grades-table-gradeitem {
padding-left: 5px;
@include padding(null, null, null, 5px);
font-weight: bold;
&.column-itemname {
padding-left: 0;
@include padding(null, null, null, 0);
}
img {
@ -65,17 +68,17 @@
}
ion-icon {
color: #999999;
color: var(--icon-color);
}
span {
margin-left: 5px;
@include margin(null, null, null, 5px);
}
}
.core-grades-table-feedback {
padding-left: 5px;
@include padding(null, null, null, 5px);
.no-overflow {
overflow: auto;
@ -89,27 +92,16 @@
}
.odd {
td, th, th[aria-current="page"] {
background-color: var(--gray-lighter);
// @include darkmode() {
// background-color: $gray-darker;
// }
background-color: var(--odd-cell-background);
}
}
.even {
td, th, th[aria-current="page"] {
background-color: var(--white);
// @include darkmode() {
// background-color: $black;
// }
background-color: var(--even-cell-background);
}
}
.core-grades-grade-clickable {