From fe916c2dac5d0909e7f04165919658360b0d296a Mon Sep 17 00:00:00 2001 From: Noel De Martin Date: Thu, 7 Jul 2022 09:46:32 +0200 Subject: [PATCH] MOBILE-4110 ci: Fix node versions --- .github/workflows/acceptance.yml | 6 ++---- .github/workflows/migration.yml | 7 +++---- .github/workflows/performance.yml | 6 ++---- .github/workflows/testing.yml | 5 ++--- .github/workflows/update_behat_plugin.yml | 2 ++ 5 files changed, 11 insertions(+), 15 deletions(-) diff --git a/.github/workflows/acceptance.yml b/.github/workflows/acceptance.yml index 2972bbf1d..cbcd78e41 100644 --- a/.github/workflows/acceptance.yml +++ b/.github/workflows/acceptance.yml @@ -32,11 +32,9 @@ jobs: BEHAT_TAGS: ${{ github.event.inputs.behat_tags || '~@performance' }} steps: - uses: actions/checkout@v2 - - id: nvmrc - uses: browniebroke/read-nvmrc-action@v1 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: - node-version: '${{ steps.nvmrc.outputs.node_version }}' + node-version-file: '.nvmrc' - name: Additional checkouts run: | git clone --branch $MOODLE_BRANCH --depth 1 $MOODLE_REPOSITORY $GITHUB_WORKSPACE/moodle diff --git a/.github/workflows/migration.yml b/.github/workflows/migration.yml index 585b297c0..360a4361b 100644 --- a/.github/workflows/migration.yml +++ b/.github/workflows/migration.yml @@ -9,11 +9,10 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Use Node.js - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: - node-version: '14.x' - - run: npm ci + node-version-file: '.nvmrc' + - run: npm ci --no-audit - run: result=$(find src -type f -iname '*.html' -exec sh -c 'cat {} | tr "\n" " " | grep -Eo "class=\"[^\"]+\"[^>]+class=\"" ' \; | wc -l); test $result -eq 0 - run: npm install -D @ionic/v4-migration-tslint - run: npx tslint -c ionic-migration.json -p tsconfig.json diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml index b4fe6a50c..fb88afced 100644 --- a/.github/workflows/performance.yml +++ b/.github/workflows/performance.yml @@ -11,11 +11,9 @@ jobs: MOODLE_DOCKER_PHP_VERSION: 7.3 steps: - uses: actions/checkout@v2 - - id: nvmrc - uses: browniebroke/read-nvmrc-action@v1 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: - node-version: '${{ steps.nvmrc.outputs.node_version }}' + node-version-file: '.nvmrc' - name: Additional checkouts run: | git clone --branch master --depth 1 https://github.com/moodle/moodle $GITHUB_WORKSPACE/moodle diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index be8f69727..415a873cb 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -9,10 +9,9 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Use Node.js - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: - node-version: '14' + node-version-file: '.nvmrc' - name: Install npm packages run: npm ci --no-audit - name: Check langindex diff --git a/.github/workflows/update_behat_plugin.yml b/.github/workflows/update_behat_plugin.yml index 1f6430a6a..4573920b6 100644 --- a/.github/workflows/update_behat_plugin.yml +++ b/.github/workflows/update_behat_plugin.yml @@ -8,6 +8,8 @@ jobs: steps: - uses: actions/checkout@v2 - uses: actions/setup-node@v3 + with: + node-version-file: '.nvmrc' - name: Install npm packages run: npm ci --no-audit - name: Update Behat plugin