Merge pull request #4244 from crazyserver/MOBILE-4138

MOBILE-4138 core: Unprotect updateHandlers on delegates
main
Dani Palou 2024-11-20 16:23:11 +01:00 committed by GitHub
commit f39d4a9240
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 4 deletions

View File

@ -317,7 +317,7 @@ export class CoreDelegate<HandlerType extends CoreDelegateHandler> {
*
* @returns Resolved when done.
*/
protected async updateHandlers(): Promise<void> {
async updateHandlers(): Promise<void> {
this.handlersLoaded = false;
const enabled = await this.isEnabled();

View File

@ -16,7 +16,6 @@ import { mock, mockSingleton } from '@/testing/utils';
import { CoreSite } from '@classes/sites/site';
import { CorePluginFileDelegateService, CorePluginFileHandler } from '@services/plugin-file-delegate';
import { CoreSites } from '@services/sites';
import { CoreEvents } from '@singletons/events';
import { CoreUrl } from '@singletons/url';
describe('CorePluginFileDelegate', () => {
@ -33,8 +32,7 @@ describe('CorePluginFileDelegate', () => {
pluginFileDelegate = new CorePluginFileDelegateService();
pluginFileDelegate.registerHandler(new ModFooRevisionHandler());
CoreEvents.trigger(CoreEvents.LOGIN, { siteId: '42' }, '42');
await pluginFileDelegate.waitForReady();
await pluginFileDelegate.updateHandlers();
});
it('removes revision from a URL', () => {