From efd364f285d530ae737709c5b6e8473a6c5c6aa0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= Date: Wed, 6 Nov 2024 15:36:51 +0100 Subject: [PATCH] MOBILE-4653 chore: Mixture of typos --- src/addons/mod/forum/services/forum-helper.ts | 4 ++-- .../mod/workshop/services/workshop-helper.ts | 4 ++-- src/core/features/login/services/login-helper.ts | 4 ++-- src/core/features/xapi/services/xapi.ts | 2 +- src/core/services/handlers/site-info-cron.ts | 14 +++----------- 5 files changed, 10 insertions(+), 18 deletions(-) diff --git a/src/addons/mod/forum/services/forum-helper.ts b/src/addons/mod/forum/services/forum-helper.ts index 29d822ae4..d76a133c4 100644 --- a/src/addons/mod/forum/services/forum-helper.ts +++ b/src/addons/mod/forum/services/forum-helper.ts @@ -254,7 +254,7 @@ export class AddonModForumHelperProvider { async deleteNewDiscussionStoredFiles(forumId: number, timecreated: number, siteId?: string): Promise { const folderPath = await AddonModForumOffline.getNewDiscussionFolder(forumId, timecreated, siteId); - // Ignore any errors, CoreFileProvider.removeDir fails if folder doesn't exist. + // Ignore any errors, CoreFile.removeDir fails if folder doesn't exist. await CoreUtils.ignoreErrors(CoreFile.removeDir(folderPath)); } @@ -270,7 +270,7 @@ export class AddonModForumHelperProvider { async deleteReplyStoredFiles(forumId: number, postId: number, siteId?: string, userId?: number): Promise { const folderPath = await AddonModForumOffline.getReplyFolder(forumId, postId, siteId, userId); - // Ignore any errors, CoreFileProvider.removeDir fails if folder doesn't exist. + // Ignore any errors, CoreFile.removeDir fails if folder doesn't exist. await CoreUtils.ignoreErrors(CoreFile.removeDir(folderPath)); } diff --git a/src/addons/mod/workshop/services/workshop-helper.ts b/src/addons/mod/workshop/services/workshop-helper.ts index 54091eeed..b05349d08 100644 --- a/src/addons/mod/workshop/services/workshop-helper.ts +++ b/src/addons/mod/workshop/services/workshop-helper.ts @@ -240,7 +240,7 @@ export class AddonModWorkshopHelperProvider { async deleteSubmissionStoredFiles(workshopId: number, siteId?: string): Promise { const folderPath = await AddonModWorkshopOffline.getSubmissionFolder(workshopId, siteId); - // Ignore any errors, CoreFileProvider.removeDir fails if folder doesn't exists. + // Ignore any errors, CoreFile.removeDir fails if folder doesn't exists. await CoreUtils.ignoreErrors(CoreFile.removeDir(folderPath)); } @@ -344,7 +344,7 @@ export class AddonModWorkshopHelperProvider { async deleteAssessmentStoredFiles(workshopId: number, assessmentId: number, siteId?: string): Promise { const folderPath = await AddonModWorkshopOffline.getAssessmentFolder(workshopId, assessmentId, siteId); - // Ignore any errors, CoreFileProvider.removeDir fails if folder doesn't exists. + // Ignore any errors, CoreFile.removeDir fails if folder doesn't exists. await CoreUtils.ignoreErrors(CoreFile.removeDir(folderPath)); } diff --git a/src/core/features/login/services/login-helper.ts b/src/core/features/login/services/login-helper.ts index 372442e57..17be768a0 100644 --- a/src/core/features/login/services/login-helper.ts +++ b/src/core/features/login/services/login-helper.ts @@ -802,8 +802,8 @@ export class CoreLoginHelperProvider { loginUrl = CoreUrl.addParamsToUrl(loginUrl, urlParams); } - // Store the siteurl and passport in CoreConfigProvider for persistence. - // We are "configuring" the app to wait for an SSO. CoreConfigProvider shouldn't be used as a temporary storage. + // Store the siteurl and passport in CoreConfig for persistence. + // We are "configuring" the app to wait for an SSO. CoreConfig shouldn't be used as a temporary storage. await CoreConfig.set(CoreConstants.LOGIN_LAUNCH_DATA, JSON.stringify( { siteUrl: siteUrl, passport: passport, diff --git a/src/core/features/xapi/services/xapi.ts b/src/core/features/xapi/services/xapi.ts index 8df9b0615..48e617c32 100644 --- a/src/core/features/xapi/services/xapi.ts +++ b/src/core/features/xapi/services/xapi.ts @@ -34,7 +34,7 @@ export const XAPI_STATE_DELETED = 'STATE_DELETED'; @Injectable({ providedIn: 'root' }) export class CoreXAPIProvider { - static readonly ROOT_CACHE_KEY = 'CoreXAPI:'; + protected static readonly ROOT_CACHE_KEY = 'CoreXAPI:'; protected logger = CoreLogger.getInstance('CoreXAPIProvider'); diff --git a/src/core/services/handlers/site-info-cron.ts b/src/core/services/handlers/site-info-cron.ts index e751a61c0..f27b2a571 100644 --- a/src/core/services/handlers/site-info-cron.ts +++ b/src/core/services/handlers/site-info-cron.ts @@ -26,11 +26,7 @@ export class CoreSiteInfoCronHandlerService implements CoreCronHandler { name = 'CoreSiteInfoCronHandler'; /** - * Execute the process. - * Receives the ID of the site affected, undefined for all sites. - * - * @param siteId ID of the site affected, undefined for all sites. - * @returns Promise resolved when done, rejected on failure. + * @inheritdoc */ async execute(siteId?: string): Promise { if (!siteId) { @@ -43,18 +39,14 @@ export class CoreSiteInfoCronHandlerService implements CoreCronHandler { } /** - * Returns handler's interval in milliseconds. Defaults to CoreCronDelegateService.DEFAULT_INTERVAL. - * - * @returns Interval time (in milliseconds). + * @inheritdoc */ getInterval(): number { return 10800000; // 3 hours. } /** - * Check whether it's a synchronization process or not. True if not defined. - * - * @returns Whether it's a synchronization process or not. + * @inheritdoc */ isSync(): boolean { return false;