From 1f27a8f2110cfb4ffaa063e7b84d38ae4423c068 Mon Sep 17 00:00:00 2001 From: Noel De Martin Date: Wed, 24 May 2023 16:14:00 +0200 Subject: [PATCH 1/2] MOBILE-4270 login: Fix signup tests for 3.9 --- src/core/features/login/tests/behat/signup-309.feature | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/core/features/login/tests/behat/signup-309.feature b/src/core/features/login/tests/behat/signup-309.feature index 2abb29a49..f730e3920 100644 --- a/src/core/features/login/tests/behat/signup-309.feature +++ b/src/core/features/login/tests/behat/signup-309.feature @@ -2,6 +2,8 @@ Feature: Test signup in app I need basic signup functionality to work + # These scenarios are duplicated from main because the error message about + # non alpha-numeric characters has changed. Background: Given the following config values are set as admin: | registerauth | email | @@ -27,7 +29,7 @@ Feature: Test signup in app | Email address | u1@u1.com | | Email (again) | u1@u1.com | | First name | User | - | Surname | Test | + | Last name | Test | | City/town | Barcelona | | Country | Spain | And I press "Create my new account" in the app From 848ac04daff5c69f0ce96e4067ea4b65dbf3e0f2 Mon Sep 17 00:00:00 2001 From: Noel De Martin Date: Thu, 25 May 2023 08:35:02 +0200 Subject: [PATCH 2/2] MOBILE-4270 forum: Fix push notifications --- src/addons/mod/forum/services/handlers/push-click.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/addons/mod/forum/services/handlers/push-click.ts b/src/addons/mod/forum/services/handlers/push-click.ts index b0889d412..d57275e23 100644 --- a/src/addons/mod/forum/services/handlers/push-click.ts +++ b/src/addons/mod/forum/services/handlers/push-click.ts @@ -46,7 +46,7 @@ export class AddonModForumPushClickHandlerService implements CorePushNotificatio return CoreUtils.isTrueOrOne(notification.notif) && notification.moodlecomponent == 'mod_forum' && notification.name == 'posts' - && !!(notification.contexturl || notification.customdata?.postid); + && !!(notification.contexturl || notification.customdata?.discussionid); } /**