diff --git a/src/addons/calendar/pages/event/event.page.ts b/src/addons/calendar/pages/event/event.page.ts index 43dc8a502..f260b272e 100644 --- a/src/addons/calendar/pages/event/event.page.ts +++ b/src/addons/calendar/pages/event/event.page.ts @@ -434,8 +434,6 @@ export class AddonCalendarEventPage implements OnInit, OnDestroy { * Open the page to edit the event. */ openEdit(): void { - // Decide which navCtrl to use. If this page is inside a split view, use the split view's master nav. - // @todo const navCtrl = this.svComponent ? this.svComponent.getMasterNav() : this.navCtrl; CoreNavigator.navigateToSitePath('/calendar/edit', { params: { eventId: this.eventId } }); } diff --git a/src/addons/notifications/pages/settings/settings.ts b/src/addons/notifications/pages/settings/settings.ts index 12211e72c..6b430204d 100644 --- a/src/addons/notifications/pages/settings/settings.ts +++ b/src/addons/notifications/pages/settings/settings.ts @@ -38,7 +38,6 @@ import { AddonNotificationsPreferencesProcessorFormatted, } from '@addons/notifications/services/notifications-helper'; import { CoreNavigator } from '@services/navigator'; -// import { CoreSplitViewComponent } from '@components/split-view/split-view'; /** * Page that displays notifications settings. @@ -61,7 +60,7 @@ export class AddonNotificationsSettingsPage implements OnInit, OnDestroy { protected updateTimeout?: number; - constructor() { // @todo @Optional() protected svComponent: CoreSplitViewComponent, + constructor() { this.notifPrefsEnabled = AddonNotifications.isNotificationPreferencesEnabled(); this.canChangeSound = CoreLocalNotifications.canDisableSound(); } @@ -196,8 +195,6 @@ export class AddonNotificationsSettingsPage implements OnInit, OnDestroy { * @param handlerData */ openExtraPreferences(handlerData: AddonMessageOutputHandlerData): void { - // Decide which navCtrl to use. If this page is inside a split view, use the split view's master nav. - // @todo const navCtrl = this.svComponent ? this.svComponent.getMasterNav() : this.navCtrl; CoreNavigator.navigateToSitePath(handlerData.page, { params: handlerData.pageParams }); } diff --git a/src/core/components/iframe/iframe.ts b/src/core/components/iframe/iframe.ts index 70ffdffcc..bc4c7a656 100644 --- a/src/core/components/iframe/iframe.ts +++ b/src/core/components/iframe/iframe.ts @@ -75,8 +75,6 @@ export class CoreIframeComponent implements OnChanges { // Show loading only with external URLs. this.loading = !this.src || !CoreUrlUtils.isLocalFileUrl(this.src); - // @todo const navCtrl = this.svComponent ? this.svComponent.getMasterNav() : this.navCtrl; - // CoreIframeUtils.treatFrame(iframe, false, this.navCtrl); CoreIframeUtils.treatFrame(iframe, false); iframe.addEventListener('load', () => { diff --git a/src/core/components/infinite-loading/infinite-loading.ts b/src/core/components/infinite-loading/infinite-loading.ts index 69addc88d..169908475 100644 --- a/src/core/components/infinite-loading/infinite-loading.ts +++ b/src/core/components/infinite-loading/infinite-loading.ts @@ -132,9 +132,9 @@ export class CoreInfiniteLoadingComponent implements OnChanges { * Get the height of the element. * * @return Height. - * @todo erase is not needed: I'm depreacating it because if not needed or getBoundingClientRect has the same result, it should + * @todo erase if not needed: I'm depreacating it because if not needed or getBoundingClientRect has the same result, it should * be erased, also with getElementHeight - * @deprecated + * @deprecated since 3.9.5 */ getHeight(): number { // return this.element.nativeElement.getBoundingClientRect().height; diff --git a/src/core/components/navbar-buttons/navbar-buttons.ts b/src/core/components/navbar-buttons/navbar-buttons.ts index f24c05a47..7bac66635 100644 --- a/src/core/components/navbar-buttons/navbar-buttons.ts +++ b/src/core/components/navbar-buttons/navbar-buttons.ts @@ -124,7 +124,6 @@ export class CoreNavBarButtonsComponent implements OnInit, OnDestroy { * If both button containers have a context menu, merge them into a single one. * * @param buttonsContainer The container where the buttons will be moved. - * @todo */ protected mergeContextMenus(buttonsContainer: HTMLElement): void { // Check if both button containers have a context menu. diff --git a/src/core/components/user-avatar/user-avatar.ts b/src/core/components/user-avatar/user-avatar.ts index a89f204d5..b53ef95fe 100644 --- a/src/core/components/user-avatar/user-avatar.ts +++ b/src/core/components/user-avatar/user-avatar.ts @@ -137,7 +137,6 @@ export class CoreUserAvatarComponent implements OnInit, OnChanges, OnDestroy { event.preventDefault(); event.stopPropagation(); - // @todo Decide which navCtrl to use. If this component is inside a split view, use the split view's master nav. CoreNavigator.navigateToSitePath('user', { params: { userId: this.userId, diff --git a/src/core/directives/format-text.ts b/src/core/directives/format-text.ts index 9997a4d3e..8ad9dd230 100644 --- a/src/core/directives/format-text.ts +++ b/src/core/directives/format-text.ts @@ -471,8 +471,6 @@ export class CoreFormatTextDirective implements OnChanges { */ protected async treatHTMLElements(div: HTMLElement, site?: CoreSite): Promise { const canTreatVimeo = site?.isVersionGreaterEqualThan(['3.3.4', '3.4']) || false; - // @todo this.svComponent ? this.svComponent.getMasterNav() : this.navCtrl; - // @todo: Pass navCtrl to all treateFrame calls? const images = Array.from(div.querySelectorAll('img')); const anchors = Array.from(div.querySelectorAll('a')); diff --git a/src/core/directives/link.ts b/src/core/directives/link.ts index cdebc6524..0271143bc 100644 --- a/src/core/directives/link.ts +++ b/src/core/directives/link.ts @@ -56,8 +56,6 @@ export class CoreLinkDirective implements OnInit { ngOnInit(): void { this.inApp = typeof this.inApp == 'undefined' ? this.inApp : CoreUtils.isTrueOrOne(this.inApp); - // @todo: Handle split view? - this.element.addEventListener('click', async (event) => { if (event.defaultPrevented) { return; // Link already treated, stop. diff --git a/src/core/directives/user-link.ts b/src/core/directives/user-link.ts index f7261e1dc..7fff5949d 100644 --- a/src/core/directives/user-link.ts +++ b/src/core/directives/user-link.ts @@ -49,7 +49,6 @@ export class CoreUserLinkDirective implements OnInit { event.preventDefault(); event.stopPropagation(); - // @todo If this directive is inside a split view, use the split view's master nav. CoreNavigator.navigateToSitePath('user', { params: CoreObject.withoutEmpty({ userId: this.userId, diff --git a/src/core/features/block/components/only-title-block/only-title-block.ts b/src/core/features/block/components/only-title-block/only-title-block.ts index 4e777f6c0..a0be90b78 100644 --- a/src/core/features/block/components/only-title-block/only-title-block.ts +++ b/src/core/features/block/components/only-title-block/only-title-block.ts @@ -43,7 +43,6 @@ export class CoreBlockOnlyTitleComponent extends CoreBlockBaseComponent implemen * Go to the block page. */ gotoBlock(): void { - // @todo test that this is working properly. CoreNavigator.navigateToSitePath(this.link!, { params: this.linkParams }); } diff --git a/src/core/features/course/components/tag-area/tag-area.ts b/src/core/features/course/components/tag-area/tag-area.ts index 9f841771f..5c5f28c18 100644 --- a/src/core/features/course/components/tag-area/tag-area.ts +++ b/src/core/features/course/components/tag-area/tag-area.ts @@ -34,8 +34,6 @@ export class CoreCourseTagAreaComponent { * @param courseId The course to open. */ openCourse(courseId: number): void { - // @todo If this component is inside a split view, use the master nav to open it. - // const navCtrl = this.splitviewCtrl ? this.splitviewCtrl.getMasterNav() : this.navCtrl; CoreCourseHelper.getAndOpenCourse(courseId); } diff --git a/src/core/features/tag/components/list/list.ts b/src/core/features/tag/components/list/list.ts index dfcdcb931..286d8916c 100644 --- a/src/core/features/tag/components/list/list.ts +++ b/src/core/features/tag/components/list/list.ts @@ -40,7 +40,6 @@ export class CoreTagListComponent { fromContextId: tag.taginstancecontextid, }; - // @todo: Check split view to navigate on the outlet if any. CoreNavigator.navigateToSitePath('/tag/index', { params, preferCurrentTab: false }); } diff --git a/src/core/features/user/pages/profile/profile.page.ts b/src/core/features/user/pages/profile/profile.page.ts index 10d326490..7487b764a 100644 --- a/src/core/features/user/pages/profile/profile.page.ts +++ b/src/core/features/user/pages/profile/profile.page.ts @@ -261,8 +261,7 @@ export class CoreUserProfilePage implements OnInit, OnDestroy { * Open the page with the user details. */ openUserDetails(): void { - // @todo: Navigate out of split view if this page is in the right pane. - CoreNavigator.navigate('../about', { + CoreNavigator.navigateToSitePath('user/about', { params: { courseId: this.courseId, userId: this.userId, @@ -277,7 +276,6 @@ export class CoreUserProfilePage implements OnInit, OnDestroy { * @param handler Handler that was clicked. */ handlerClicked(event: Event, handler: CoreUserProfileHandlerData): void { - // @todo: Pass the right navCtrl if this page is in the right pane of split view. handler.action(event, this.user!, this.courseId); }