EVOgeek
/
Vmeda.Online
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MOBILE-3893 assign: Fix editing files offline 

Changes to the allowOffline property of
AddonModAssignSubmissionPluginComponent were not being detected
and passed to the submission plugin component.
main
Albert Gasset 2024-10-14 10:01:08 +02:00
parent 0e7a2789ea
commit dad261ec3c
1 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/addons/mod/assign/components/submission-plugin/submission-plugin.ts
View File

@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and // See the License for the specific language governing permissions and
// limitations under the License. // limitations under the License.
import { Component, Input, OnInit, Type, ViewChild } from '@angular/core'; import { Component, Input, OnChanges, SimpleChanges, Type, ViewChild } from '@angular/core';
import { CoreDynamicComponent } from '@components/dynamic-component/dynamic-component'; import { CoreDynamicComponent } from '@components/dynamic-component/dynamic-component';
import { import {
AddonModAssignAssign, AddonModAssignAssign,
@ -34,7 +34,7 @@ import { toBoolean } from '@/core/transforms/boolean';
selector: 'addon-mod-assign-submission-plugin', selector: 'addon-mod-assign-submission-plugin',
templateUrl: 'addon-mod-assign-submission-plugin.html', templateUrl: 'addon-mod-assign-submission-plugin.html',
}) })
export class AddonModAssignSubmissionPluginComponent implements OnInit { export class AddonModAssignSubmissionPluginComponent implements OnChanges {
@ViewChild(CoreDynamicComponent) dynamicComponent!: CoreDynamicComponent<AddonModAssignSubmissionPluginBaseComponent>; @ViewChild(CoreDynamicComponent) dynamicComponent!: CoreDynamicComponent<AddonModAssignSubmissionPluginBaseComponent>;
@ -57,7 +57,7 @@ export class AddonModAssignSubmissionPluginComponent implements OnInit {
/** /**
* @inheritdoc * @inheritdoc
*/ */
async ngOnInit(): Promise<void> { async ngOnChanges(changes: SimpleChanges): Promise<void> {
if (!this.plugin) { if (!this.plugin) {
this.pluginLoaded = true; this.pluginLoaded = true;
@ -73,8 +73,19 @@ export class AddonModAssignSubmissionPluginComponent implements OnInit {
} }
this.plugin.name = name; this.plugin.name = name;
// Check if the plugin has defined its own component to render itself. if (changes.plugin || changes.edit) {
this.pluginComponent = await AddonModAssignSubmissionDelegate.getComponentForPlugin(this.plugin, this.edit); // Check if the plugin has defined its own component to render itself.
this.pluginComponent = await AddonModAssignSubmissionDelegate.getComponentForPlugin(this.plugin, this.edit);
this.pluginLoaded = !this.pluginComponent;
if (!this.pluginComponent) {
// Data to render the plugin.
this.text = AddonModAssign.getSubmissionPluginText(this.plugin);
this.files = AddonModAssign.getSubmissionPluginAttachments(this.plugin);
this.notSupported = AddonModAssignSubmissionDelegate.isPluginSupported(this.plugin.type);
}
}
if (this.pluginComponent) { if (this.pluginComponent) {
// Prepare the data to pass to the component. // Prepare the data to pass to the component.
@ -86,12 +97,6 @@ export class AddonModAssignSubmissionPluginComponent implements OnInit {
edit: this.edit, edit: this.edit,
allowOffline: this.allowOffline, allowOffline: this.allowOffline,
}; };
} else {
// Data to render the plugin.
this.text = AddonModAssign.getSubmissionPluginText(this.plugin);
this.files = AddonModAssign.getSubmissionPluginAttachments(this.plugin);
this.notSupported = AddonModAssignSubmissionDelegate.isPluginSupported(this.plugin.type);
this.pluginLoaded = true;
} }
} }