From e48cd9a3f72130344e412b8f58cde204aaeeff7f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= <crazyserver@gmail.com>
Date: Mon, 25 Nov 2024 10:02:05 +0100
Subject: [PATCH 1/2] MOBILE-4708 quiz: Fix sync warning with empty text

---
 src/addons/mod/quiz/components/index/addon-mod-quiz-index.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/addons/mod/quiz/components/index/addon-mod-quiz-index.html b/src/addons/mod/quiz/components/index/addon-mod-quiz-index.html
index 4f98bd36d..fc556d75e 100644
--- a/src/addons/mod/quiz/components/index/addon-mod-quiz-index.html
+++ b/src/addons/mod/quiz/components/index/addon-mod-quiz-index.html
@@ -17,7 +17,7 @@
 
     <!-- Activity info. -->
     <core-course-module-info [module]="module" [description]="description" [component]="component" [componentId]="componentId"
-        [courseId]="courseId" [hasDataToSync]="buttonText && hasOffline" (completionChanged)="onCompletionChange()" />
+        [courseId]="courseId" [hasDataToSync]="!!buttonText && hasOffline" (completionChanged)="onCompletionChange()" />
 
     <!-- Access rules description messages. -->
     <ion-card *ngIf="gradeMethodReadable || accessRules.length || syncTime">

From 48ddd21e0055cbfb6c7eedd06397e81151338453 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= <crazyserver@gmail.com>
Date: Mon, 25 Nov 2024 10:36:43 +0100
Subject: [PATCH 2/2] MOBILE-4708 chore: Fix some strict boolean inputs

---
 .../messageoutput/airnotifier/pages/devices/devices.html  | 2 +-
 .../submission/addon-mod-assign-submission.html           | 2 +-
 .../fields/date/component/addon-mod-data-field-date.html  | 2 +-
 .../survey/components/index/addon-mod-survey-index.html   | 8 ++++----
 src/core/components/iframe/core-iframe.html               | 2 +-
 .../h5p/components/h5p-iframe/core-h5p-iframe.html        | 2 +-
 src/core/features/viewer/pages/iframe/iframe.html         | 2 +-
 7 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/addons/messageoutput/airnotifier/pages/devices/devices.html b/src/addons/messageoutput/airnotifier/pages/devices/devices.html
index ea9e75d30..4c139ed64 100644
--- a/src/addons/messageoutput/airnotifier/pages/devices/devices.html
+++ b/src/addons/messageoutput/airnotifier/pages/devices/devices.html
@@ -34,7 +34,7 @@
                             </p>
                         </ion-label>
                         <core-button-with-spinner [loading]="device.updating" slot="end">
-                            <ion-toggle [(ngModel)]="device.enable" (ngModelChange)="enableDevice(device, device.enable)"
+                            <ion-toggle [(ngModel)]="device.enable" (ngModelChange)="enableDevice(device, !!device.enable)"
                                 [attr.aria-labelledby]="'device-'+ device.id " />
                         </core-button-with-spinner>
                     </ion-item>
diff --git a/src/addons/mod/assign/components/submission/addon-mod-assign-submission.html b/src/addons/mod/assign/components/submission/addon-mod-assign-submission.html
index c33f6ab4b..f2e9b2414 100644
--- a/src/addons/mod/assign/components/submission/addon-mod-assign-submission.html
+++ b/src/addons/mod/assign/components/submission/addon-mod-assign-submission.html
@@ -311,7 +311,7 @@
                         <!-- Outcomes. -->
                         <ion-item class="ion-text-wrap" *ngFor="let outcome of gradeInfo!.outcomes">
                             <ion-select *ngIf="canSaveGrades && outcome.itemNumber" [(ngModel)]="outcome.selectedId"
-                                interface="action-sheet" [disabled]="gradeInfo!.disabled" [cancelText]="'core.cancel' | translate"
+                                interface="action-sheet" [disabled]="!!gradeInfo!.disabled" [cancelText]="'core.cancel' | translate"
                                 [interfaceOptions]="{header: outcome.name }">
                                 <p class="item-heading" slot="label">{{ outcome.name }}</p>
                                 <ion-select-option *ngFor="let grade of outcome.options" [value]="grade.value">
diff --git a/src/addons/mod/data/fields/date/component/addon-mod-data-field-date.html b/src/addons/mod/data/fields/date/component/addon-mod-data-field-date.html
index 6ba094c34..211336f07 100644
--- a/src/addons/mod/data/fields/date/component/addon-mod-data-field-date.html
+++ b/src/addons/mod/data/fields/date/component/addon-mod-data-field-date.html
@@ -5,7 +5,7 @@
     <ion-modal [keepContentsMounted]="true">
         <ng-template>
             <ion-datetime id="datetime" [formControlName]="'f_'+field.id" [max]="maxDate" [min]="minDate"
-                [disabled]="searchMode && searchFields && !searchFields['f_'+field.id+'_z']" presentation="date"
+                [disabled]="!!searchMode && !!searchFields && !searchFields['f_'+field.id+'_z']" presentation="date"
                 [showDefaultButtons]="true" />
         </ng-template>
     </ion-modal>
diff --git a/src/addons/mod/survey/components/index/addon-mod-survey-index.html b/src/addons/mod/survey/components/index/addon-mod-survey-index.html
index 89f179c69..661324b93 100644
--- a/src/addons/mod/survey/components/index/addon-mod-survey-index.html
+++ b/src/addons/mod/survey/components/index/addon-mod-survey-index.html
@@ -55,7 +55,7 @@
 
                 <!-- Subquestion -->
                 <ng-container *ngIf="question.parent !== 0">
-                    <ion-radio-group [(ngModel)]="answers[question.name]" [required]="question.required" [name]="question.name">
+                    <ion-radio-group [(ngModel)]="answers[question.name]" [required]="!!question.required" [name]="question.name">
                         <ion-row class="ion-align-items-center ion-padding-horizontal" [class.even]="isEven">
 
                             <ion-col size="7">
@@ -71,7 +71,7 @@
                                 <ion-radio [value]="value + 1" [attr.aria-label]="question.num + '. '+question.text + ': ' + option" />
                             </ion-col>
                             <ion-col class="ion-hide-md-up" size="5">
-                                <ion-select class="ion-padding" [(ngModel)]="answers[question.name]" [required]="question.required"
+                                <ion-select class="ion-padding" [(ngModel)]="answers[question.name]" [required]="!!question.required"
                                     [attr.aria-labelledby]="'addon-mod_survey-'+question.name" interface="action-sheet"
                                     [name]="question.name" [cancelText]="'core.cancel' | translate"
                                     [interfaceOptions]="{header: question.text}">
@@ -94,7 +94,7 @@
                             </span>
                         </ion-col>
                         <ion-col size="5">
-                            <ion-select class="ion-padding" [(ngModel)]="answers[question.name]" [required]="question.required"
+                            <ion-select class="ion-padding" [(ngModel)]="answers[question.name]" [required]="!!question.required"
                                 [attr.aria-labelledby]="'addon-mod_survey-'+question.name" interface="action-sheet" [name]="question.name"
                                 [cancelText]="'core.cancel' | translate" [interfaceOptions]="{header: question.text}">
                                 <ion-select-option [value]="question.required ? '-1' : '0'" selected [disabled]="question.required">
@@ -109,7 +109,7 @@
 
                     <ion-item *ngIf="question.type === 0" class="ion-text-wrap" [class.even]="isEven">
                         <ion-textarea labelPlacement="floating" [(ngModel)]="answers[question.name]" [name]="question.name"
-                            [required]="question.required">
+                            [required]="!!question.required">
                             <p slot="label" [core-mark-required]="question.required">
                                 <strong>{{question.num}}.</strong> {{ question.text }}
                             </p>
diff --git a/src/core/components/iframe/core-iframe.html b/src/core/components/iframe/core-iframe.html
index 09a3734d9..87e1ad40a 100644
--- a/src/core/components/iframe/core-iframe.html
+++ b/src/core/components/iframe/core-iframe.html
@@ -1,5 +1,5 @@
 <!-- Display a loading until the iframe page is loaded. -->
-<core-loading [hideUntil]="!loading && (safeUrl || launchExternalLabel)" />
+<core-loading [hideUntil]="!loading && (!!safeUrl || !!launchExternalLabel)" />
 
 <!--The iframe needs to be outside of core-loading, otherwise the request is canceled while loading. -->
 <!-- Don't add the iframe until safeUrl is set, adding an iframe with null as src causes the iframe to load the whole app. -->
diff --git a/src/core/features/h5p/components/h5p-iframe/core-h5p-iframe.html b/src/core/features/h5p/components/h5p-iframe/core-h5p-iframe.html
index 7b7876d87..64e29d48f 100644
--- a/src/core/features/h5p/components/h5p-iframe/core-h5p-iframe.html
+++ b/src/core/features/h5p/components/h5p-iframe/core-h5p-iframe.html
@@ -1,4 +1,4 @@
-<core-loading [hideUntil]="iframeSrc" [fullscreen]="false">
+<core-loading [hideUntil]="!!iframeSrc" [fullscreen]="false">
     <core-iframe *ngIf="iframeSrc" [src]="iframeSrc" iframeHeight="auto" [allowFullscreen]="true" (loaded)="iframeLoaded()"
         [showFullscreenOnToolbar]="enableInAppFullscreen" [autoFullscreenOnRotate]="enableInAppFullscreen" />
     <script *ngIf="resizeScript && iframeSrc" type="text/javascript" [src]="resizeScript"></script>
diff --git a/src/core/features/viewer/pages/iframe/iframe.html b/src/core/features/viewer/pages/iframe/iframe.html
index f102eba35..c95932560 100644
--- a/src/core/features/viewer/pages/iframe/iframe.html
+++ b/src/core/features/viewer/pages/iframe/iframe.html
@@ -9,7 +9,7 @@
     </ion-toolbar>
 </ion-header>
 <ion-content>
-    <core-loading [hideUntil]="url">
+    <core-loading [hideUntil]="!!url">
         <core-iframe *ngIf="url" [src]="url" [allowAutoLogin]="autoLogin" />
     </core-loading>
 </ion-content>