From d22b1a08e34bd9840ea6b5207f3f1d5511548994 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= Date: Tue, 27 Jul 2021 14:31:18 +0200 Subject: [PATCH] MOBILE-3833 lint: Fix strictInputAccessModifiers angular compiler option --- src/addons/mod/book/components/toc/toc.ts | 2 +- .../components/assessment/assessment.ts | 4 ++-- .../mod/workshop/components/phase/phase.ts | 2 +- src/addons/notes/components/add/add-modal.ts | 4 ++-- src/core/classes/tabs.ts | 2 +- src/core/components/combobox/combobox.ts | 2 +- src/core/components/loading/loading.ts | 2 +- src/core/components/user-avatar/user-avatar.ts | 4 ++-- .../features/rating/components/rate/rate.ts | 18 +++++++++--------- .../rating/components/ratings/ratings.ts | 14 +++++++------- .../search/components/search-box/search-box.ts | 4 ++-- 11 files changed, 29 insertions(+), 29 deletions(-) diff --git a/src/addons/mod/book/components/toc/toc.ts b/src/addons/mod/book/components/toc/toc.ts index dc3bf5c3b..ed38ca1aa 100644 --- a/src/addons/mod/book/components/toc/toc.ts +++ b/src/addons/mod/book/components/toc/toc.ts @@ -34,7 +34,7 @@ export class AddonModBookTocComponent implements OnInit { addPadding = true; showBullets = false; - @Input() protected book?: AddonModBookBookWSData; + @Input() book?: AddonModBookBookWSData; /** * Component loaded. diff --git a/src/addons/mod/workshop/components/assessment/assessment.ts b/src/addons/mod/workshop/components/assessment/assessment.ts index 42fc54af1..f165e0105 100644 --- a/src/addons/mod/workshop/components/assessment/assessment.ts +++ b/src/addons/mod/workshop/components/assessment/assessment.ts @@ -40,8 +40,8 @@ export class AddonModWorkshopAssessmentComponent implements OnInit { @Input() courseId!: number; @Input() workshop!: AddonModWorkshopData; @Input() access!: AddonModWorkshopGetWorkshopAccessInformationWSResponse; - @Input() protected submission!: AddonModWorkshopSubmissionDataWithOfflineData; - @Input() protected module!: CoreCourseModule; + @Input() submission!: AddonModWorkshopSubmissionDataWithOfflineData; + @Input() module!: CoreCourseModule; canViewAssessment = false; canSelfAssess = false; diff --git a/src/addons/mod/workshop/components/phase/phase.ts b/src/addons/mod/workshop/components/phase/phase.ts index 1e4976d40..cc5285630 100644 --- a/src/addons/mod/workshop/components/phase/phase.ts +++ b/src/addons/mod/workshop/components/phase/phase.ts @@ -28,7 +28,7 @@ export class AddonModWorkshopPhaseInfoComponent implements OnInit { @Input() phases!: AddonModWorkshopPhaseDataWithSwitch[]; @Input() workshopPhase!: AddonModWorkshopPhase; @Input() showSubmit = false; - @Input() protected externalUrl!: string; + @Input() externalUrl!: string; ngOnInit(): void { diff --git a/src/addons/notes/components/add/add-modal.ts b/src/addons/notes/components/add/add-modal.ts index 8583ce871..46b38c524 100644 --- a/src/addons/notes/components/add/add-modal.ts +++ b/src/addons/notes/components/add/add-modal.ts @@ -30,8 +30,8 @@ export class AddonNotesAddComponent { @ViewChild('itemEdit') formElement?: ElementRef; - @Input() protected courseId!: number; - @Input() protected userId?: number; + @Input() courseId!: number; + @Input() userId?: number; @Input() type: AddonNotesPublishState = 'personal'; text = ''; processing = false; diff --git a/src/core/classes/tabs.ts b/src/core/classes/tabs.ts index 285a47660..575f4c653 100644 --- a/src/core/classes/tabs.ts +++ b/src/core/classes/tabs.ts @@ -46,7 +46,7 @@ export class CoreTabsBaseComponent implements OnInit, Aft // Max height that allows tab hiding. protected static readonly MAX_HEIGHT_TO_HIDE_TABS = 768; - @Input() protected selectedIndex = 0; // Index of the tab to select. + @Input() selectedIndex = 0; // Index of the tab to select. @Input() hideUntil = false; // Determine when should the contents be shown. @Output() protected ionChange = new EventEmitter(); // Emitted when the tab changes. diff --git a/src/core/components/combobox/combobox.ts b/src/core/components/combobox/combobox.ts index 068e5c60e..617e6801d 100644 --- a/src/core/components/combobox/combobox.ts +++ b/src/core/components/combobox/combobox.ts @@ -51,7 +51,7 @@ export class CoreComboboxComponent { // Additional options when interface modal is selected. @Input() icon?: string; // Icon for modal interface. - @Input() protected modalOptions?: ModalOptions; // Will emit an event the value changed. + @Input() modalOptions?: ModalOptions; // Will emit an event the value changed. @Input() listboxId = ''; expanded = false; diff --git a/src/core/components/loading/loading.ts b/src/core/components/loading/loading.ts index 21aa0b8b5..a0254ee8b 100644 --- a/src/core/components/loading/loading.ts +++ b/src/core/components/loading/loading.ts @@ -49,7 +49,7 @@ export class CoreLoadingComponent implements OnInit, OnChanges, AfterViewInit { @Input() hideUntil: unknown; // Determine when should the contents be shown. @Input() message?: string; // Message to show while loading. - @Input() protected fullscreen = true; // Use the whole screen. + @Input() fullscreen = true; // Use the whole screen. @ViewChild('content') content?: ElementRef; diff --git a/src/core/components/user-avatar/user-avatar.ts b/src/core/components/user-avatar/user-avatar.ts index 28815d4b4..e450fe45c 100644 --- a/src/core/components/user-avatar/user-avatar.ts +++ b/src/core/components/user-avatar/user-avatar.ts @@ -38,8 +38,8 @@ export class CoreUserAvatarComponent implements OnInit, OnChanges, OnDestroy { @Input() profileUrl?: string; @Input() linkProfile = true; // Avoid linking to the profile if wanted. @Input() fullname?: string; - @Input() protected userId?: number; // If provided or found it will be used to link the image to the profile. - @Input() protected courseId?: number; + @Input() userId?: number; // If provided or found it will be used to link the image to the profile. + @Input() courseId?: number; @Input() checkOnline = false; // If want to check and show online status. @Input() extraIcon?: string; // Extra icon to show near the avatar. diff --git a/src/core/features/rating/components/rate/rate.ts b/src/core/features/rating/components/rate/rate.ts index 4a94297fe..07f7ee309 100644 --- a/src/core/features/rating/components/rate/rate.ts +++ b/src/core/features/rating/components/rate/rate.ts @@ -36,15 +36,15 @@ import { CoreEventObserver, CoreEvents } from '@singletons/events'; }) export class CoreRatingRateComponent implements OnChanges, OnDestroy { - @Input() protected ratingInfo!: CoreRatingInfo; - @Input() protected contextLevel!: ContextLevel; // Context level: course, module, user, etc. - @Input() protected instanceId!: number; // Context instance id. - @Input() protected itemId!: number; // Item id. Example: forum post id. - @Input() protected itemSetId!: number; // Item set id. Example: forum discussion id. - @Input() protected courseId!: number; - @Input() protected aggregateMethod!: number; - @Input() protected scaleId!: number; - @Input() protected userId!: number; + @Input() ratingInfo!: CoreRatingInfo; + @Input() contextLevel!: ContextLevel; // Context level: course, module, user, etc. + @Input() instanceId!: number; // Context instance id. + @Input() itemId!: number; // Item id. Example: forum post id. + @Input() itemSetId!: number; // Item set id. Example: forum discussion id. + @Input() courseId!: number; + @Input() aggregateMethod!: number; + @Input() scaleId!: number; + @Input() userId!: number; @Output() protected onLoading: EventEmitter; // Eevent that indicates whether the component is loading data. @Output() protected onUpdate: EventEmitter; // Event emitted when the rating is updated online. diff --git a/src/core/features/rating/components/ratings/ratings.ts b/src/core/features/rating/components/ratings/ratings.ts index 82fae1a91..5e938cb7a 100644 --- a/src/core/features/rating/components/ratings/ratings.ts +++ b/src/core/features/rating/components/ratings/ratings.ts @@ -26,13 +26,13 @@ import { ModalController } from '@singletons'; }) export class CoreRatingRatingsComponent implements OnInit { - @Input() protected contextLevel!: ContextLevel; - @Input() protected instanceId!: number; - @Input() protected ratingComponent!: string; - @Input() protected ratingArea!: string; - @Input() protected aggregateMethod!: number; - @Input() protected itemId!: number; - @Input() protected scaleId!: number; + @Input() contextLevel!: ContextLevel; + @Input() instanceId!: number; + @Input() ratingComponent!: string; + @Input() ratingArea!: string; + @Input() aggregateMethod!: number; + @Input() itemId!: number; + @Input() scaleId!: number; @Input() courseId!: number; loaded = false; diff --git a/src/core/features/search/components/search-box/search-box.ts b/src/core/features/search/components/search-box/search-box.ts index 9be520e24..5270c4f1b 100644 --- a/src/core/features/search/components/search-box/search-box.ts +++ b/src/core/features/search/components/search-box/search-box.ts @@ -46,12 +46,12 @@ export class CoreSearchBoxComponent implements OnInit { @Input() lengthCheck = 3; // Check value length before submit. If 0, any string will be submitted. @Input() showClear = true; // Show/hide clear button. @Input() disabled = false; // Disables the input text. - @Input() protected initialSearch = ''; // Initial search text. + @Input() initialSearch = ''; // Initial search text. /* If provided. It will save and display a history of searches for this particular Id. * To use different history lists, place different Id. * I.e. AddonMessagesContacts or CoreUserParticipants-6 (using the course Id).*/ - @Input() protected searchArea = ''; + @Input() searchArea = ''; @Output() onSubmit: EventEmitter; // Send data when submitting the search form. @Output() onClear: EventEmitter; // Send event when clearing the search form.