From cf8f8ee0ee029b20eb27ce56bfc7e383ff448377 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= <crazyserver@gmail.com>
Date: Wed, 10 Jan 2024 14:13:37 +0100
Subject: [PATCH] MOBILE-3947 notifications: Fix unreactive aria-label

---
 src/addons/notifications/pages/list/list.html        | 12 ++++++------
 .../notifications/tests/behat/notifications.feature  |  1 -
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/addons/notifications/pages/list/list.html b/src/addons/notifications/pages/list/list.html
index 16d7d3e00..3ae30321c 100644
--- a/src/addons/notifications/pages/list/list.html
+++ b/src/addons/notifications/pages/list/list.html
@@ -19,11 +19,8 @@
         <core-loading [hideUntil]="notifications.loaded">
 
             <ion-item *ngFor="let notification of notifications.items" class="ion-text-wrap"
-                [attr.aria-current]="notifications.getItemAriaCurrent(notification)" [attr.aria-label]="
-                notification.timeread
-                ? notification.subject
-                : 'addon.notifications.unreadnotification' | translate: {$a: notification.subject}"
-                (click)="notifications.select(notification)" button [detail]="false" lines="full">
+                [attr.aria-current]="notifications.getItemAriaCurrent(notification)" (click)="notifications.select(notification)" button
+                [detail]="false" lines="full">
 
                 <core-user-avatar *ngIf="notification.useridfrom > 0" [user]="notification" slot="start"
                     [profileUrl]="notification.profileimageurlfrom" [fullname]="notification.userfromfullname"
@@ -43,7 +40,10 @@
                 </ng-container>
 
                 <ion-label>
-                    <p class="item-heading">
+                    <p class="item-heading" [attr.aria-label]="
+                            notification.timeread
+                            ? notification.subject
+                            : 'addon.notifications.unreadnotification' | translate: {$a: notification.subject}">
                         <core-format-text [text]="notification.subject" contextLevel="system" [contextInstanceId]="0"
                             [wsNotFiltered]="true" />
                     </p>
diff --git a/src/addons/notifications/tests/behat/notifications.feature b/src/addons/notifications/tests/behat/notifications.feature
index 6ad776d57..fb79dcc4a 100644
--- a/src/addons/notifications/tests/behat/notifications.feature
+++ b/src/addons/notifications/tests/behat/notifications.feature
@@ -78,7 +78,6 @@ Feature: Notifications
     Then I should find "Test 10 description" in the app
     But I should not find "Test 09 description" in the app
 
-  @ionic7_failure
   Scenario: Tablet navigation
     Given I entered the app as "student1"
     And I change viewport size to "1200x640" in the app