From cb8f9732e2881fdfbde98e01acfbbdea1f13e112 Mon Sep 17 00:00:00 2001 From: Noel De Martin Date: Wed, 23 Jun 2021 15:42:45 +0200 Subject: [PATCH] MOBILE-3320 block: Avoid rendering unknown blocks --- src/core/features/block/classes/base-block-handler.ts | 10 ++-------- src/core/features/block/services/block-delegate.ts | 2 +- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/core/features/block/classes/base-block-handler.ts b/src/core/features/block/classes/base-block-handler.ts index 89c0fef81..161e7e319 100644 --- a/src/core/features/block/classes/base-block-handler.ts +++ b/src/core/features/block/classes/base-block-handler.ts @@ -13,7 +13,6 @@ // limitations under the License. import { CoreCourseBlock } from '@features/course/services/course'; -import { CoreBlockPreRenderedComponent } from '../components/pre-rendered-block/pre-rendered-block'; import { CoreBlockHandler, CoreBlockHandlerData } from '../services/block-delegate'; /** @@ -48,14 +47,9 @@ export class CoreBlockBaseHandler implements CoreBlockHandler { block: CoreCourseBlock, // eslint-disable-line @typescript-eslint/no-unused-vars contextLevel: string, // eslint-disable-line @typescript-eslint/no-unused-vars instanceId: number, // eslint-disable-line @typescript-eslint/no-unused-vars - ): CoreBlockHandlerData | Promise { - + ): undefined | CoreBlockHandlerData | Promise { // To be overridden. - return { - title: '', - class: '', - component: CoreBlockPreRenderedComponent, - }; + return undefined; } } diff --git a/src/core/features/block/services/block-delegate.ts b/src/core/features/block/services/block-delegate.ts index 481fdfaa2..593b4edbb 100644 --- a/src/core/features/block/services/block-delegate.ts +++ b/src/core/features/block/services/block-delegate.ts @@ -44,7 +44,7 @@ export interface CoreBlockHandler extends CoreDelegateHandler { block: CoreCourseBlock, contextLevel: string, instanceId: number, - ): CoreBlockHandlerData | Promise; + ): undefined | CoreBlockHandlerData | Promise; } /**