diff --git a/src/addons/mod/data/data-forms.scss b/src/addons/mod/data/data-forms.scss index bc50e228f..d49231156 100644 --- a/src/addons/mod/data/data-forms.scss +++ b/src/addons/mod/data/data-forms.scss @@ -2,9 +2,6 @@ // Edit and search modal. :host { - --input-border-color: var(--stroke); - --input-border-width: 1px; - --select-border-width: 0px; ::ng-deep { table { @@ -13,16 +10,6 @@ td { vertical-align: top; } - - .addon-data-latlong { - display: flex; - - .input-units { - flex-grow: 1; - white-space: nowrap; - align-self: center; - } - } } .addon-data-advanced-search { @@ -35,66 +22,15 @@ background-color: var(--ion-item-background); ::ng-deep { - - ion-input { - border-bottom: var(--input-border-width) solid var(--input-border-color); - &.has-focus, - &.has-focus.ion-valid, - &.ion-touched.ion-invalid { - --input-border-width: 2px; + .has-errors { + .input-highlight, + .select-highlight, + .textarea-highlight { + transform: scale(1); } - - &.has-focus { - --input-border-color: var(--primary); + core-rich-text-editor.ion-touched.ng-invalid { + --stroke: var(--danger); } - &.has-focus.ion-valid { - --input-border-color: var(--success); - } - &.ion-touched.ion-invalid { - --input-border-color: var(--danger); - } - } - - core-rich-text-editor { - border-bottom: var(--select-border-width) solid var(--input-border-color); - - &.ion-touched.ng-valid, - &.ion-touched.ng-invalid { - --select-border-width: 2px; - } - - &.ion-touched.ng-valid { - --input-border-color: var(--success); - } - &.ion-touched.ng-invalid { - --input-border-color: var(--danger); - } - } - ion-select { - border-bottom: var(--select-border-width) solid var(--input-border-color); - - &.ion-touched.ion-valid, - &.ion-touched.ion-invalid { - --select-border-width: 2px; - } - - &.ion-touched.ion-valid { - --input-border-color: var(--success); - } - &.ion-touched.ion-invalid { - --input-border-color: var(--danger); - } - } - - .has-errors ion-input.ion-invalid { - --input-border-width: 2px; - --input-border-color: var(--danger); - } - - .has-errors ion-select.ion-invalid, - .has-errors core-rich-text-editor.ng-invalid { - --select-border-width: 2px; - --input-border-color: var(--danger); } .core-mark-required { diff --git a/src/addons/mod/data/data.scss b/src/addons/mod/data/data.scss index d96d7035c..043e327a3 100644 --- a/src/addons/mod/data/data.scss +++ b/src/addons/mod/data/data.scss @@ -55,7 +55,7 @@ $grid-column-paddings: ( } // Do not let block elements to define widths or heights. - address, article, aside, blockquote, canvas, dd, div, dl, dt, fieldset, figcaption, figure, footer, form, + address, article, aside, blockquote, canvas, dd, dl, dt, fieldset, figcaption, figure, footer, form, h1, h2, h3, h4, h5, h6, header, li, main, nav, noscript, ol, p, pre, section, table, tfoot, ul, video { width: auto !important; diff --git a/src/addons/mod/data/fields/file/component/addon-mod-data-field-file.html b/src/addons/mod/data/fields/file/component/addon-mod-data-field-file.html index 1d8b879e0..db44d6faa 100644 --- a/src/addons/mod/data/fields/file/component/addon-mod-data-field-file.html +++ b/src/addons/mod/data/fields/file/component/addon-mod-data-field-file.html @@ -1,13 +1,12 @@ - - + + [allowOffline]="true" [courseId]="database?.course" [required]="field.required" /> - + - + - +
diff --git a/src/addons/mod/data/fields/latlong/component/addon-mod-data-field-latlong.html b/src/addons/mod/data/fields/latlong/component/addon-mod-data-field-latlong.html index 69cc66907..61459ed08 100644 --- a/src/addons/mod/data/fields/latlong/component/addon-mod-data-field-latlong.html +++ b/src/addons/mod/data/fields/latlong/component/addon-mod-data-field-latlong.html @@ -3,13 +3,15 @@ -
- -
°N
+
+ +
°N
+
-
- -
°E
+
+ +
°E
+
diff --git a/src/addons/mod/data/fields/menu/component/addon-mod-data-field-menu.html b/src/addons/mod/data/fields/menu/component/addon-mod-data-field-menu.html index 76391c5e2..8a0f114b2 100644 --- a/src/addons/mod/data/fields/menu/component/addon-mod-data-field-menu.html +++ b/src/addons/mod/data/fields/menu/component/addon-mod-data-field-menu.html @@ -2,7 +2,7 @@ - {{ 'addon.mod_data.menuchoose' | translate }} + {{ 'addon.mod_data.menuchoose' | translate }} diff --git a/src/addons/mod/data/fields/menu/component/menu.ts b/src/addons/mod/data/fields/menu/component/menu.ts index 9f01568a4..013ea344d 100644 --- a/src/addons/mod/data/fields/menu/component/menu.ts +++ b/src/addons/mod/data/fields/menu/component/menu.ts @@ -35,6 +35,7 @@ export class AddonModDataFieldMenuComponent extends AddonModDataFieldPluginBaseC } this.options = this.field.param1.split('\n'); + this.options = this.options.filter((option) => option !== ''); let val: string | undefined; if (this.editMode && this.value) { diff --git a/src/addons/mod/data/fields/picture/component/addon-mod-data-field-picture.html b/src/addons/mod/data/fields/picture/component/addon-mod-data-field-picture.html index 52291469f..2d198dac0 100644 --- a/src/addons/mod/data/fields/picture/component/addon-mod-data-field-picture.html +++ b/src/addons/mod/data/fields/picture/component/addon-mod-data-field-picture.html @@ -1,16 +1,15 @@ - - + + [allowOffline]="true" acceptedTypes="image" [courseId]="database?.course" [required]="field.required" /> - + - + - +