From cab43925a5ab59ffcafdbe8e0de22302cbadb46b Mon Sep 17 00:00:00 2001 From: Dani Palou Date: Wed, 2 Jun 2021 09:48:56 +0200 Subject: [PATCH] MOBILE-3320 scorm: Fix SCORM disappearing after changing tab --- src/addons/mod/scorm/pages/player/player.ts | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/addons/mod/scorm/pages/player/player.ts b/src/addons/mod/scorm/pages/player/player.ts index 382e06674..982808f42 100644 --- a/src/addons/mod/scorm/pages/player/player.ts +++ b/src/addons/mod/scorm/pages/player/player.ts @@ -362,16 +362,6 @@ export class AddonModScormPlayerPage implements OnInit, OnDestroy { } } - /** - * Page will leave. - */ - ionViewWillLeave(): void { - CoreEvents.trigger(CoreEvents.ACTIVITY_DATA_SENT, { module: 'scorm' }); - - // Empty src when leaving the state so unload event is triggered in the iframe. - this.src = ''; - } - /** * Load a SCO. * @@ -547,6 +537,10 @@ export class AddonModScormPlayerPage implements OnInit, OnDestroy { * Component being destroyed. */ ngOnDestroy(): void { + // Empty src when leaving the state so unload event is triggered in the iframe. + this.src = ''; + CoreEvents.trigger(CoreEvents.ACTIVITY_DATA_SENT, { module: 'scorm' }); + // Stop listening for events. this.tocObserver?.off(); this.launchNextObserver?.off();