Merge pull request #3718 from alfonso-salces/MOBILE-4372

MOBILE-4372 course-format: Change course index fab position if lang is rtl
main
Pau Ferrer Ocaña 2023-08-24 08:29:53 +02:00 committed by GitHub
commit c9bf366943
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 3 deletions

View File

@ -51,6 +51,7 @@ import { CoreCourseCourseIndexTourComponent } from '../course-index-tour/course-
import { CoreDom } from '@singletons/dom'; import { CoreDom } from '@singletons/dom';
import { CoreUserTourDirectiveOptions } from '@directives/user-tour'; import { CoreUserTourDirectiveOptions } from '@directives/user-tour';
import { CoreAnalytics, CoreAnalyticsEventType } from '@services/analytics'; import { CoreAnalytics, CoreAnalyticsEventType } from '@services/analytics';
import { CorePlatform } from '@services/platform';
/** /**
* Component to display course contents using a certain format. If the format isn't found, use default one. * Component to display course contents using a certain format. If the format isn't found, use default one.
@ -93,7 +94,7 @@ export class CoreCourseFormatComponent implements OnInit, OnChanges, OnDestroy {
id: 'course-index', id: 'course-index',
component: CoreCourseCourseIndexTourComponent, component: CoreCourseCourseIndexTourComponent,
side: CoreUserToursSide.Top, side: CoreUserToursSide.Top,
alignment: CoreUserToursAlignment.End, alignment: CorePlatform.isRTL ? CoreUserToursAlignment.Start : CoreUserToursAlignment.End,
getFocusedElement: nativeButton => { getFocusedElement: nativeButton => {
const innerButton = Array.from(nativeButton.shadowRoot?.children ?? []).find(child => child.tagName === 'BUTTON'); const innerButton = Array.from(nativeButton.shadowRoot?.children ?? []).find(child => child.tagName === 'BUTTON');

View File

@ -699,8 +699,6 @@ body.core-iframe-fullscreen ion-router-outlet {
--ion-safe-area-right: 0px; --ion-safe-area-right: 0px;
.modal-wrapper { .modal-wrapper {
@include margin-horizontal(var(--modal-lateral-margin), null);
position: absolute; position: absolute;
@include position(0 !important, 0 !important, 0 !important, unset !important); @include position(0 !important, 0 !important, 0 !important, unset !important);
display: block; display: block;
@ -719,6 +717,14 @@ body.core-iframe-fullscreen ion-router-outlet {
} }
} }
html:not([dir="rtl"]) {
.core-modal-lateral {
.modal-wrapper {
@include margin-horizontal(var(--modal-lateral-margin), null);
}
}
}
.core-modal-transparent-no-filter { .core-modal-transparent-no-filter {
@extend .core-modal-transparent; @extend .core-modal-transparent;
ion-backdrop { ion-backdrop {