Merge pull request #2136 from sammarshallou/MOBILE-3180

MOBILE-3180 Site plugins: Plugin pages offline can break navigation
main
Juan Leyva 2019-11-06 15:49:03 +01:00 committed by GitHub
commit c5f237001d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions

View File

@ -107,6 +107,10 @@ export class CoreSitePluginsPluginContentComponent implements OnInit, DoCheck {
this.onContentLoaded.emit(refresh); this.onContentLoaded.emit(refresh);
}).catch((error) => { }).catch((error) => {
// Make it think it's loaded - otherwise it sticks on 'loading' and stops navigation working.
this.content = '<div></div>';
this.onContentLoaded.emit(refresh);
this.domUtils.showErrorModalDefault(error, 'core.errorloadingcontent', true); this.domUtils.showErrorModalDefault(error, 'core.errorloadingcontent', true);
}).finally(() => { }).finally(() => {
this.dataLoaded = true; this.dataLoaded = true;