diff --git a/src/core/pipes/pipes.module.ts b/src/core/pipes/pipes.module.ts index a7783dbd7..b8b197300 100644 --- a/src/core/pipes/pipes.module.ts +++ b/src/core/pipes/pipes.module.ts @@ -22,7 +22,6 @@ import { CoreFormatDatePipe } from './format-date'; import { CoreNoTagsPipe } from './no-tags'; import { CoreSecondsToHMSPipe } from './seconds-to-hms'; import { CoreTimeAgoPipe } from './time-ago'; -import { CoreToLocaleStringPipe } from './to-locale-string'; @NgModule({ declarations: [ @@ -34,8 +33,6 @@ import { CoreToLocaleStringPipe } from './to-locale-string'; CoreNoTagsPipe, CoreSecondsToHMSPipe, CoreTimeAgoPipe, - // eslint-disable-next-line deprecation/deprecation - CoreToLocaleStringPipe, ], exports: [ CoreBytesToSizePipe, @@ -46,8 +43,6 @@ import { CoreToLocaleStringPipe } from './to-locale-string'; CoreNoTagsPipe, CoreSecondsToHMSPipe, CoreTimeAgoPipe, - // eslint-disable-next-line deprecation/deprecation - CoreToLocaleStringPipe, ], }) export class CorePipesModule {} diff --git a/src/core/pipes/to-locale-string.ts b/src/core/pipes/to-locale-string.ts deleted file mode 100644 index 7159f70a4..000000000 --- a/src/core/pipes/to-locale-string.ts +++ /dev/null @@ -1,68 +0,0 @@ -// (C) Copyright 2015 Moodle Pty Ltd. -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -import { Pipe, PipeTransform } from '@angular/core'; -import { CoreTimeUtils } from '@services/utils/time'; - -import { CoreLogger } from '@singletons/logger'; - -/** - * Filter to format a timestamp to a locale string. Timestamp can be in seconds or milliseconds. - * - * @deprecated since 3.6. Use coreFormatDate instead. - * This pipe wasn't removed in app 4.0 because some site plugins still used it. It will be removed in future versions - * (see MOBILE-2823). - */ -@Pipe({ - name: 'coreToLocaleString', -}) -export class CoreToLocaleStringPipe implements PipeTransform { - - protected logger: CoreLogger; - - constructor() { - this.logger = CoreLogger.getInstance('CoreToLocaleStringPipe'); - } - - /** - * Format a timestamp to a locale string. - * - * @param timestamp The timestamp (can be in seconds or milliseconds). - * @returns Formatted time. - */ - transform(timestamp: number | string): string { - if (typeof timestamp == 'string') { - // Convert the value to a number. - const numberTimestamp = parseInt(timestamp, 10); - if (isNaN(numberTimestamp)) { - this.logger.error('Invalid value received', timestamp); - - return timestamp; - } - timestamp = numberTimestamp; - } - - if (timestamp < 0) { - // Date not valid. - return ''; - } - if (timestamp < 100000000000) { - // Timestamp is in seconds, convert it to milliseconds. - timestamp = timestamp * 1000; - } - - return CoreTimeUtils.userDate(timestamp, 'core.strftimedatetimeshort'); - } - -} diff --git a/upgrade.txt b/upgrade.txt index 84f9ca6f9..b574fc614 100644 --- a/upgrade.txt +++ b/upgrade.txt @@ -4,12 +4,10 @@ For more information about upgrading, read the official documentation: https://m === 4.4.0 === -- Starting with this release, this file will only document breaking changes for APIs exposed to site plugins. Internal changes will no longer be documented. -- CoreCache has been deprecated, use plain object as in-memory stores instead. - -=== 4.4.0 === - + - Starting with this release, this file will only document breaking changes for APIs exposed to site plugins. Internal changes will no longer be documented. + - CoreCache has been deprecated, use plain object as in-memory stores instead. - Renamed CoreLoginSitesComponent to CoreLoginSitesModalComponent to make it clear that it's a modal and to avoid confusing it with the new CoreSitesListComponent. + - Removed CoreToLocaleStringPipe deprecated since 3.6.0 === 4.3.0 ===