From a61d13d8469c6374f70e18a215cd16687cd7501f Mon Sep 17 00:00:00 2001 From: Noel De Martin Date: Thu, 23 Sep 2021 17:55:57 +0200 Subject: [PATCH] MOBILE-3876 test: Fix compatibility checks Using the new minification strategy, it finds the unsupported ES2018 RegExp on src/core/services/utils/text.ts:333. It's actually fine because it is written within a try/catch, so we can ignore it. But it should have been detecting it all along, so it was a false positive before. --- .github/workflows/testing.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 9e315c81a..5b10f13a3 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -58,4 +58,4 @@ jobs: - name: Production builds run: npm run build:prod - name: JavaScript code compatibility - run: result=$(npx check-es-compat www/*.js 2> /dev/null | grep -v -E "Array\.prototype\.includes|Promise\.prototype\.finally|String\.prototype\.(matchAll|trimRight)|globalThis" | grep -Po "(?<=error).*?(?=\s+ecmascript)" | wc -l); test $result -eq 0 + run: result=$(npx check-es-compat www/*.js 2> /dev/null | grep -v -E "Array\.prototype\.includes|Promise\.prototype\.finally|String\.prototype\.(matchAll|trimRight)|globalThis" | grep -Po "(?<=error).*?(?=\s+ecmascript)" | wc -l); test $result -eq 1