MOBILE-3744 a11y: Improve some aria roles

src/addons/messages/components/conversation-info/conversation-info.html

@@ -18,7 +18,7 @@
             <ion-label>
                 <div class="large-avatar">
                     <img class="avatar" [src]="conversation!.imageurl" core-external-content [alt]="conversation!.name"
-                    role="presentation" onError="this.src='assets/img/group-avatar.png'">
+                    onError="this.src='assets/img/group-avatar.png'">
                 </div>
                 <h2>
                     <core-format-text [text]="conversation!.name" contextLevel="system" [contextInstanceId]="0"></core-format-text>

src/addons/messages/pages/discussion/discussion.html

@@ -6,7 +6,7 @@
         <ion-title>
             <div class="toolbar-title">
                 <img *ngIf="loaded && !otherMember && conversationImage" class="core-bar-button-image" [src]="conversationImage"
-                    [alt]="title" onError="this.src='assets/img/group-avatar.png'" core-external-content role="presentation"
+                    alt="" onError="this.src='assets/img/group-avatar.png'" core-external-content role="presentation"
                     [siteId]="siteId || null">
                 <core-user-avatar *ngIf="loaded && otherMember" class="core-bar-button-image" [user]="otherMember"
                     [linkProfile]="false" [checkOnline]="otherMember.showonlinestatus" (click)="showInfo && viewInfo()">

src/addons/messages/pages/group-conversations/group-conversations.html

@@ -34,7 +34,7 @@
                 <!-- Favourite conversations. -->
                 <ion-item-divider class="ion-text-wrap core-expandable" (click)="toggle(favourites)" sticky="true"
                     [attr.aria-label]="(favourites.expanded ? 'core.collapse' : 'core.expand') | translate"
-                    [attr.aria-expanded]="favourites.expanded">
+                    [attr.aria-expanded]="favourites.expanded" role="heading">
                     <ion-icon *ngIf="!favourites.expanded" name="fas-caret-right" slot="start" aria-hidden="true"></ion-icon>
                     <ion-icon *ngIf="favourites.expanded" name="fas-caret-down" slot="start" aria-hidden="true"></ion-icon>
                     <ion-label>{{ 'core.favourites' | translate }} ({{ favourites.count }})</ion-label>
@@ -57,7 +57,7 @@
                 <!-- Group conversations. -->
                 <ion-item-divider class="ion-text-wrap core-expandable" (click)="toggle(group)" sticky="true"
                     [attr.aria-label]="(group.expanded ? 'core.collapse' : 'core.expand') | translate"
-                    [attr.aria-expanded]="group.expanded">
+                    [attr.aria-expanded]="group.expanded" role="heading">
                     <ion-icon *ngIf="!group.expanded" name="fas-caret-right" slot="start" aria-hidden="true"></ion-icon>
                     <ion-icon *ngIf="group.expanded" name="fas-caret-down" slot="start" aria-hidden="true"></ion-icon>
                     <ion-label>{{ 'addon.messages.groupconversations' | translate }} ({{ group.count }})</ion-label>
@@ -79,7 +79,7 @@
 
                 <ion-item-divider class="ion-text-wrap core-expandable" (click)="toggle(individual)" sticky="true"
                     [attr.aria-label]="(individual.expanded ? 'core.collapse' : 'core.expand') | translate"
-                    [attr.aria-expanded]="individual.expanded">
+                    [attr.aria-expanded]="individual.expanded" role="heading">
                     <ion-icon *ngIf="!individual.expanded" name="fas-caret-right" slot="start" aria-hidden="true"></ion-icon>
                     <ion-icon *ngIf="individual.expanded" name="fas-caret-down" slot="start" aria-hidden="true"></ion-icon>
                     <ion-label>{{ 'addon.messages.individualconversations' | translate }} ({{ individual.count }})</ion-label>

src/addons/mod/data/components/action/addon-mod-data-action.html

@@ -32,7 +32,7 @@ component="mod_data" [itemId]="entry.id" area="database_entry" [courseId]="datab
 
 <a *ngIf="action == 'userpicture'" core-user-link [courseId]="database.course" [userId]="entry.userid" [title]="entry.fullname">
     <img class="avatar-round" [src]="userPicture" [alt]="'core.pictureof' | translate:{$a: entry.fullname}" core-external-content
-    onError="this.src='assets/img/user-avatar.png'" role="presentation">
+    onError="this.src='assets/img/user-avatar.png'">
 </a>
 
 <a *ngIf="action == 'user' && entry" core-user-link [courseId]="database.course" [userId]="entry.userid" [title]="entry.fullname">

src/addons/mod/feedback/pages/form/form.html

@@ -59,7 +59,7 @@
                             </ng-container>
 
                             <ion-textarea *ngIf="item.templateName == 'textarea'" [required]="item.required"
-                                name="{{item.typ}}_{{item.id}}" [attr.aria-multiline]="true" [(ngModel)]="item.value">
+                                name="{{item.typ}}_{{item.id}}" [(ngModel)]="item.value">
                             </ion-textarea>
 
                             <ion-select *ngIf="item.templateName == 'multichoice-d'" [required]="item.required"

src/addons/mod/forum/components/edit-post/edit-post.html

@@ -25,8 +25,8 @@
                 (contentChanged)="onMessageChange($event)">
             </core-rich-text-editor>
         </ion-item>
-        <ion-item-divider class="ion-text-wrap core-expandable" (click)="toggleAdvanced()"
+        <ion-item-divider class="ion-text-wrap core-expandable" (click)="toggleAdvanced()" role="heading"
-            [attr.aria-expanded]="advanced" [attr.aria-label]="(advanced ? 'core.hideadvanced' : 'core.showadvanced') |translate">
+            [attr.aria-expanded]="advanced" [attr.aria-label]="(advanced ? 'core.hideadvanced' : 'core.showadvanced') | translate">
             <ion-icon *ngIf="!advanced" name="fa-caret-right" slot="start" aria-hidden="true"></ion-icon>
             <ion-icon *ngIf="advanced" name="fa-caret-down" slot="start" aria-hidden="true"></ion-icon>
             <ion-label>{{ 'addon.mod_forum.advanced' | translate }}</ion-label>

src/addons/mod/forum/components/index/index.html

@@ -71,7 +71,7 @@
                 <ion-button *ngIf="sortingAvailable" id="addon-mod-forum-sort-order-button"
                     class="core-button-select button-no-uppercase"
                     aria-haspopup="true" aria-controls="addon-mod-forum-sort-order-selector"
-                    [attr.aria-label]="('core.sort' | translate)" [attr.aria-expanded]="sortOrderSelectorExpanded"
+                    [attr.aria-label]="('core.sort' | translate)"
                     (click)="showSortOrderSelector()">
                     <span class="core-button-select-text">{{ selectedSortOrder.label | translate }}</span>
                     <div class="select-icon" slot="end"><div class="select-icon-inner"></div></div>

src/addons/mod/forum/components/index/index.ts

@@ -79,7 +79,6 @@ export class AddonModForumIndexComponent extends CoreCourseModuleMainActivityCom
     sortingAvailable!: boolean;
     sortOrders: AddonModForumSortOrder[] = [];
     selectedSortOrder: AddonModForumSortOrder | null = null;
-    sortOrderSelectorExpanded = false;
     canPin = false;
 
     protected syncEventName = AddonModForumSyncProvider.AUTO_SYNCED;
@@ -637,12 +636,8 @@ export class AddonModForumIndexComponent extends CoreCourseModuleMainActivityCom
 
         modal.present();
 
-        this.sortOrderSelectorExpanded = true;
-
         const result = await modal.onDidDismiss<AddonModForumSortOrder>();
 
-        this.sortOrderSelectorExpanded = false;
-
         if (result.data && result.data.value != this.selectedSortOrder?.value) {
             this.selectedSortOrder = result.data;
             this.page = 0;

src/addons/mod/forum/components/sort-order-selector/sort-order-selector.html

@@ -11,9 +11,9 @@
 <ion-content>
     <ion-list id="addon-mod-forum-sort-selector" role="menu" aria-labelledby="addon-mod-forum-sort-order-button">
         <ng-container *ngFor="let sortOrder of sortOrders">
-            <ion-item class="ion-text-wrap" detail="false" role="menuitem"
+            <ion-item class="ion-text-wrap" detail="false" role="combobox" button aria-haspopup="dialog"
-                [class.core-selected-item]="selected == sortOrder.value" [attr.aria-label]="sortOrder.label | translate"
+                [attr.aria-current]="selected == sortOrder.value ? 'page' :  'false'"
-                (click)="selectSortOrder(sortOrder)">
+                [attr.aria-label]="sortOrder.label | translate" (click)="selectSortOrder(sortOrder)">
                 <ion-label>
                     <h2>{{ sortOrder.label | translate }}</h2>
                 </ion-label>

src/addons/mod/forum/pages/new-discussion/new-discussion.html

@@ -32,7 +32,7 @@
                 </core-rich-text-editor>
             </ion-item>
             <ion-item-divider class="ion-text-wrap core-expandable" (click)="toggleAdvanced()" [attr.aria-expanded]="advanced"
-                [attr.aria-label]="(advanced ? 'core.hideadvanced' : 'core.showadvanced') |translate">
+                [attr.aria-label]="(advanced ? 'core.hideadvanced' : 'core.showadvanced') |translate" role="heading">
                 <ion-icon *ngIf="!advanced" name="fa-caret-right" slot="start" aria-hidden="true"></ion-icon>
                 <ion-icon *ngIf="advanced" name="fa-caret-down" slot="start" aria-hidden="true"></ion-icon>
                 <ion-label>{{ 'addon.mod_forum.advanced' | translate }}</ion-label>

src/addons/mod/quiz/pages/player/player.html

@@ -11,7 +11,7 @@
 
         <ion-buttons slot="end">
             <ion-button id="addon-mod_quiz-connection-error-button" [hidden]="!autoSaveError" (click)="showConnectionError($event)"
-                [attr.aria-label]="'addon.mod_quiz.connectionerror' | translate" aria-haspopup="true">
+                [attr.aria-label]="'addon.mod_quiz.connectionerror' | translate" aria-haspopup="dialog">
                 <ion-icon name="fas-exclamation-circle" slot="icon-only" aria-hidden="true"></ion-icon>
             </ion-button>
             <ion-button *ngIf="navigation.length" [attr.aria-label]="'addon.mod_quiz.opentoc' | translate"

src/addons/mod/workshop/assessment/accumulative/component/addon-mod-workshop-assessment-strategy-accumulative.html

@@ -32,7 +32,7 @@
             <ion-label position="stacked">
                 {{ 'addon.mod_workshop_assessment_accumulative.dimensioncommentfor' | translate : {'$a': field.dimtitle } }}
             </ion-label>
-            <ion-textarea aria-multiline="true" [(ngModel)]="selectedValues[n].peercomment" core-auto-rows></ion-textarea>
+            <ion-textarea [(ngModel)]="selectedValues[n].peercomment" core-auto-rows></ion-textarea>
         </ion-item>
         <ion-item *ngIf="!edit" class="ion-text-wrap">
             <ion-label>

src/addons/mod/workshop/assessment/comments/component/addon-mod-workshop-assessment-strategy-comments.html

@@ -14,7 +14,7 @@
                     {{ 'addon.mod_workshop_assessment_comments.dimensioncommentfor' | translate : {'$a': field.dimtitle } }}
                 </span>
             </ion-label>
-            <ion-textarea aria-multiline="true" [(ngModel)]="selectedValues[n].peercomment" core-auto-rows></ion-textarea>
+            <ion-textarea [(ngModel)]="selectedValues[n].peercomment" core-auto-rows></ion-textarea>
             <core-input-errors *ngIf="fieldErrors['peercomment_' + n]" [errorText]="fieldErrors['peercomment_' + n]">
             </core-input-errors>
         </ion-item>

src/addons/mod/workshop/assessment/numerrors/component/addon-mod-workshop-assessment-strategy-numerrors.html

@@ -35,7 +35,7 @@
             <ion-label position="stacked">
                 {{ 'addon.mod_workshop_assessment_numerrors.dimensioncommentfor' | translate : {'$a': field.dimtitle } }}
             </ion-label>
-            <ion-textarea aria-multiline="true" [(ngModel)]="selectedValues[n].peercomment" [name]="'peercomment_' + n"
+            <ion-textarea [(ngModel)]="selectedValues[n].peercomment" [name]="'peercomment_' + n"
                 core-auto-rows>
             </ion-textarea>
         </ion-item>

src/addons/qtype/essay/component/addon-qtype-essay.html

@@ -22,7 +22,7 @@
             <ion-textarea *ngIf="essayQuestion.isPlainText" class="core-question-textarea"
                 [ngClass]='{"core-monospaced": essayQuestion.isMonospaced}'
                 placeholder="{{ 'core.question.answer' | translate }}"
-                [attr.name]="essayQuestion.textarea.name" aria-multiline="true" [ngModel]="essayQuestion.textarea.text">
+                [attr.name]="essayQuestion.textarea.name" [ngModel]="essayQuestion.textarea.text">
             </ion-textarea>
             <!-- Rich text editor. -->
             <core-rich-text-editor *ngIf="!essayQuestion.isPlainText" placeholder="{{ 'core.question.answer' | translate }}"

src/core/components/context-menu/context-menu.ts

@@ -35,7 +35,6 @@ export class CoreContextMenuComponent implements OnInit, OnDestroy {
     @Input('aria-label') ariaLabel?: string; // Aria label to be shown on the top of the popover.
 
     hideMenu = true; // It will be unhidden when items are added.
-    expanded = false;
     uniqueId: string;
 
     protected items: CoreContextMenuItemComponent[] = [];
@@ -43,6 +42,7 @@ export class CoreContextMenuComponent implements OnInit, OnDestroy {
     protected itemsChangedStream: Subject<void>; // Stream to update the hideMenu boolean when items change.
     protected instanceId: string;
     protected parentContextMenu?: CoreContextMenuComponent;
+    protected expanded = false;
 
     constructor(
         elementRef: ElementRef,

src/core/components/context-menu/core-context-menu.html

@@ -1,5 +1,5 @@
-<ion-button [hidden]="hideMenu" fill="clear" [attr.aria-label]="ariaLabel"
+<ion-button [hidden]="hideMenu" fill="clear" [attr.aria-label]="ariaLabel" (click)="showContextMenu($event)" aria-haspopup="true"
-(click)="showContextMenu($event)" aria-haspopup="true" [attr.aria-expanded]="expanded" [attr.aria-controls]="uniqueId">
+    [attr.aria-controls]="uniqueId">
     <ion-icon [name]="icon" slot="icon-only" aria-hidden="true">
     </ion-icon>
 </ion-button>

src/core/components/empty-box/core-empty-box.html

@@ -1,8 +1,7 @@
 <div class="core-empty-box ion-padding" [class.core-empty-box-inline]="(!image && !icon) || inline">
     <div class="core-empty-box-content">
-        <img *ngIf="image && !icon" [src]="image" role="presentation" aria-hidden="true">
+        <img *ngIf="image && !icon" [src]="image" role="presentation" alt="">
-        <ion-icon *ngIf="icon" [name]="icon" [class.icon-flip-rtl]="flipIconRtl" role="presentation" aria-hidden="true">
+        <ion-icon *ngIf="icon" [name]="icon" [class.icon-flip-rtl]="flipIconRtl" aria-hidden="true"></ion-icon>
-        </ion-icon>
         <p *ngIf="message" [class.ion-padding-top]="image || icon">{{ message }}</p>
         <ng-content></ng-content>
     </div>

src/core/components/send-message-form/core-send-message-form.html

@@ -1,8 +1,7 @@
 <form #messageForm>
     <textarea class="core-send-message-input" [autofocus]="showKeyboard" [placeholder]="placeholder" rows="1" core-auto-rows
         [(ngModel)]="message" name="message" (onResize)="textareaResized()" (keydown.enter)="enterClicked($event)"
-        (keydown.control.enter)="enterClicked($event, 'control')" (keydown.meta.enter)="enterClicked($event, 'meta')"
+        (keydown.control.enter)="enterClicked($event, 'control')" (keydown.meta.enter)="enterClicked($event, 'meta')"></textarea>
-        aria-multiline="true"></textarea>
     <ion-buttons>
         <ion-button fill="clear" type="submit" [disabled]="!message || sendDisabled"
             [attr.aria-label]="'core.send' | translate" [core-suppress-events] (onClick)="submitForm($event)">

src/core/components/user-avatar/core-user-avatar.html

@@ -1,7 +1,7 @@
 <img *ngIf="avatarUrl" [src]="avatarUrl" [alt]="'core.pictureof' | translate:{$a: fullname}" core-external-content
-    onError="this.src='assets/img/user-avatar.png'" role="presentation" (click)="gotoProfile($event)">
+    onError="this.src='assets/img/user-avatar.png'" (click)="gotoProfile($event)">
 
-<img *ngIf="!avatarUrl" src="assets/img/user-avatar.png" [alt]="'core.pictureof' | translate:{$a: fullname}" role="presentation"
+<img *ngIf="!avatarUrl" src="assets/img/user-avatar.png" [alt]="'core.pictureof' | translate:{$a: fullname}"
     (click)="gotoProfile($event)">
 
 <span *ngIf="checkOnline && isOnline()" class="contact-status online"></span>

src/core/features/contentlinks/pages/choose-site/choose-site.html

@@ -18,7 +18,7 @@
             <ion-item *ngFor="let site of sites" (click)="siteClicked(site.id)" detail="false">
                 <ion-avatar slot="start">
                     <img [src]="site.avatar" core-external-content [siteId]="site.id"
-                        alt="{{ 'core.pictureof' | translate:{$a: site.fullName} }}" role="presentation"
+                        alt="{{ 'core.pictureof' | translate:{$a: site.fullName} }}"
                         onError="this.src='assets/img/user-avatar.png'">
                 </ion-avatar>
                 <ion-label>

src/core/features/course/components/format/core-course-format.html

@@ -20,8 +20,7 @@
                     class="ion-text-wrap clearfix ion-justify-content-between core-button-selector-row"
                     [class.core-section-download]="downloadEnabled">
                     <ion-button class="core-button-select button-no-uppercase" (click)="showSectionSelector()"
-                        aria-haspopup="true" [attr.aria-expanded]="sectionSelectorExpanded"
+                        aria-haspopup="listbox" id="core-course-section-button" expand="block">
-                        id="core-course-section-button" expand="block">
                         <ion-icon name="fas-folder" slot="start" aria-hidden="true"></ion-icon>
                         <span class="sr-only" *ngIf="selectedSection">{{ 'core.course.sections' | translate }}:</span>
                         <span class="core-button-select-text">

src/core/features/course/components/format/format.ts

@@ -91,7 +91,6 @@ export class CoreCourseFormatComponent implements OnInit, OnChanges, OnDestroy {
 
     canLoadMore = false;
     showSectionId = 0;
-    sectionSelectorExpanded = false;
     data: Record<string, unknown> = {}; // Data to pass to the components.
 
     displaySectionSelector?: boolean;
@@ -109,6 +108,7 @@ export class CoreCourseFormatComponent implements OnInit, OnChanges, OnDestroy {
     protected sectionStatusObserver?: CoreEventObserver;
     protected selectTabObserver?: CoreEventObserver;
     protected lastCourseFormat?: string;
+    protected sectionSelectorExpanded = false;
 
     constructor(
         protected content: IonContent,

src/core/features/course/components/module-completion/core-course-module-completion.html

@@ -1,3 +1,3 @@
-<button *ngIf="completion" (click)="completionClicked($event)">
+<button *ngIf="completion" (click)="completionClicked($event)" [title]="completionDescription">
-    <img [src]="completionImage" [alt]="completionDescription">
+    <img [src]="completionImage" role="presentation" alt="">
 </button>

src/core/features/login/components/site-onboarding/site-onboarding.html

@@ -16,7 +16,7 @@
 <ion-content class="ion-padding">
     <div>
         <div class="ion-text-center ion-padding core-login-site-logo">
-            <img src="assets/img/login_logo.png" class="avatar-full login-logo" role="presentation">
+            <img src="assets/img/login_logo.png" class="avatar-full login-logo" role="presentation" alt="">
         </div>
 
         <h3 class="core-login-onboarding-step">

src/core/features/login/pages/credentials/credentials.html

@@ -19,8 +19,8 @@
         <div class="ion-text-wrap ion-text-center ion-margin-bottom">
             <div class="core-login-site-logo">
                 <!-- Show site logo or a default image. -->
-                <img *ngIf="logoUrl" [src]="logoUrl" role="presentation" onError="this.src='assets/img/login_logo.png'">
+                <img *ngIf="logoUrl" [src]="logoUrl" role="presentation" alt="" onError="this.src='assets/img/login_logo.png'">
-                <img *ngIf="!logoUrl" src="assets/img/login_logo.png" role="presentation">
+                <img *ngIf="!logoUrl" src="assets/img/login_logo.png" role="presentation" alt="">
             </div>
 
             <h3 *ngIf="siteName" class="ion-padding core-sitename">

src/core/features/login/pages/reconnect/reconnect.html

@@ -11,13 +11,12 @@
     <div class="ion-text-wrap ion-text-center ion-margin-bottom" [ngClass]="{'item-avatar-center': showSiteAvatar}">
         <!-- Show user avatar. -->
         <img *ngIf="showSiteAvatar" [src]="userAvatar" class="large-avatar" core-external-content [siteId]="siteId"
-            role="presentation"
             alt="{{ 'core.pictureof' | translate:{$a: userFullName} }}" onError="this.src='assets/img/user-avatar.png'">
 
         <div class="core-login-site-logo" *ngIf="!showSiteAvatar">
             <!-- Show site logo or a default image. -->
-            <img *ngIf="logoUrl" [src]="logoUrl" role="presentation" onError="this.src='assets/img/login_logo.png'">
+            <img *ngIf="logoUrl" [src]="logoUrl" role="presentation" onError="this.src='assets/img/login_logo.png'" alt="">
-            <img *ngIf="!logoUrl" src="assets/img/login_logo.png" role="presentation">
+            <img *ngIf="!logoUrl" src="assets/img/login_logo.png" role="presentation" alt="">
         </div>
 
         <h6 *ngIf="siteName" class="ion-padding core-sitename">

src/core/features/login/pages/site/site.html

@@ -17,7 +17,7 @@
 <ion-content class="ion-padding">
     <div class="ion-text-center ion-padding ion-margin-bottom core-login-site-logo"
         [class.hidden]="hasSites || enteredSiteUrl">
-        <img src="assets/img/login_logo.png" class="avatar-full login-logo" role="presentation">
+        <img src="assets/img/login_logo.png" class="avatar-full login-logo" role="presentation" alt="">
     </div>
     <form [formGroup]="siteForm" (ngSubmit)="connect($event, siteForm.value.siteUrl)" *ngIf="!fixedSites" #siteFormEl>
         <!-- Form to input the site URL if there are no fixed sites. -->
@@ -102,7 +102,7 @@
     <ng-container *ngIf="showScanQR && !hasSites && !enteredSiteUrl">
         <div class="ion-text-center ion-padding ion-margin-top">{{ 'core.login.or' | translate }}</div>
         <ion-button expand="block" color="light" class="ion-margin" lines="none" (click)="showInstructionsAndScanQR()"
-            aria-haspopup="true">
+            aria-haspopup="dialog">
             <ion-icon slot="start" name="fas-qrcode" aria-hidden="true"></ion-icon>
             <ion-label>{{ 'core.scanqr' | translate }}</ion-label>
         </ion-button>
@@ -111,7 +111,7 @@
     <!-- Help. -->
     <ion-list lines="none" class="ion-margin-top">
         <ion-item button class="ion-text-center ion-text-wrap core-login-need-help" (click)="showHelp()" detail="false"
-            aria-haspopup="true">
+            aria-haspopup="dialog">
             <ion-label>{{ 'core.needhelp' | translate }}</ion-label>
         </ion-item>
     </ion-list>

src/core/features/login/pages/sites/sites.html

@@ -21,7 +21,7 @@
     <ion-list>
         <ion-item button (click)="login(site.id)" *ngFor="let site of sites">
             <ion-avatar slot="start">
-                <img [src]="site.avatar" core-external-content [siteId]="site.id" role="presentation"
+                <img [src]="site.avatar" core-external-content [siteId]="site.id"
                     alt="{{ 'core.pictureof' | translate:{$a: site.fullName} }}" onError="this.src='assets/img/user-avatar.png'">
             </ion-avatar>
             <ion-label>

src/core/features/login/services/login-helper.ts

@@ -48,8 +48,8 @@ export class CoreLoginHelperProvider {
     static readonly OPEN_COURSE = 'open_course';
 
     static readonly ONBOARDING_DONE = 'onboarding_done';
-    static readonly FAQ_URL_IMAGE_HTML = '<img src="assets/img/login/faq_url.png" role="presentation">';
+    static readonly FAQ_URL_IMAGE_HTML = '<img src="assets/img/login/faq_url.png" role="presentation" alt="">';
-    static readonly FAQ_QRCODE_IMAGE_HTML = '<img src="assets/img/login/faq_qrcode.png" role="presentation">';
+    static readonly FAQ_QRCODE_IMAGE_HTML = '<img src="assets/img/login/faq_qrcode.png" role="presentation" alt="">';
 
     protected logger: CoreLogger;
     protected isSSOConfirmShown = false;

src/core/features/sharedfiles/pages/choose-site/choose-site.html

@@ -18,7 +18,7 @@
             <ion-item *ngFor="let site of sites" (click)="storeInSite(site.id)" detail="false">
                 <ion-avatar slot="start" aria-hidden="true">
                     <img [src]="site.avatar" core-external-content [siteId]="site.id"
-                        alt="{{ 'core.pictureof' | translate:{$a: site.fullname} }}" role="presentation"
+                        alt="{{ 'core.pictureof' | translate:{$a: site.fullname} }}"
                         onError="this.src='assets/img/user-avatar.png'">
                 </ion-avatar>
                 <ion-label>