From 9ee0abd6ed5da6a1ebdafa155eda34d5fc3c8b02 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= <crazyserver@gmail.com>
Date: Tue, 14 Jul 2020 10:02:13 +0200
Subject: [PATCH] MOBILE-3452 workshop: Fix some workshop submission styles

---
 .../index/addon-mod-workshop-index.html           |  6 +++---
 .../submission/addon-mod-workshop-submission.html |  4 ++--
 .../components/submission/submission.scss         | 15 ++++++++++++---
 src/app/app.scss                                  |  4 ++--
 src/theme/variables.scss                          |  2 +-
 5 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/src/addon/mod/workshop/components/index/addon-mod-workshop-index.html b/src/addon/mod/workshop/components/index/addon-mod-workshop-index.html
index c10216d25..f662c02ae 100644
--- a/src/addon/mod/workshop/components/index/addon-mod-workshop-index.html
+++ b/src/addon/mod/workshop/components/index/addon-mod-workshop-index.html
@@ -112,7 +112,7 @@
                     <h2>{{ 'addon.mod_workshop.publishedsubmissions' | translate }}</h2>
                 </ion-item-divider>
                 <ng-container *ngFor="let submission of publishedSubmissions">
-                    <addon-mod-workshop-submission [submission]="submission" [courseId]="workshop.course" [module]="module" [workshop]="workshop" [access]="access" summary="true"></addon-mod-workshop-submission>
+                    <addon-mod-workshop-submission [submission]="submission" [courseId]="workshop.course" [module]="module" [workshop]="workshop" [access]="access" summary="true" class="core-as-item"></addon-mod-workshop-submission>
                 </ng-container>
             </ion-card>
         </ng-container>
@@ -134,7 +134,7 @@
                     <p>{{ 'addon.mod_workshop.assignedassessmentsnone' | translate }}</p>
                 </ion-item>
                 <ng-container *ngFor="let assessment of (assessments || [])">
-                    <addon-mod-workshop-submission [submission]="assessment.submission" [assessment]="assessment" [courseId]="workshop.course" [module]="module" [workshop]="workshop" [access]="access" summary="true"></addon-mod-workshop-submission>
+                    <addon-mod-workshop-submission [submission]="assessment.submission" [assessment]="assessment" [courseId]="workshop.course" [module]="module" [workshop]="workshop" [access]="access" summary="true" class="core-as-item"></addon-mod-workshop-submission>
                 </ng-container>
             </ion-card >
         </ng-container>
@@ -156,7 +156,7 @@
             </ion-item>
 
             <ng-container *ngFor="let submission of grades">
-                <addon-mod-workshop-submission [submission]="submission" [courseId]="workshop.course" [module]="module" [workshop]="workshop" [access]="access" summary="true"></addon-mod-workshop-submission>
+                <addon-mod-workshop-submission [submission]="submission" [courseId]="workshop.course" [module]="module" [workshop]="workshop" [access]="access" summary="true" class="core-as-item"></addon-mod-workshop-submission>
             </ng-container>
 
             <ion-grid *ngIf="page > 0 || hasNextPage">
diff --git a/src/addon/mod/workshop/components/submission/addon-mod-workshop-submission.html b/src/addon/mod/workshop/components/submission/addon-mod-workshop-submission.html
index 70b4e7063..b0b54fde5 100644
--- a/src/addon/mod/workshop/components/submission/addon-mod-workshop-submission.html
+++ b/src/addon/mod/workshop/components/submission/addon-mod-workshop-submission.html
@@ -1,6 +1,6 @@
 <core-loading [hideUntil]="loaded">
     <div *ngIf="!summary">
-        <ion-list-header text-wrap>
+        <ion-item text-wrap class="addon-workshop-submission-title">
             <ion-avatar core-user-avatar [user]="profile" [courseId]="courseId" [userId]="profile && profile.id" item-start></ion-avatar>
             <h2><core-format-text [text]="submission.title" contextLevel="module" [contextInstanceId]="module.id" [courseId]="courseId"></core-format-text></h2>
             <p *ngIf="profile && profile.fullname">{{profile.fullname}}</p>
@@ -21,7 +21,7 @@
                 <ng-container *ngIf="submission.offline"><ion-icon name="time"></ion-icon> {{ 'core.notsent' | translate }}</ng-container>
                 <ng-container *ngIf="submission.deleted"><ion-icon name="trash"></ion-icon> {{ 'core.deletedoffline' | translate }}</ng-container>
             </ion-note>
-        </ion-list-header>
+        </ion-item>
         <ion-item text-wrap *ngIf="submission.content">
             <core-format-text [component]="component" [componentId]="componentId" [text]="submission.content" contextLevel="module" [contextInstanceId]="module.id" [courseId]="courseId"></core-format-text>
         </ion-item>
diff --git a/src/addon/mod/workshop/components/submission/submission.scss b/src/addon/mod/workshop/components/submission/submission.scss
index 6775a13ac..6b67768d9 100644
--- a/src/addon/mod/workshop/components/submission/submission.scss
+++ b/src/addon/mod/workshop/components/submission/submission.scss
@@ -1,4 +1,13 @@
-ion-app.app-root addon-mod-workshop-submission,
-ion-app.app-root .card.with-borders addon-mod-workshop-submission {
-  @include core-as-items();
+ion-app.app-root addon-mod-workshop-submission .addon-workshop-submission-title {
+
+    &.item-ios {
+        border-bottom: $list-ios-header-border-bottom;
+    }
+    &.item-md {
+        border-bottom: 1px solid $list-md-border-color;
+    }
+
+    &:last-child {
+        border: 0;
+    }
 }
\ No newline at end of file
diff --git a/src/app/app.scss b/src/app/app.scss
index 51e512502..05557bc56 100644
--- a/src/app/app.scss
+++ b/src/app/app.scss
@@ -113,8 +113,8 @@ ion-app.app-root {
     @include core-as-items();
   }
 
-  .card.with-borders .item,
-  .list.with-borders .item {
+  .card.with-borders > .item,
+  .list.with-borders > .item {
     @include core-items();
   }
 
diff --git a/src/theme/variables.scss b/src/theme/variables.scss
index 61f401678..20a2d27e9 100644
--- a/src/theme/variables.scss
+++ b/src/theme/variables.scss
@@ -527,7 +527,7 @@ $core-dd-question-colors: $white, $blue-light, #DCDCDC, #D8BFD8, #87CEFA, #DAA52
     border-bottom: $hairlines-width solid $list-ios-border-color;
   }
 
-  &:last-child > .item-inner {
+  &.item-block:last-child > .item-inner {
     border-bottom: 0;
   }
 }