From 95013c2fdad13f1a693ca9f3576d03df4448358e Mon Sep 17 00:00:00 2001 From: Alfonso Salces Date: Tue, 18 Apr 2023 12:19:14 +0200 Subject: [PATCH] MOBILE-4245 dev: Listen staging sites changes after view enter --- src/core/features/settings/pages/dev/dev.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/core/features/settings/pages/dev/dev.ts b/src/core/features/settings/pages/dev/dev.ts index ee30001a5..c916950cb 100644 --- a/src/core/features/settings/pages/dev/dev.ts +++ b/src/core/features/settings/pages/dev/dev.ts @@ -45,7 +45,7 @@ export class CoreSettingsDevPage implements OnInit { userToursEnabled = true; stagingSitesCount = 0; enableStagingSites?: boolean; - listenStagingSitesChanges = false; + previousEnableStagingSites?: boolean; disabledFeatures: string[] = []; @@ -64,7 +64,7 @@ export class CoreSettingsDevPage implements OnInit { if (this.stagingSitesCount) { this.enableStagingSites = await CoreSettingsHelper.hasEnabledStagingSites(); - this.listenStagingSitesChanges = true; + this.previousEnableStagingSites = this.enableStagingSites; } if (!this.siteId) { @@ -170,17 +170,15 @@ export class CoreSettingsDevPage implements OnInit { } async setEnabledStagingSites(enabled: boolean): Promise { - if (!this.listenStagingSitesChanges) { - this.listenStagingSitesChanges = true; - + if (this.enableStagingSites === this.previousEnableStagingSites) { return; } try { await CoreSettingsHelper.setEnabledStagingSites(enabled); + this.previousEnableStagingSites = enabled; } catch (error) { this.enableStagingSites = !enabled; - this.listenStagingSitesChanges = false; CoreDomUtils.showErrorModal(error); } }