Merge pull request #2940 from NoelDeMartin/MOBILE-3833

MOBILE-3833: Tweaks

src/core/features/settings/pages/about/about.html

@@ -10,6 +10,7 @@
 </ion-header>
 
 <ion-content>
+    <ion-list>
         <ion-item class="ion-text-wrap">
             <ion-label><h2>{{ appName }} {{ versionName }}</h2></ion-label>
         </ion-item>
@@ -39,4 +40,5 @@
             <ion-icon name="fas-bullhorn" slot="start" aria-hidden="true"></ion-icon>
             <ion-label>{{ 'core.settings.helpusimprove' | translate }}</ion-label>
         </ion-item>
+    </ion-list>
 </ion-content>

src/core/features/settings/pages/deviceinfo/deviceinfo.html

@@ -15,6 +15,7 @@
 </ion-header>
 
 <ion-content>
+    <ion-list>
         <ion-item (longPress)="copyItemInfo($event)">
             <ion-label class="ion-text-wrap">
                 <h2>{{ 'core.settings.appversion' | translate}}</h2>
@@ -39,7 +40,11 @@
         <ion-item *ngIf="deviceInfo.fileSystemRoot" (longPress)="copyItemInfo($event)">
             <ion-label class="ion-text-wrap">
                 <h2>{{ 'core.settings.filesystemroot' | translate }}</h2>
-            <p><a *ngIf="fsClickable" [href]="deviceInfo.fileSystemRoot" core-link auto-login="no">{{ deviceInfo.fileSystemRoot }}</a></p>
+                <p>
+                    <a *ngIf="fsClickable" [href]="deviceInfo.fileSystemRoot" core-link auto-login="no">
+                        {{ deviceInfo.fileSystemRoot }}
+                    </a>
+                </p>
                 <p *ngIf="!fsClickable">{{ deviceInfo.fileSystemRoot }}</p>
             </ion-label>
         </ion-item>
@@ -139,4 +144,5 @@
                 <p>{{ 'core.' + deviceInfo.localNotifAvailable | translate }}</p>
             </ion-label>
         </ion-item>
+    </ion-list>
 </ion-content>

src/core/features/settings/pages/general/general.html

@@ -8,6 +8,7 @@
     </ion-toolbar>
 </ion-header>
 <ion-content>
+    <ion-list>
         <ion-item class="ion-text-wrap">
             <ion-label>
                 <h2>{{ 'core.settings.language' | translate }}</h2>
@@ -77,4 +78,5 @@
             </ion-label>
             <ion-toggle [(ngModel)]="analyticsEnabled" (ionChange)="analyticsEnabledChanged()"></ion-toggle>
         </ion-item>
+    </ion-list>
 </ion-content>

src/core/features/settings/pages/licenses/licenses.html

@@ -9,6 +9,7 @@
 </ion-header>
 <ion-content>
     <core-loading [hideUntil]="loaded">
+        <ion-list>
             <ion-item button *ngIf="error" class="ion-text-wrap" [href]="licensesUrl" core-link auto-login="no">
                 <ion-label>
                     {{ 'core.settings.opensourcelicenses' | translate }}
@@ -16,7 +17,6 @@
                 <ion-button [href]="licensesUrl" target="_blank" fill="clear" slot="end" core-link auto-login="no">
                     {{ 'core.view' | translate }}</ion-button>
             </ion-item>
-
             <ng-container *ngIf="!error">
                 <ion-item *ngFor="let license of licenses" class="ion-text-wrap">
                     <ion-label>
@@ -37,5 +37,6 @@
                         fill="clear" slot="end" core-link auto-login="no">{{ 'core.view' | translate }}</ion-button>
                 </ion-item>
             </ng-container>
+        </ion-list>
     </core-loading>
 </ion-content>

src/core/features/settings/pages/space-usage/space-usage.html

@@ -18,6 +18,7 @@
         <ion-refresher-content pullingText="{{ 'core.pulltorefresh' | translate }}"></ion-refresher-content>
     </ion-refresher>
     <core-loading [hideUntil]="loaded">
+        <ion-list>
             <ion-item *ngFor="let site of sites" [attr.aria-current]="site.id == currentSiteId ? 'page' : 'false'">
                 <ion-label class="ion-text-wrap">
                     <p class="item-heading">
@@ -43,5 +44,6 @@
                     {{ totals.spaceUsage | coreBytesToSize }}
                 </p>
             </ion-item-divider>
+        </ion-list>
     </core-loading>
 </ion-content>

src/core/features/settings/pages/synchronization/synchronization.html

@@ -15,6 +15,7 @@
 </ion-header>
 <ion-content>
     <core-loading [hideUntil]="sitesLoaded">
+        <ion-list>
             <ion-item-divider>
                 <ion-label>
                     <h2>{{ 'core.settings.syncsettings' | translate }}</h2>
@@ -45,5 +46,6 @@
                     </ion-button>
                 </core-button-with-spinner>
             </ion-item>
+        </ion-list>
     </core-loading>
 </ion-content>

src/theme/theme.light.scss

@@ -87,7 +87,7 @@
     --core-bottom-tabs-background: var(--black);
     --core-bottom-tabs-color: var(--gray-lighter);
     --core-bottom-tabs-color-selected: var(--brand-color);
-    --core-bottom-tabs-background-selected: var(--core-bottom-tabs-background);
+    --core-bottom-tabs-background-selected: transparent;
     --core-bottom-tabs-badge-color: var(--brand-color);
     --core-bottom-tabs-badge-text-color: var(--brand-color-contrast);
     --bottom-tabs-size: 56px;