EVOgeek
/
Vmeda.Online
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #2552 from crazyserver/MOBILE-3523 

MOBILE-3469 course: Remove unused property
main
Dani Palou 2020-09-29 09:45:51 +02:00 committed by GitHub
parent ad2b5c4529 ce9ec993c5
commit 8d95636690
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/core/course/providers/course.ts
View File

@ -985,6 +985,7 @@ export class CoreCourseProvider {
await this.sitePluginsProvider.waitFetchPlugins(); await this.sitePluginsProvider.waitFetchPlugins();
if (typeof course.format == 'undefined') { if (typeof course.format == 'undefined') {
// This block can be replaced by a call to CourseHelper.getCourse(), but it is circular dependant.
const coursesProvider = CoreCourses.instance; const coursesProvider = CoreCourses.instance;
try { try {
course = await coursesProvider.getUserCourse(course.id, true); course = await coursesProvider.getUserCourse(course.id, true);

25
src/core/courses/pages/course-preview/course-preview.ts
View File

@ -24,7 +24,6 @@ import { CoreCoursesProvider } from '../../providers/courses';
import { CoreCourseOptionsDelegate } from '@core/course/providers/options-delegate'; import { CoreCourseOptionsDelegate } from '@core/course/providers/options-delegate';
import { CoreCourseProvider } from '@core/course/providers/course'; import { CoreCourseProvider } from '@core/course/providers/course';
import { CoreCourseHelperProvider } from '@core/course/providers/helper'; import { CoreCourseHelperProvider } from '@core/course/providers/helper';
import { CoreCourseFormatDelegate } from '@core/course/providers/format-delegate';
/** /**
* Page that allows "previewing" a course and enrolling in it if enabled and not enrolled. * Page that allows "previewing" a course and enrolling in it if enabled and not enrolled.
@ -64,13 +63,23 @@ export class CoreCoursesCoursePreviewPage implements OnDestroy {
protected currentInstanceId: number; protected currentInstanceId: number;
protected courseStatusObserver; protected courseStatusObserver;
constructor(private navCtrl: NavController, navParams: NavParams, private sitesProvider: CoreSitesProvider, constructor(
private domUtils: CoreDomUtilsProvider, private textUtils: CoreTextUtilsProvider, appProvider: CoreAppProvider, protected navCtrl: NavController,
private coursesProvider: CoreCoursesProvider, private platform: Platform, private modalCtrl: ModalController, navParams: NavParams,
private translate: TranslateService, private eventsProvider: CoreEventsProvider, protected sitesProvider: CoreSitesProvider,
private courseOptionsDelegate: CoreCourseOptionsDelegate, private courseHelper: CoreCourseHelperProvider, protected domUtils: CoreDomUtilsProvider,
private courseProvider: CoreCourseProvider, private courseFormatDelegate: CoreCourseFormatDelegate, protected textUtils: CoreTextUtilsProvider,
private zone: NgZone) { appProvider: CoreAppProvider,
protected coursesProvider: CoreCoursesProvider,
protected platform: Platform,
protected modalCtrl: ModalController,
protected translate: TranslateService,
protected eventsProvider: CoreEventsProvider,
protected courseOptionsDelegate: CoreCourseOptionsDelegate,
protected courseHelper: CoreCourseHelperProvider,
protected courseProvider: CoreCourseProvider,
protected zone: NgZone
) {
this.course = navParams.get('course'); this.course = navParams.get('course');
this.avoidOpenCourse = navParams.get('avoidOpenCourse'); this.avoidOpenCourse = navParams.get('avoidOpenCourse');