MOBILE-3744 lint: Fix linting errors introduced by the update of eslint

src/addons/mod/url/components/index/addon-mod-url-index.html

@@ -26,11 +26,11 @@
     <ion-list *ngIf="!shouldIframe && (!shouldEmbed || !isOther)">
         <ion-item *ngIf="shouldEmbed">
             <ion-label>
-                <img *ngIf="isImage" title="{{name}}" [src]="url">
+                <img *ngIf="isImage" [alt]="name" [src]="url">
-                <video *ngIf="isVideo" title="{{name}}" controls>
+                <video *ngIf="isVideo" [title]="name" controls>
                     <source [src]="url" [type]="mimetype">
                 </video>
-                <audio *ngIf="isAudio" title="{{name}}" controls>
+                <audio *ngIf="isAudio" [title]="name" controls>
                     <source [src]="url" [type]="mimetype">
                 </audio>
             </ion-label>

src/core/classes/site.ts

@@ -659,7 +659,9 @@ export class CoreSite {
                 preSets.omitExpires = true;
                 preSets.getFromCache = true;
 
-                return this.getFromCache<T>(method, data, preSets, true).catch(() => Promise.reject(new CoreWSError(error)));
+                return this.getFromCache<T>(method, data, preSets, true).catch(() => {
+                    throw new CoreWSError(error);
+                });
             });
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
         }).then((response: any) => {

src/core/components/progress-bar/core-progress-bar.html

@@ -1,5 +1,5 @@
 <ng-container *ngIf="progress >= 0">
-    <progress max="100" [value]="progress" role="progressbar" aria-valuemin="0" aria-valuemax="100" [attr.aria-valuenow]="progress">
+    <progress max="100" [value]="progress" role="progressbar" [attr.aria-valuenow]="progress">
     </progress>
     <div class="core-progress-text">{{ 'core.percentagenumber' | translate: {$a: text} }}</div>
 </ng-container>

src/core/features/grades/pages/grade/grade.html

@@ -18,7 +18,7 @@
             capture="true">
                 <ion-icon *ngIf="grade.icon" name="{{grade.icon}}" slot="start" [attr.aria-label]="grade.iconAlt"></ion-icon>
                 <img *ngIf="grade.image" [src]="grade.image" slot="start" class="core-module-icon"
-                    [attr.aria-label]="grade.iconAlt"/>
+                    [alt]="grade.iconAlt">
                 <ion-label>
                     <h2><core-format-text [text]="grade.itemname" contextLevel="course" [contextInstanceId]="courseId">
                     </core-format-text></h2>

src/core/features/login/pages/site/site.html

@@ -121,8 +121,8 @@
 <ng-template #site let-site="site">
     <ion-item button (click)="connect($event, site.url, site)" [attr.aria-label]="site.name" detail="true">
         <ion-thumbnail *ngIf="siteFinderSettings.displayimage" slot="start">
-            <img [src]="site.imageurl" *ngIf="site.imageurl" onError="this.src='assets/icon/icon.png'">
+            <img [src]="site.imageurl" *ngIf="site.imageurl" onError="this.src='assets/icon/icon.png'" alt="" role="presentation">
-            <img src="assets/icon/icon.png" *ngIf="!site.imageurl" class="core-login-default-icon">
+            <img src="assets/icon/icon.png" *ngIf="!site.imageurl" class="core-login-default-icon" alt="" role="presentation">
         </ion-thumbnail>
         <ion-label>
             <h2 *ngIf="site.title" class="ion-text-wrap">{{site.title}}</h2>

src/core/features/search/components/search-box/core-search-box.html

@@ -18,7 +18,7 @@
         </ion-item>
         <ion-list class="core-search-history" [hidden]="!historyShown">
             <ion-item button class="ion-text-wrap" *ngFor="let item of history"
-                (click)="historyClicked($event, item.searchedtext)" tabindex="1" detail>
+                (click)="historyClicked($event, item.searchedtext)" tabindex="0" detail="true">
                 <ion-icon name="fas-history" slot="start" aria-hidden="true">
                 </ion-icon>
                 <ion-label>{{item.searchedtext}}</ion-label>