From 6bb6aa4da3991006b57d4b49b531db858a3bcd52 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= <crazyserver@gmail.com>
Date: Tue, 9 Jul 2024 10:49:44 +0200
Subject: [PATCH] MOBILE-4594 styles: Fix some styles from migration

---
 .../messages/pages/discussion/discussion.html |  2 +-
 src/core/features/courses/pages/my/my.html    |  2 +-
 src/theme/components/ion-fab.scss             | 19 ------
 src/theme/components/ion-select.scss          |  4 --
 src/theme/theme.scss                          | 58 +++++++++----------
 5 files changed, 30 insertions(+), 55 deletions(-)

diff --git a/src/addons/messages/pages/discussion/discussion.html b/src/addons/messages/pages/discussion/discussion.html
index 0524b379a..6425cc125 100644
--- a/src/addons/messages/pages/discussion/discussion.html
+++ b/src/addons/messages/pages/discussion/discussion.html
@@ -77,7 +77,7 @@
                     {{ message.timecreated | coreFormatDate: "strftimedayshort" }}
                 </h3>
 
-                <ion-chip class="addon-messages-unreadfrom" *ngIf="unreadMessageFrom > 0 && message.id === unreadMessageFrom" color="light">
+                <ion-chip class="addon-messages-unreadfrom" *ngIf="unreadMessageFrom > 0 && message.id === unreadMessageFrom">
                     <ion-label>{{ 'addon.messages.newmessages' | translate }}</ion-label>
                     <ion-icon name="fas-arrow-down" aria-hidden="true" />
                 </ion-chip>
diff --git a/src/core/features/courses/pages/my/my.html b/src/core/features/courses/pages/my/my.html
index de4cf18de..933afcc04 100644
--- a/src/core/features/courses/pages/my/my.html
+++ b/src/core/features/courses/pages/my/my.html
@@ -27,7 +27,7 @@
                 <!-- Download all courses. -->
                 <div *ngIf="downloadCoursesEnabled && myOverviewBlock && myOverviewBlock.filteredCourses.length > 0"
                     class="core-button-spinner">
-                    <ion-button *ngIf="!myOverviewBlock.prefetchCoursesData.loading" fill="clear"
+                    <ion-button *ngIf="!myOverviewBlock.prefetchCoursesData.loading" fill="clear" size="default"
                         (click)="myOverviewBlock.prefetchCourses()"
                         [attr.aria-label]="myOverviewBlock.prefetchCoursesData.statusTranslatable | translate">
                         <ion-icon [name]="myOverviewBlock.prefetchCoursesData.icon" slot="icon-only" aria-hidden="true" />
diff --git a/src/theme/components/ion-fab.scss b/src/theme/components/ion-fab.scss
index f6eee8464..9adfb69c3 100644
--- a/src/theme/components/ion-fab.scss
+++ b/src/theme/components/ion-fab.scss
@@ -6,25 +6,6 @@ ion-fab[core-fab] {
     }
 }
 
-// The following 4 selectors can probably be removed after Ionic migration to 7+
-ion-fab.fab-horizontal-start {
-    left: calc(10px + var(--ion-safe-area-right, 0px));
-}
-
-&[dir=rtl] ion-fab.fab-horizontal-start {
-    right: calc(10px + var(--ion-safe-area-right, 0px));
-    left: unset
-}
-
-ion-fab.fab-horizontal-end {
-    right: calc(10px + var(--ion-safe-area-right, 0px));
-}
-
-&[dir=rtl] ion-fab.fab-horizontal-end {
-    left: calc(10px + var(--ion-safe-area-right, 0px));
-    right: unset
-}
-
 ion-content.has-collapsible-footer ion-fab {
     bottom: calc(var(--core-collapsible-footer-height, 0px) + 10px);
     @include core-transition(all, 200ms);
diff --git a/src/theme/components/ion-select.scss b/src/theme/components/ion-select.scss
index 7c177c9b1..37b2f21a2 100644
--- a/src/theme/components/ion-select.scss
+++ b/src/theme/components/ion-select.scss
@@ -15,10 +15,6 @@ ion-select {
 }
 
 ion-select-popover {
-    ion-list ion-radio-group ion-item.select-interface-option ion-radio.hydrated::part(container) {
-        opacity: 1;
-    }
-
     ion-item {
         font-size: var(--text-size);
     }
diff --git a/src/theme/theme.scss b/src/theme/theme.scss
index 68ebd08b9..e35ae118a 100644
--- a/src/theme/theme.scss
+++ b/src/theme/theme.scss
@@ -29,36 +29,34 @@
 @import "components/videojs.scss";
 
 /* Ionic components overrides */
-:root {
-    @import "components/ion-accordion.scss";
-    @import "components/ion-action-sheet.scss";
-    @import "components/ion-alert.scss";
-    @import "components/ion-avatar.scss";
-    @import "components/ion-back-button.scss";
-    @import "components/ion-badge.scss";
-    @import "components/ion-button.scss";
-    @import "components/ion-card.scss";
-    @import "components/ion-checkbox.scss";
-    @import "components/ion-chip.scss";
-    @import "components/ion-content.scss";
-    @import "components/ion-datetime.scss";
-    @import "components/ion-fab.scss";
-    @import "components/ion-header.scss";
-    @import "components/ion-icon.scss";
-    @import "components/ion-input.scss";
-    @import "components/ion-item.scss";
-    @import "components/ion-item-divider.scss";
-    @import "components/ion-modal.scss";
-    @import "components/ion-loading.scss";
-    @import "components/ion-note.scss";
-    @import "components/ion-popover.scss";
-    @import "components/ion-radio.scss";
-    @import "components/ion-searchbar.scss";
-    @import "components/ion-select.scss";
-    @import "components/ion-spinner.scss";
-    @import "components/ion-toast.scss";
-    @import "components/swiper.scss";
-}
+@import "components/ion-accordion.scss";
+@import "components/ion-action-sheet.scss";
+@import "components/ion-alert.scss";
+@import "components/ion-avatar.scss";
+@import "components/ion-back-button.scss";
+@import "components/ion-badge.scss";
+@import "components/ion-button.scss";
+@import "components/ion-card.scss";
+@import "components/ion-checkbox.scss";
+@import "components/ion-chip.scss";
+@import "components/ion-content.scss";
+@import "components/ion-datetime.scss";
+@import "components/ion-fab.scss";
+@import "components/ion-header.scss";
+@import "components/ion-icon.scss";
+@import "components/ion-input.scss";
+@import "components/ion-item.scss";
+@import "components/ion-item-divider.scss";
+@import "components/ion-modal.scss";
+@import "components/ion-loading.scss";
+@import "components/ion-note.scss";
+@import "components/ion-popover.scss";
+@import "components/ion-radio.scss";
+@import "components/ion-searchbar.scss";
+@import "components/ion-select.scss";
+@import "components/ion-spinner.scss";
+@import "components/ion-toast.scss";
+@import "components/swiper.scss";
 
 /* Some styles from 3rd party libraries. */
 @import "components/bootstrap/utilities/screenreaders.scss";