EVOgeek/Vmeda.Online
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MOBILE-3320 assign: Fix errors when feedback is undefined

Browse Source
This commit is contained in:
Dani Palou 2021-06-30 10:27:28 +02:00
parent 8fd64f85c0
commit 6a3e8073cd
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/addons/mod/assign/components/submission/addon-mod-assign-submission.html
View File

@ -280,9 +280,11 @@
</ion-item> </ion-item>
</ng-container> </ng-container>
<addon-mod-assign-feedback-plugin *ngFor="let plugin of feedback!.plugins" [assign]="assign" <ng-container *ngIf="feedback">
[submission]="userSubmission" [userId]="submitId" [plugin]="plugin" [canEdit]="canSaveGrades"> <addon-mod-assign-feedback-plugin *ngFor="let plugin of feedback.plugins" [assign]="assign"
</addon-mod-assign-feedback-plugin> [submission]="userSubmission" [userId]="submitId" [plugin]="plugin" [canEdit]="canSaveGrades">
</addon-mod-assign-feedback-plugin>
</ng-container>
<!-- Workflow status. --> <!-- Workflow status. -->
<ion-item class="ion-text-wrap" *ngIf="workflowStatusTranslationId"> <ion-item class="ion-text-wrap" *ngIf="workflowStatusTranslationId">
@ -338,7 +340,7 @@
</ion-item> </ion-item>
<!-- Grader is hidden, display only the grade date. --> <!-- Grader is hidden, display only the grade date. -->
<ion-item class="ion-text-wrap" *ngIf="!grader && feedback!.gradeddate"> <ion-item class="ion-text-wrap" *ngIf="!grader && feedback?.gradeddate">
<ion-label> <ion-label>
<h2>{{ 'addon.mod_assign.gradedon' | translate }}</h2> <h2>{{ 'addon.mod_assign.gradedon' | translate }}</h2>
<p>{{ feedback!.gradeddate * 1000 | coreFormatDate }}</p> <p>{{ feedback!.gradeddate * 1000 | coreFormatDate }}</p>

4
src/addons/mod/assign/components/submission/submission.ts
View File

@ -671,8 +671,8 @@ export class AddonModAssignSubmissionComponent implements OnInit, OnDestroy, Can
AddonModAssign.getSubmissionGradingStatusTranslationId(this.grade.gradingStatus); AddonModAssign.getSubmissionGradingStatusTranslationId(this.grade.gradingStatus);
} }
if (this.lastAttempt?.gradingstatus == 'graded' && !this.assign!.markingworkflow && this.userSubmission) { if (this.lastAttempt?.gradingstatus == 'graded' && !this.assign!.markingworkflow && this.userSubmission && feedback) {
if (this.feedback!.gradeddate < this.userSubmission.timemodified) { if (feedback.gradeddate < this.userSubmission.timemodified) {
this.lastAttempt.gradingstatus = AddonModAssignProvider.GRADED_FOLLOWUP_SUBMIT; this.lastAttempt.gradingstatus = AddonModAssignProvider.GRADED_FOLLOWUP_SUBMIT;
// Get grading text and color. // Get grading text and color.