From 69d59cd2ab9b9b5fb2f2cae8c7fa83cab258b752 Mon Sep 17 00:00:00 2001
From: Noel De Martin <noel@moodle.com>
Date: Tue, 8 Jun 2021 19:24:35 +0200
Subject: [PATCH] MOBILE-3320 a11y: Add missing labels

---
 .../component/addon-mod-assign-feedback-comments.html         | 2 +-
 .../password/component/addon-mod-quiz-access-password.html    | 2 +-
 src/addons/mod/wiki/pages/edit/edit.html                      | 4 ++--
 src/addons/notes/components/add/add-modal.html                | 2 +-
 src/addons/qtype/essay/component/addon-qtype-essay.html       | 2 +-
 .../components/self-enrol-password/self-enrol-password.html   | 2 +-
 .../login/pages/forgotten-password/forgotten-password.html    | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/addons/mod/assign/feedback/comments/component/addon-mod-assign-feedback-comments.html b/src/addons/mod/assign/feedback/comments/component/addon-mod-assign-feedback-comments.html
index 5032d3482..b56fbcdd8 100644
--- a/src/addons/mod/assign/feedback/comments/component/addon-mod-assign-feedback-comments.html
+++ b/src/addons/mod/assign/feedback/comments/component/addon-mod-assign-feedback-comments.html
@@ -24,7 +24,7 @@
 
 <!-- Edit -->
 <ion-item class="ion-text-wrap" *ngIf="edit && loaded">
-    <ion-label></ion-label>
+    <ion-label class="sr-only">{{ plugin.name }}</ion-label>
     <core-rich-text-editor [control]="control" [placeholder]="plugin.name"
         name="assignfeedbackcomments_editor" [component]="component" [componentId]="assign.cmid" [autoSave]="true"
         contextLevel="module" [contextInstanceId]="assign.cmid" elementId="assignfeedbackcomments_editor"
diff --git a/src/addons/mod/quiz/accessrules/password/component/addon-mod-quiz-access-password.html b/src/addons/mod/quiz/accessrules/password/component/addon-mod-quiz-access-password.html
index 5ab743e6f..9b713053e 100644
--- a/src/addons/mod/quiz/accessrules/password/component/addon-mod-quiz-access-password.html
+++ b/src/addons/mod/quiz/accessrules/password/component/addon-mod-quiz-access-password.html
@@ -5,7 +5,7 @@
     </ion-label>
 </ion-item>
 <ion-item [formGroup]="form">
-    <ion-label></ion-label>
+    <ion-label class="sr-only">{{ 'addon.mod_quiz.quizpassword' | translate }}</ion-label>
     <core-show-password [name]="'quizpassword'">
         <ion-input id="addon-mod_quiz-accessrule-password-input" name="quizpassword" type="password"
             placeholder="{{ 'addon.mod_quiz.quizpassword' | translate }}" [formControlName]="'quizpassword'" [clearOnEdit]="false">
diff --git a/src/addons/mod/wiki/pages/edit/edit.html b/src/addons/mod/wiki/pages/edit/edit.html
index babf9f585..3d30531df 100644
--- a/src/addons/mod/wiki/pages/edit/edit.html
+++ b/src/addons/mod/wiki/pages/edit/edit.html
@@ -19,14 +19,14 @@
     <core-loading [hideUntil]="loaded">
         <form [formGroup]="pageForm" #editPageForm *ngIf="loaded">
             <ion-item class="ion-text-wrap" *ngIf="canEditTitle">
-                <ion-label></ion-label>
+                <ion-label class="sr-only">{{ 'addon.mod_wiki.newpagetitle' | translate }}</ion-label>
                 <ion-input name="title" type="text" [placeholder]="'addon.mod_wiki.newpagetitle' | translate"
                     formControlName="title">
                 </ion-input>
             </ion-item>
 
             <ion-item>
-                <ion-label></ion-label>
+                <ion-label class="sr-only">{{ 'core.content' | translate }}</ion-label>
                 <core-rich-text-editor [control]="contentControl" [placeholder]="'core.content' | translate"
                     name="wiki_page_content" [component]="component" [componentId]="cmId" [autoSave]="true" contextLevel="module"
                     [contextInstanceId]="cmId" elementId="newcontent_editor" [draftExtraParams]="editorExtraParams">
diff --git a/src/addons/notes/components/add/add-modal.html b/src/addons/notes/components/add/add-modal.html
index 843df9053..1f30665e1 100644
--- a/src/addons/notes/components/add/add-modal.html
+++ b/src/addons/notes/components/add/add-modal.html
@@ -19,7 +19,7 @@
             </ion-select>
         </ion-item>
         <ion-item>
-            <ion-label></ion-label>
+            <ion-label class="sr-only">{{ 'addon.notes.note' | translate }}</ion-label>
             <ion-textarea placeholder="{{ 'addon.notes.note' | translate }}" rows="5" [(ngModel)]="text" name="text"
                 required="required">
             </ion-textarea>
diff --git a/src/addons/qtype/essay/component/addon-qtype-essay.html b/src/addons/qtype/essay/component/addon-qtype-essay.html
index 820882739..40e4359b7 100644
--- a/src/addons/qtype/essay/component/addon-qtype-essay.html
+++ b/src/addons/qtype/essay/component/addon-qtype-essay.html
@@ -12,7 +12,7 @@
     <ng-container *ngIf="!review">
         <!-- Textarea. -->
         <ion-item *ngIf="essayQuestion.textarea && (!essayQuestion.hasDraftFiles || uploadFilesSupported)">
-            <ion-label></ion-label>
+            <ion-label class="sr-only">{{ 'core.question.answer' | translate }}</ion-label>
             <!-- "Format" and draftid hidden inputs -->
             <input *ngIf="essayQuestion.formatInput" type="hidden" [name]="essayQuestion.formatInput.name"
                 [value]="essayQuestion.formatInput.value" >
diff --git a/src/core/features/courses/components/self-enrol-password/self-enrol-password.html b/src/core/features/courses/components/self-enrol-password/self-enrol-password.html
index d0d755fbb..e718d5487 100644
--- a/src/core/features/courses/components/self-enrol-password/self-enrol-password.html
+++ b/src/core/features/courses/components/self-enrol-password/self-enrol-password.html
@@ -12,7 +12,7 @@
 <ion-content class="ion-padding">
     <form (ngSubmit)="submitPassword($event)" #enrolPasswordForm>
         <ion-item>
-            <ion-label></ion-label>
+            <ion-label class="sr-only">{{ 'core.courses.password' | translate }}</ion-label>
             <core-show-password name="password">
                 <ion-input
                     class="ion-text-wrap core-ioninput-password"
diff --git a/src/core/features/login/pages/forgotten-password/forgotten-password.html b/src/core/features/login/pages/forgotten-password/forgotten-password.html
index ddf156f93..015eb8d7e 100644
--- a/src/core/features/login/pages/forgotten-password/forgotten-password.html
+++ b/src/core/features/login/pages/forgotten-password/forgotten-password.html
@@ -29,7 +29,7 @@
                 </ion-item>
             </ion-radio-group>
             <ion-item>
-                <ion-label></ion-label>
+                <ion-label class="sr-only">{{ 'core.login.usernameoremail' | translate }}</ion-label>
                 <ion-input type="text" name="value" placeholder="{{ 'core.login.usernameoremail' | translate }}"
                     formControlName="value" autocapitalize="none" autocorrect="off" [core-auto-focus]="autoFocus">
                 </ion-input>