EVOgeek
/
Vmeda.Online
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MOBILE-3289 h5p: Fix unneeded scroll in H5P in Android

main
Dani Palou 2021-08-27 09:35:26 +02:00
parent 9c3251ec1d
commit 6677e424e1
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/core/features/h5p/assets/moodle/js/embed.js
View File

@ -136,7 +136,7 @@ document.onreadystatechange = function() {
// When resize has been prepared tell parent window to resize. // When resize has been prepared tell parent window to resize.
H5PEmbedCommunicator.on('resizePrepared', function() { H5PEmbedCommunicator.on('resizePrepared', function() {
H5PEmbedCommunicator.send('resize', { H5PEmbedCommunicator.send('resize', {
scrollHeight: iFrame.contentDocument.body.scrollHeight scrollHeight: getIframeBodyHeights(iFrame).scrollHeight
}); });
}); });
@ -154,10 +154,11 @@ document.onreadystatechange = function() {
resizeDelay = setTimeout(function() { resizeDelay = setTimeout(function() {
// Only resize if the iframe can be resized. // Only resize if the iframe can be resized.
if (parentIsFriendly) { if (parentIsFriendly) {
var heights = getIframeBodyHeights(iFrame);
H5PEmbedCommunicator.send('prepareResize', H5PEmbedCommunicator.send('prepareResize',
{ {
scrollHeight: iFrame.contentDocument.body.scrollHeight, scrollHeight: heights.scrollHeight,
clientHeight: iFrame.contentDocument.body.clientHeight clientHeight: heights.clientHeight
} }
); );
} else { } else {
@ -201,3 +202,14 @@ document.onreadystatechange = function() {
// Trigger initial resize for instance. // Trigger initial resize for instance.
H5P.trigger(instance, 'resize'); H5P.trigger(instance, 'resize');
}; };
// Function created for the Moodle app.
// It also takes the current body margin into account because some user agents put some margin to the body of the outer iframe.
function getIframeBodyHeights(iFrame) {
var margin = parseInt(getComputedStyle(document.body)['margin'], 10) || 0;
return {
scrollHeight: iFrame.contentDocument.body.scrollHeight + margin * 2,
clientHeight: iFrame.contentDocument.body.clientHeight + margin * 2,
};
}