From 647fdf8bf3fd998126b4249951646a2caf1d0dc4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= Date: Thu, 5 Sep 2024 17:57:29 +0200 Subject: [PATCH 1/6] MOBILE-4442 messages: Recover animation once a bug has been solved --- src/core/components/message/message.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/core/components/message/message.ts b/src/core/components/message/message.ts index 99b4d9b2e..aeb18b6ae 100644 --- a/src/core/components/message/message.ts +++ b/src/core/components/message/message.ts @@ -46,11 +46,9 @@ export class CoreMessageComponent implements OnInit { protected deleted = false; // Needed to fix animation to void in Behat tests. - // @TODO Recover the animation using native css or wait for Angular 13.1 - // where the bug https://github.com/angular/angular/issues/30693 is solved. - // @HostBinding('@coreSlideInOut') get animation(): string { - // return this.isMine ? '' : 'fromLeft'; - // } + @HostBinding('@coreSlideInOut') get animation(): string { + return this.isMine ? '' : 'fromLeft'; + } @HostBinding('class.is-mine') isMine = false; From 0b4c3dc88e678e3b9387f510798b80837b1bf0e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= Date: Thu, 5 Sep 2024 18:05:23 +0200 Subject: [PATCH 2/6] MOBILE-4442 course: Create a separate component to manage sections --- .../course-format/course-format.html | 67 +++-------------- .../course-format/course-format.scss | 27 ------- .../components/course-format/course-format.ts | 24 ++---- .../course-section/course-section.html | 48 ++++++++++++ .../course-section/course-section.scss | 30 ++++++++ .../course-section/course-section.ts | 74 +++++++++++++++++++ 6 files changed, 169 insertions(+), 101 deletions(-) create mode 100644 src/core/features/course/components/course-section/course-section.html create mode 100644 src/core/features/course/components/course-section/course-section.scss create mode 100644 src/core/features/course/components/course-section/course-section.ts diff --git a/src/core/features/course/components/course-format/course-format.html b/src/core/features/course/components/course-format/course-format.html index 38d99fd84..add8466bd 100644 --- a/src/core/features/course/components/course-format/course-format.html +++ b/src/core/features/course/components/course-format/course-format.html @@ -8,10 +8,12 @@ -
+
- - + + @@ -19,13 +21,16 @@
-
+
@for (section of sections; track section.id) { @if ($index <= lastShownSectionIndex) { - + } } @@ -65,55 +70,3 @@