EVOgeek/Vmeda.Online
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1847 from sammarshallou/MOBILE-2940

Browse Source 
MOBILE-2940 core-icon: label does not work on Ionic icons
This commit is contained in:
Juan Leyva 2019-04-26 13:30:18 +02:00 committed by GitHub
commit 5d28989f91
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/icon/core-icon.html
View File

@ -1 +1 @@
<ion-icon [name]="name" [isActive]="isActive" [md]="md" [ios]="ios" [color]="color"></ion-icon>
<div></div>

12
src/components/icon/icon.ts
View File

@ -13,6 +13,7 @@
// limitations under the License.
import { Component, Input, OnInit, OnDestroy, ElementRef } from '@angular/core';
import { Config } from 'ionic-angular';
/**
* Core Icon is a component that enabled a posibility to add fontawesome icon to the html. It's recommended if both fontawesome
@ -42,7 +43,7 @@ export class CoreIconComponent implements OnInit, OnDestroy {
protected element: HTMLElement;
protected newElement: HTMLElement;
constructor(el: ElementRef) {
constructor(el: ElementRef, private config: Config) {
this.element = el.nativeElement;
}
@ -50,9 +51,11 @@ export class CoreIconComponent implements OnInit, OnDestroy {
* Component being initialized.
*/
ngOnInit(): void {
if (this.name.startsWith('fa-')) {
// Use a new created element to avoid ion-icon working.
// This is necessary to make the FontAwesome stuff work.
// It is also required to stop Ionic overriding the aria-label attribute.
this.newElement = document.createElement('ion-icon');
if (this.name.startsWith('fa-')) {
this.newElement.classList.add('icon');
this.newElement.classList.add('fa');
this.newElement.classList.add(this.name);
@ -63,7 +66,10 @@ export class CoreIconComponent implements OnInit, OnDestroy {
this.newElement.classList.add('fa-' + this.color);
}
} else {
this.newElement = <HTMLElement> this.element.firstElementChild;
const mode = this.config.get('iconMode');
this.newElement.classList.add('icon');
this.newElement.classList.add('icon-' + mode);
this.newElement.classList.add('ion-' + mode + '-' + this.name);
}
!this.ariaLabel && this.newElement.setAttribute('aria-hidden', 'true');