From 5b403129cd498399d33e9d4e23b123fe58dd5e22 Mon Sep 17 00:00:00 2001 From: Albert Gasset Date: Mon, 29 Oct 2018 15:55:33 +0100 Subject: [PATCH] MOBILE-2675 offline: Ignore errors when logging actions --- src/addon/competency/pages/competency/competency.ts | 9 +++++++-- .../pages/competencysummary/competencysummary.ts | 4 +++- src/addon/mod/book/components/index/index.ts | 2 ++ src/addon/mod/chat/components/index/index.ts | 2 ++ src/addon/mod/data/components/index/index.ts | 2 ++ src/addon/mod/feedback/components/index/index.ts | 4 +++- src/addon/mod/feedback/pages/form/form.ts | 2 ++ src/addon/mod/folder/components/index/index.ts | 2 ++ src/addon/mod/glossary/pages/entry/entry.ts | 4 +++- src/addon/mod/imscp/components/index/index.ts | 2 ++ src/addon/mod/page/components/index/index.ts | 2 ++ src/addon/mod/resource/components/index/index.ts | 2 ++ src/addon/mod/resource/providers/helper.ts | 2 ++ src/addon/mod/survey/components/index/index.ts | 2 ++ src/addon/mod/url/components/index/index.ts | 2 ++ src/addon/mod/url/providers/module-handler.ts | 2 ++ src/addon/mod/wiki/components/index/index.ts | 4 +++- src/addon/mod/workshop/pages/submission/submission.ts | 2 ++ src/addon/notes/components/list/list.ts | 8 ++++++-- src/core/grades/components/course/course.ts | 4 +++- src/core/grades/pages/courses/courses.ts | 4 +++- 21 files changed, 57 insertions(+), 10 deletions(-) diff --git a/src/addon/competency/pages/competency/competency.ts b/src/addon/competency/pages/competency/competency.ts index 0443a66d8..3a20061c3 100644 --- a/src/addon/competency/pages/competency/competency.ts +++ b/src/addon/competency/pages/competency/competency.ts @@ -54,9 +54,14 @@ export class AddonCompetencyCompetencyPage { ionViewDidLoad(): void { this.fetchCompetency().then(() => { if (this.planId) { - this.competencyProvider.logCompetencyInPlanView(this.planId, this.competencyId, this.planStatus, this.userId); + this.competencyProvider.logCompetencyInPlanView(this.planId, this.competencyId, this.planStatus, this.userId) + .catch(() => { + // Ignore errors. + }); } else { - this.competencyProvider.logCompetencyInCourseView(this.courseId, this.competencyId, this.userId); + this.competencyProvider.logCompetencyInCourseView(this.courseId, this.competencyId, this.userId).catch(() => { + // Ignore errors. + }); } }).finally(() => { this.competencyLoaded = true; diff --git a/src/addon/competency/pages/competencysummary/competencysummary.ts b/src/addon/competency/pages/competencysummary/competencysummary.ts index 8464d4312..3045f44f3 100644 --- a/src/addon/competency/pages/competencysummary/competencysummary.ts +++ b/src/addon/competency/pages/competencysummary/competencysummary.ts @@ -41,7 +41,9 @@ export class AddonCompetencyCompetencySummaryPage { */ ionViewDidLoad(): void { this.fetchCompetency().then(() => { - this.competencyProvider.logCompetencyView(this.competencyId); + this.competencyProvider.logCompetencyView(this.competencyId).catch(() => { + // Ignore errors. + }); }).finally(() => { this.competencyLoaded = true; }); diff --git a/src/addon/mod/book/components/index/index.ts b/src/addon/mod/book/components/index/index.ts index 4db347675..9e8a29ebc 100644 --- a/src/addon/mod/book/components/index/index.ts +++ b/src/addon/mod/book/components/index/index.ts @@ -168,6 +168,8 @@ export class AddonModBookIndexComponent extends CoreCourseModuleMainResourceComp if (!this.nextChapter) { this.courseProvider.checkModuleCompletion(this.courseId, this.module.completionstatus); } + }).catch(() => { + // Ignore errors. }); }).catch((error) => { this.domUtils.showErrorModalDefault(error, 'addon.mod_book.errorchapter', true); diff --git a/src/addon/mod/chat/components/index/index.ts b/src/addon/mod/chat/components/index/index.ts index 881411996..12f773827 100644 --- a/src/addon/mod/chat/components/index/index.ts +++ b/src/addon/mod/chat/components/index/index.ts @@ -49,6 +49,8 @@ export class AddonModChatIndexComponent extends CoreCourseModuleMainActivityComp this.loadContent().then(() => { this.chatProvider.logView(this.chat.id).then(() => { this.courseProvider.checkModuleCompletion(this.courseId, this.module.completionstatus); + }).catch(() => { + // Ignore errors. }); }); } diff --git a/src/addon/mod/data/components/index/index.ts b/src/addon/mod/data/components/index/index.ts index d259527a6..5f7a9a957 100644 --- a/src/addon/mod/data/components/index/index.ts +++ b/src/addon/mod/data/components/index/index.ts @@ -105,6 +105,8 @@ export class AddonModDataIndexComponent extends CoreCourseModuleMainActivityComp this.dataProvider.logView(this.data.id).then(() => { this.courseProvider.checkModuleCompletion(this.courseId, this.module.completionstatus); + }).catch(() => { + // Ignore errors. }); }); diff --git a/src/addon/mod/feedback/components/index/index.ts b/src/addon/mod/feedback/components/index/index.ts index 16ad4b2f1..b24f1e5bb 100644 --- a/src/addon/mod/feedback/components/index/index.ts +++ b/src/addon/mod/feedback/components/index/index.ts @@ -97,7 +97,9 @@ export class AddonModFeedbackIndexComponent extends CoreCourseModuleMainActivity super.ngOnInit(); this.loadContent(false, true).then(() => { - this.feedbackProvider.logView(this.feedback.id); + this.feedbackProvider.logView(this.feedback.id).catch(() => { + // Ignore errors. + }); }).finally(() => { this.tabsReady = true; }); diff --git a/src/addon/mod/feedback/pages/form/form.ts b/src/addon/mod/feedback/pages/form/form.ts index c4329475b..c468f03bc 100644 --- a/src/addon/mod/feedback/pages/form/form.ts +++ b/src/addon/mod/feedback/pages/form/form.ts @@ -96,6 +96,8 @@ export class AddonModFeedbackFormPage implements OnDestroy { this.fetchData().then(() => { this.feedbackProvider.logView(this.feedback.id, true).then(() => { this.courseProvider.checkModuleCompletion(this.courseId, this.module.completionstatus); + }).catch(() => { + // Ignore errors. }); }); } diff --git a/src/addon/mod/folder/components/index/index.ts b/src/addon/mod/folder/components/index/index.ts index 290867043..f977be7e3 100644 --- a/src/addon/mod/folder/components/index/index.ts +++ b/src/addon/mod/folder/components/index/index.ts @@ -57,6 +57,8 @@ export class AddonModFolderIndexComponent extends CoreCourseModuleMainResourceCo this.loadContent().then(() => { this.folderProvider.logView(this.module.instance).then(() => { this.courseProvider.checkModuleCompletion(this.courseId, this.module.completionstatus); + }).catch(() => { + // Ignore errors. }); }).finally(() => { this.loaded = true; diff --git a/src/addon/mod/glossary/pages/entry/entry.ts b/src/addon/mod/glossary/pages/entry/entry.ts index f6aa7df41..0e2451be6 100644 --- a/src/addon/mod/glossary/pages/entry/entry.ts +++ b/src/addon/mod/glossary/pages/entry/entry.ts @@ -48,7 +48,9 @@ export class AddonModGlossaryEntryPage { */ ionViewDidLoad(): void { this.fetchEntry().then(() => { - this.glossaryProvider.logEntryView(this.entry.id); + this.glossaryProvider.logEntryView(this.entry.id).catch(() => { + // Ignore errors. + }); }).finally(() => { this.loaded = true; }); diff --git a/src/addon/mod/imscp/components/index/index.ts b/src/addon/mod/imscp/components/index/index.ts index 8572ea5cc..7e27a7910 100644 --- a/src/addon/mod/imscp/components/index/index.ts +++ b/src/addon/mod/imscp/components/index/index.ts @@ -54,6 +54,8 @@ export class AddonModImscpIndexComponent extends CoreCourseModuleMainResourceCom this.loadContent().then(() => { this.imscpProvider.logView(this.module.instance).then(() => { this.courseProvider.checkModuleCompletion(this.courseId, this.module.completionstatus); + }).catch(() => { + // Ignore errors. }); }); } diff --git a/src/addon/mod/page/components/index/index.ts b/src/addon/mod/page/components/index/index.ts index ed70412fb..cb008550b 100644 --- a/src/addon/mod/page/components/index/index.ts +++ b/src/addon/mod/page/components/index/index.ts @@ -55,6 +55,8 @@ export class AddonModPageIndexComponent extends CoreCourseModuleMainResourceComp this.loadContent().then(() => { this.pageProvider.logView(this.module.instance).then(() => { this.courseProvider.checkModuleCompletion(this.courseId, this.module.completionstatus); + }).catch(() => { + // Ignore errors. }); }); } diff --git a/src/addon/mod/resource/components/index/index.ts b/src/addon/mod/resource/components/index/index.ts index 9bdb7243b..ee49883b0 100644 --- a/src/addon/mod/resource/components/index/index.ts +++ b/src/addon/mod/resource/components/index/index.ts @@ -52,6 +52,8 @@ export class AddonModResourceIndexComponent extends CoreCourseModuleMainResource this.loadContent().then(() => { this.resourceProvider.logView(this.module.instance).then(() => { this.courseProvider.checkModuleCompletion(this.courseId, this.module.completionstatus); + }).catch(() => { + // Ignore errors. }); }); } diff --git a/src/addon/mod/resource/providers/helper.ts b/src/addon/mod/resource/providers/helper.ts index d51eba5a2..eec56772b 100644 --- a/src/addon/mod/resource/providers/helper.ts +++ b/src/addon/mod/resource/providers/helper.ts @@ -154,6 +154,8 @@ export class AddonModResourceHelperProvider { module.contents).then(() => { this.resourceProvider.logView(module.instance).then(() => { this.courseProvider.checkModuleCompletion(courseId, module.completionstatus); + }).catch(() => { + // Ignore errors. }); }).catch((error) => { this.domUtils.showErrorModalDefault(error, 'addon.mod_resource.errorwhileloadingthecontent', true); diff --git a/src/addon/mod/survey/components/index/index.ts b/src/addon/mod/survey/components/index/index.ts index bddf70a1b..7db99f743 100644 --- a/src/addon/mod/survey/components/index/index.ts +++ b/src/addon/mod/survey/components/index/index.ts @@ -55,6 +55,8 @@ export class AddonModSurveyIndexComponent extends CoreCourseModuleMainActivityCo this.loadContent(false, true).then(() => { this.surveyProvider.logView(this.survey.id).then(() => { this.courseProvider.checkModuleCompletion(this.courseId, this.module.completionstatus); + }).catch(() => { + // Ignore errors. }); }); } diff --git a/src/addon/mod/url/components/index/index.ts b/src/addon/mod/url/components/index/index.ts index 589de7cbf..3bbdfad79 100644 --- a/src/addon/mod/url/components/index/index.ts +++ b/src/addon/mod/url/components/index/index.ts @@ -173,6 +173,8 @@ export class AddonModUrlIndexComponent extends CoreCourseModuleMainResourceCompo go(): void { this.urlProvider.logView(this.module.instance).then(() => { this.courseProvider.checkModuleCompletion(this.courseId, this.module.completionstatus); + }).catch(() => { + // Ignore errors. }); this.urlHelper.open(this.url); } diff --git a/src/addon/mod/url/providers/module-handler.ts b/src/addon/mod/url/providers/module-handler.ts index 7043c23e1..874eb09ca 100644 --- a/src/addon/mod/url/providers/module-handler.ts +++ b/src/addon/mod/url/providers/module-handler.ts @@ -164,6 +164,8 @@ export class AddonModUrlModuleHandler implements CoreCourseModuleHandler { protected openUrl(module: any, courseId: number): void { this.urlProvider.logView(module.instance).then(() => { this.courseProvider.checkModuleCompletion(courseId, module.completionstatus); + }).catch(() => { + // Ignore errors. }); this.urlHelper.open(module.contents[0].fileurl); } diff --git a/src/addon/mod/wiki/components/index/index.ts b/src/addon/mod/wiki/components/index/index.ts index bca61171c..545c1e1c7 100644 --- a/src/addon/mod/wiki/components/index/index.ts +++ b/src/addon/mod/wiki/components/index/index.ts @@ -341,7 +341,9 @@ export class AddonModWikiIndexComponent extends CoreCourseModuleMainActivityComp this.currentPage = data.pageId; this.showLoadingAndFetch(true, false).then(() => { - this.wikiProvider.logPageView(this.currentPage); + this.wikiProvider.logPageView(this.currentPage).catch(() => { + // Ignore errors. + }); }); // Stop listening for new page events. diff --git a/src/addon/mod/workshop/pages/submission/submission.ts b/src/addon/mod/workshop/pages/submission/submission.ts index c9242e761..b12dff3b5 100644 --- a/src/addon/mod/workshop/pages/submission/submission.ts +++ b/src/addon/mod/workshop/pages/submission/submission.ts @@ -132,6 +132,8 @@ export class AddonModWorkshopSubmissionPage implements OnInit, OnDestroy { this.fetchSubmissionData().then(() => { this.workshopProvider.logViewSubmission(this.submissionId).then(() => { this.courseProvider.checkModuleCompletion(this.courseId, this.module.completionstatus); + }).catch(() => { + // Ignore errors. }); }); } diff --git a/src/addon/notes/components/list/list.ts b/src/addon/notes/components/list/list.ts index 942670e11..b51247b3d 100644 --- a/src/addon/notes/components/list/list.ts +++ b/src/addon/notes/components/list/list.ts @@ -67,7 +67,9 @@ export class AddonNotesListComponent implements OnInit, OnDestroy { */ ngOnInit(): void { this.fetchNotes(true).then(() => { - this.notesProvider.logView(this.courseId); + this.notesProvider.logView(this.courseId).catch(() => { + // Ignore errors. + }); }); } @@ -128,7 +130,9 @@ export class AddonNotesListComponent implements OnInit, OnDestroy { this.refreshIcon = 'spinner'; this.syncIcon = 'spinner'; this.fetchNotes(true).then(() => { - this.notesProvider.logView(this.courseId); + this.notesProvider.logView(this.courseId).catch(() => { + // Ignore errors. + }); }); } diff --git a/src/core/grades/components/course/course.ts b/src/core/grades/components/course/course.ts index 757a4c3a0..8d66dd320 100644 --- a/src/core/grades/components/course/course.ts +++ b/src/core/grades/components/course/course.ts @@ -53,7 +53,9 @@ export class CoreGradesCourseComponent { } // Add log in Moodle. - return this.gradesProvider.logCourseGradesView(this.courseId, this.userId); + return this.gradesProvider.logCourseGradesView(this.courseId, this.userId).catch(() => { + // Ignore errors. + }); }).finally(() => { this.gradesLoaded = true; }); diff --git a/src/core/grades/pages/courses/courses.ts b/src/core/grades/pages/courses/courses.ts index 14a7e83dd..62a67829a 100644 --- a/src/core/grades/pages/courses/courses.ts +++ b/src/core/grades/pages/courses/courses.ts @@ -55,7 +55,9 @@ export class CoreGradesCoursesPage { } // Add log in Moodle. - return this.gradesProvider.logCoursesGradesView(); + return this.gradesProvider.logCoursesGradesView().catch(() => { + // Ignore errors. + }); }).finally(() => { this.gradesLoaded = true; });