EVOgeek
/
Vmeda.Online
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3940 from NoelDeMartin/MOBILE-4350 

MOBILE-4350: Fix sequential navigation summary
main
Dani Palou 2024-02-22 15:03:47 +01:00 committed by GitHub
parent 9a8c80d6d1 df5bbf33bc
commit 55b1b527c0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/addons/mod/quiz/pages/player/player.html
View File

@ -104,7 +104,7 @@
<!-- List of questions of the summary table. --> <!-- List of questions of the summary table. -->
<ng-container *ngFor="let question of summaryQuestions"> <ng-container *ngFor="let question of summaryQuestions">
<ion-item *ngIf="question.type !== 'description' && question.questionnumber" <ion-item *ngIf="question.type !== 'description' && question.questionnumber"
(click)="changePage(question.page, false, question.slot)" (click)="!isSequential && canReturn && changePage(question.page, false, question.slot)"
[attr.aria-label]="'core.question.questionno' | translate:{$a: question.questionnumber}" [attr.aria-label]="'core.question.questionno' | translate:{$a: question.questionnumber}"
[detail]="!isSequential && canReturn" [button]="!isSequential && canReturn"> [detail]="!isSequential && canReturn" [button]="!isSequential && canReturn">
<ion-label> <ion-label>

2
src/addons/mod/quiz/pages/player/player.ts
View File

@ -412,7 +412,7 @@ export class AddonModQuizPlayerPage implements OnInit, OnDestroy, CanLeave {
.filter(question => AddonModQuiz.isQuestionUnanswered(question)) .filter(question => AddonModQuiz.isQuestionUnanswered(question))
.length; .length;
if (unansweredCount > 0) { if (!this.isSequential && unansweredCount > 0) {
const warning = Translate.instant( const warning = Translate.instant(
'addon.mod_quiz.submission_confirmation_unanswered', 'addon.mod_quiz.submission_confirmation_unanswered',
{ $a: unansweredCount }, { $a: unansweredCount },

8
src/addons/mod/quiz/tests/behat/quiz_navigation.feature
View File

@ -132,8 +132,14 @@ Feature: Navigate through a quiz in the app
And I should find "Not yet answered" within "2" "ion-item" in the app And I should find "Not yet answered" within "2" "ion-item" in the app
And I should find "Not yet answered" within "3" "ion-item" in the app And I should find "Not yet answered" within "3" "ion-item" in the app
When I press "Not yet answered" within "3" "ion-item" in the app
Then I should not find "Text of the third question" in the app
When I press "Submit all and finish" in the app When I press "Submit all and finish" in the app
And I press "Submit" near "Once you submit" in the app Then I should find "Once you submit" in the app
But I should not find "Questions without a response" in the app
When I press "Submit" near "Once you submit" in the app
Then I should find "Review" in the app Then I should find "Review" in the app
And I should find "Text of the first question" in the app And I should find "Text of the first question" in the app
And I should find "Text of the second question" in the app And I should find "Text of the second question" in the app