From 5396bb6a7191d2f432fdbdf0ea7dd14c996ca769 Mon Sep 17 00:00:00 2001 From: Noel De Martin Date: Wed, 8 Sep 2021 17:43:59 +0200 Subject: [PATCH] MOBILE-3833 a11y: Add missing lists This is still not completely accessible, but it is a good idea to use lists properly in case https://github.com/ionic-team/ionic-framework/issues/19939 gets solved --- .../features/settings/pages/about/about.html | 60 +++-- .../settings/pages/deviceinfo/deviceinfo.html | 250 +++++++++--------- .../settings/pages/general/general.html | 140 +++++----- .../settings/pages/licenses/licenses.html | 51 ++-- .../pages/space-usage/space-usage.html | 50 ++-- .../synchronization/synchronization.html | 62 ++--- 6 files changed, 312 insertions(+), 301 deletions(-) diff --git a/src/core/features/settings/pages/about/about.html b/src/core/features/settings/pages/about/about.html index 6b931e527..807d240ce 100644 --- a/src/core/features/settings/pages/about/about.html +++ b/src/core/features/settings/pages/about/about.html @@ -10,33 +10,35 @@ - -

{{ appName }} {{ versionName }}

-
- - - {{ 'core.settings.deviceinfo' | translate }} - - - - {{ 'core.settings.opensourcelicenses' | translate }} - - - - {{ 'core.settings.privacypolicy' | translate }} - - - - {{ 'core.settings.helpusimprove' | translate }} - + + +

{{ appName }} {{ versionName }}

+
+ + + {{ 'core.settings.deviceinfo' | translate }} + + + + {{ 'core.settings.opensourcelicenses' | translate }} + + + + {{ 'core.settings.privacypolicy' | translate }} + + + + {{ 'core.settings.helpusimprove' | translate }} + +
diff --git a/src/core/features/settings/pages/deviceinfo/deviceinfo.html b/src/core/features/settings/pages/deviceinfo/deviceinfo.html index 3e3054d5f..3495b7591 100644 --- a/src/core/features/settings/pages/deviceinfo/deviceinfo.html +++ b/src/core/features/settings/pages/deviceinfo/deviceinfo.html @@ -15,128 +15,130 @@ - - -

{{ 'core.settings.appversion' | translate}}

-

{{ deviceInfo.versionName }} ({{ deviceInfo.versionCode }})

-
-
- - -

{{ 'core.settings.compilationinfo' | translate }}

-

{{ deviceInfo.compilationTime | coreFormatDate: "LLL Z": false }}

-

{{ deviceInfo.lastCommit }}

-
-
- - -

{{ 'core.settings.siteinfo' | translate }} *

-

{{ deviceInfo.siteUrl }}

-

{{ deviceInfo.siteVersion }}

-

{{ deviceInfo.siteId }}

-
-
- - -

{{ 'core.settings.filesystemroot' | translate }}

-

{{ deviceInfo.fileSystemRoot }}

-

{{ deviceInfo.fileSystemRoot }}

-
-
- - -

{{ 'core.settings.navigatoruseragent' | translate }}

-

{{ deviceInfo.userAgent }}

-
-
- - -

{{ 'core.settings.navigatorlanguage' | translate }}

-

{{ deviceInfo.browserLanguage }}

-
-
- - -

{{ 'core.settings.currentlanguage' | translate }}

-

{{ currentLangName }} ({{ deviceInfo.currentLanguage }})

-
-
- - -

{{ 'core.settings.locationhref' | translate }}

-

{{ deviceInfo.locationHref }}

-
-
- - -

{{ 'core.settings.displayformat' | translate }}

-

{{ 'core.' + deviceInfo.deviceType | translate }}

-
-
- - -

{{ 'core.settings.deviceos' | translate}}

-

{{ deviceOsTranslated }}

-
-
- - -

{{ 'core.settings.screen' | translate }}

-

{{ deviceInfo.screen }}

-
-
- - -

{{ 'core.settings.networkstatus' | translate}}

-

{{ 'core.' + deviceInfo.networkStatus | translate }}

-
-
- - -

{{ 'core.settings.wificonnection' | translate}}

-

{{ 'core.' + deviceInfo.wifiConnection | translate }}

-
-
- - -

{{ 'core.settings.cordovaversion' | translate }}

-

{{ deviceInfo.cordovaVersion }}

-
-
- - -

{{ 'core.settings.cordovadeviceplatform' | translate }}

-

{{ deviceInfo.platform }}

-
-
- - -

{{ 'core.settings.cordovadeviceosversion' | translate }}

-

{{ deviceInfo.osVersion }}

-
-
- - -

{{ 'core.settings.cordovadevicemodel' | translate}}

-

{{ deviceInfo.model }}

-
-
- - -

{{ 'core.settings.cordovadeviceuuid' | translate}}

-

{{ deviceInfo.uuid }}

-
-
- - -

{{ 'core.settings.pushid' | translate }}

-

{{ deviceInfo.pushId }}

-
-
- - -

{{ 'core.settings.localnotifavailable' | translate }}

-

{{ 'core.' + deviceInfo.localNotifAvailable | translate }}

-
-
+ + + +

{{ 'core.settings.appversion' | translate}}

+

{{ deviceInfo.versionName }} ({{ deviceInfo.versionCode }})

+
+
+ + +

{{ 'core.settings.compilationinfo' | translate }}

+

{{ deviceInfo.compilationTime | coreFormatDate: "LLL Z": false }}

+

{{ deviceInfo.lastCommit }}

+
+
+ + +

{{ 'core.settings.siteinfo' | translate }} *

+

{{ deviceInfo.siteUrl }}

+

{{ deviceInfo.siteVersion }}

+

{{ deviceInfo.siteId }}

+
+
+ + +

{{ 'core.settings.filesystemroot' | translate }}

+

{{ deviceInfo.fileSystemRoot }}

+

{{ deviceInfo.fileSystemRoot }}

+
+
+ + +

{{ 'core.settings.navigatoruseragent' | translate }}

+

{{ deviceInfo.userAgent }}

+
+
+ + +

{{ 'core.settings.navigatorlanguage' | translate }}

+

{{ deviceInfo.browserLanguage }}

+
+
+ + +

{{ 'core.settings.currentlanguage' | translate }}

+

{{ currentLangName }} ({{ deviceInfo.currentLanguage }})

+
+
+ + +

{{ 'core.settings.locationhref' | translate }}

+

{{ deviceInfo.locationHref }}

+
+
+ + +

{{ 'core.settings.displayformat' | translate }}

+

{{ 'core.' + deviceInfo.deviceType | translate }}

+
+
+ + +

{{ 'core.settings.deviceos' | translate}}

+

{{ deviceOsTranslated }}

+
+
+ + +

{{ 'core.settings.screen' | translate }}

+

{{ deviceInfo.screen }}

+
+
+ + +

{{ 'core.settings.networkstatus' | translate}}

+

{{ 'core.' + deviceInfo.networkStatus | translate }}

+
+
+ + +

{{ 'core.settings.wificonnection' | translate}}

+

{{ 'core.' + deviceInfo.wifiConnection | translate }}

+
+
+ + +

{{ 'core.settings.cordovaversion' | translate }}

+

{{ deviceInfo.cordovaVersion }}

+
+
+ + +

{{ 'core.settings.cordovadeviceplatform' | translate }}

+

{{ deviceInfo.platform }}

+
+
+ + +

{{ 'core.settings.cordovadeviceosversion' | translate }}

+

{{ deviceInfo.osVersion }}

+
+
+ + +

{{ 'core.settings.cordovadevicemodel' | translate}}

+

{{ deviceInfo.model }}

+
+
+ + +

{{ 'core.settings.cordovadeviceuuid' | translate}}

+

{{ deviceInfo.uuid }}

+
+
+ + +

{{ 'core.settings.pushid' | translate }}

+

{{ deviceInfo.pushId }}

+
+
+ + +

{{ 'core.settings.localnotifavailable' | translate }}

+

{{ 'core.' + deviceInfo.localNotifAvailable | translate }}

+
+
+
diff --git a/src/core/features/settings/pages/general/general.html b/src/core/features/settings/pages/general/general.html index faaded554..a859ca45f 100644 --- a/src/core/features/settings/pages/general/general.html +++ b/src/core/features/settings/pages/general/general.html @@ -8,73 +8,75 @@ - - -

{{ 'core.settings.language' | translate }}

-
- - {{ entry.name }} - -
- - -

{{ 'core.settings.fontsize' | translate }}

-
- - - - {{ 'core.settings.fontsizecharacter' | translate }} - - - - - -
- - -

{{ 'core.settings.colorscheme' | translate }}

-

{{ 'core.settings.forcedsetting' | translate }}

-
- - - {{ 'core.settings.colorscheme-' + scheme | translate }} - -
- -

{{ 'core.settings.colorscheme-system-notice' | translate }}

-
- - -

{{ 'core.settings.enablerichtexteditor' | translate }}

-

{{ 'core.settings.enablerichtexteditordescription' | translate }}

-
- -
- - -

{{ 'core.settings.ioscookies' | translate }}

-

{{ 'core.settings.ioscookiesdescription' | translate }}

- - {{ 'core.opensettings' | translate }} - -
-
- - -

{{ 'core.settings.debugdisplay' | translate }}

-

{{ 'core.settings.debugdisplaydescription' | translate }}

-
- -
- - -

{{ 'core.settings.enablefirebaseanalytics' | translate }}

-

{{ 'core.settings.enablefirebaseanalyticsdescription' | translate }}

-
- -
+ + + +

{{ 'core.settings.language' | translate }}

+
+ + {{ entry.name }} + +
+ + +

{{ 'core.settings.fontsize' | translate }}

+
+ + + + {{ 'core.settings.fontsizecharacter' | translate }} + + + + + +
+ + +

{{ 'core.settings.colorscheme' | translate }}

+

{{ 'core.settings.forcedsetting' | translate }}

+
+ + + {{ 'core.settings.colorscheme-' + scheme | translate }} + +
+ +

{{ 'core.settings.colorscheme-system-notice' | translate }}

+
+ + +

{{ 'core.settings.enablerichtexteditor' | translate }}

+

{{ 'core.settings.enablerichtexteditordescription' | translate }}

+
+ +
+ + +

{{ 'core.settings.ioscookies' | translate }}

+

{{ 'core.settings.ioscookiesdescription' | translate }}

+ + {{ 'core.opensettings' | translate }} + +
+
+ + +

{{ 'core.settings.debugdisplay' | translate }}

+

{{ 'core.settings.debugdisplaydescription' | translate }}

+
+ +
+ + +

{{ 'core.settings.enablefirebaseanalytics' | translate }}

+

{{ 'core.settings.enablefirebaseanalyticsdescription' | translate }}

+
+ +
+
diff --git a/src/core/features/settings/pages/licenses/licenses.html b/src/core/features/settings/pages/licenses/licenses.html index c6d1949a8..174475380 100644 --- a/src/core/features/settings/pages/licenses/licenses.html +++ b/src/core/features/settings/pages/licenses/licenses.html @@ -9,33 +9,34 @@ - - - {{ 'core.settings.opensourcelicenses' | translate }} - - - {{ 'core.view' | translate }} - - - - + + -

- {{ license.name }} - {{ license.name }} - {{ license.version }} -

-

- {{ 'core.settings.publisher' | translate }}{{ 'core.labelsep' | translate }} {{ license.publisher }} -

-

{{ 'core.settings.license' | translate }}{{ 'core.labelsep' | translate }} {{ license.licenses }}

-

{{ license.url }}

-

{{ license.email }}

+ {{ 'core.settings.opensourcelicenses' | translate }}
- {{ 'core.view' | translate }} + + {{ 'core.view' | translate }}
-
+ + + +

+ {{ license.name }} + {{ license.name }} - {{ license.version }} +

+

+ {{ 'core.settings.publisher' | translate }}{{ 'core.labelsep' | translate }} {{ license.publisher }} +

+

{{ 'core.settings.license' | translate }}{{ 'core.labelsep' | translate }} {{ license.licenses }}

+

{{ license.url }}

+

{{ license.email }}

+
+ {{ 'core.view' | translate }} +
+
+
diff --git a/src/core/features/settings/pages/space-usage/space-usage.html b/src/core/features/settings/pages/space-usage/space-usage.html index 54e988183..865cc082e 100644 --- a/src/core/features/settings/pages/space-usage/space-usage.html +++ b/src/core/features/settings/pages/space-usage/space-usage.html @@ -18,30 +18,32 @@ - - -

- + + + +

+ +

+

{{ site.fullName }}

+

{{ site.siteUrl }}

+
+

+ {{ site.spaceUsage | coreBytesToSize }}

-

{{ site.fullName }}

-

{{ site.siteUrl }}

- -

- {{ site.spaceUsage | coreBytesToSize }} -

- - - -
- - -

{{ 'core.settings.total' | translate }}

-
-

- {{ totals.spaceUsage | coreBytesToSize }} -

-
+ + + + + + +

{{ 'core.settings.total' | translate }}

+
+

+ {{ totals.spaceUsage | coreBytesToSize }} +

+
+
diff --git a/src/core/features/settings/pages/synchronization/synchronization.html b/src/core/features/settings/pages/synchronization/synchronization.html index a7bc6f784..1808a9cc7 100644 --- a/src/core/features/settings/pages/synchronization/synchronization.html +++ b/src/core/features/settings/pages/synchronization/synchronization.html @@ -15,35 +15,37 @@ - - -

{{ 'core.settings.syncsettings' | translate }}

-
-
- - {{ 'core.settings.enablesyncwifi' | translate }} - - - - - -

{{ 'core.settings.sites' | translate }}

-
-
- - -

- -

-

{{ site.fullName }}

-

{{ site.siteUrl }}

-
- - - - - -
+ + + +

{{ 'core.settings.syncsettings' | translate }}

+
+
+ + {{ 'core.settings.enablesyncwifi' | translate }} + + + + + +

{{ 'core.settings.sites' | translate }}

+
+
+ + +

+ +

+

{{ site.fullName }}

+

{{ site.siteUrl }}

+
+ + + + + +
+