From 496a0a42a6ed4a3f3ae841d526c15ab38366de18 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= <crazyserver@gmail.com>
Date: Thu, 30 Jan 2020 09:48:43 +0100
Subject: [PATCH] MOBILE-3325 other: Change navPush string usage

---
 .../components/activitymodules/addon-block-activitymodules.html | 2 +-
 src/addon/files/pages/list/list.html                            | 2 +-
 .../mod/folder/components/index/addon-mod-folder-index.html     | 2 +-
 .../mod/lesson/components/index/addon-mod-lesson-index.html     | 2 +-
 src/addon/mod/quiz/components/index/addon-mod-quiz-index.html   | 2 +-
 src/addon/mod/quiz/pages/attempt/attempt.html                   | 2 +-
 src/core/login/pages/credentials/credentials.html               | 2 +-
 src/core/login/pages/site/site.html                             | 2 +-
 src/core/login/pages/sites/sites.html                           | 2 +-
 .../all-course-list/core-sitehome-all-course-list.html          | 2 +-
 .../components/categories/core-sitehome-categories.html         | 2 +-
 .../components/course-search/core-sitehome-course-search.html   | 2 +-
 .../core-sitehome-enrolled-course-list.html                     | 2 +-
 13 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/addon/block/activitymodules/components/activitymodules/addon-block-activitymodules.html b/src/addon/block/activitymodules/components/activitymodules/addon-block-activitymodules.html
index 342e38924..fc407eb4b 100644
--- a/src/addon/block/activitymodules/components/activitymodules/addon-block-activitymodules.html
+++ b/src/addon/block/activitymodules/components/activitymodules/addon-block-activitymodules.html
@@ -2,7 +2,7 @@
     <h2>{{ 'addon.block_activitymodules.pluginname' | translate }}</h2>
 </ion-item-divider>
 <core-loading [hideUntil]="loaded" class="core-loading-center">
-    <a ion-item text-wrap *ngFor="let entry of entries" class="item-media" detail-none [navPush]="'CoreCourseListModTypePage'" [navParams]="{title: entry.name, courseId: instanceId, modName: entry.modName}">
+    <a ion-item text-wrap *ngFor="let entry of entries" class="item-media" detail-none navPush="CoreCourseListModTypePage" [navParams]="{title: entry.name, courseId: instanceId, modName: entry.modName}">
         <img item-start [src]="entry.icon" alt="" role="presentation" class="core-module-icon">
         {{ entry.name }}
     </a>
diff --git a/src/addon/files/pages/list/list.html b/src/addon/files/pages/list/list.html
index b119855ca..3b9207168 100644
--- a/src/addon/files/pages/list/list.html
+++ b/src/addon/files/pages/list/list.html
@@ -23,7 +23,7 @@
         <!-- List of files. -->
         <ion-list *ngIf="files && files.length > 0">
             <ng-container *ngFor="let file of files">
-                <a *ngIf="file.isdir" ion-item class="item-media" [navPush]="'AddonFilesListPage'" [navParams]="{path: file.link, title: file.filename}">
+                <a *ngIf="file.isdir" ion-item class="item-media" navPush="AddonFilesListPage" [navParams]="{path: file.link, title: file.filename}">
                     <img [src]="file.imgPath" alt="" role="presentation" item-start>
                     <p>{{file.filename}}</p>
                 </a>
diff --git a/src/addon/mod/folder/components/index/addon-mod-folder-index.html b/src/addon/mod/folder/components/index/addon-mod-folder-index.html
index eb68f6b4c..3f91c8cfc 100644
--- a/src/addon/mod/folder/components/index/addon-mod-folder-index.html
+++ b/src/addon/mod/folder/components/index/addon-mod-folder-index.html
@@ -17,7 +17,7 @@
 
     <ion-list *ngIf="contents && contents.length > 0">
         <ng-container *ngFor="let file of contents">
-            <a *ngIf="file.type === 'folder'" ion-item class="item-media" [navPush]="'AddonModFolderIndexPage'" [navParams]="{path: file.filepath, courseId: courseId, module: file}">
+            <a *ngIf="file.type === 'folder'" ion-item class="item-media" navPush="AddonModFolderIndexPage" [navParams]="{path: file.filepath, courseId: courseId, module: file}">
                 <ion-icon name="folder" item-start></ion-icon>
                 <h2>{{file.name}}</h2>
             </a>
diff --git a/src/addon/mod/lesson/components/index/addon-mod-lesson-index.html b/src/addon/mod/lesson/components/index/addon-mod-lesson-index.html
index 2bf84b83a..440d7f383 100644
--- a/src/addon/mod/lesson/components/index/addon-mod-lesson-index.html
+++ b/src/addon/mod/lesson/components/index/addon-mod-lesson-index.html
@@ -244,7 +244,7 @@
                             {{ 'addon.mod_lesson.overview' | translate }}
                         </ion-card-header>
 
-                        <a ion-item text-wrap *ngFor="let student of overview.students" [navPush]="'AddonModLessonUserRetakePage'" [navParams]="{courseId: courseId, lessonId: lesson.id, userId: student.id}">
+                        <a ion-item text-wrap *ngFor="let student of overview.students" navPush="AddonModLessonUserRetakePage" [navParams]="{courseId: courseId, lessonId: lesson.id, userId: student.id}">
                             <ion-avatar core-user-avatar [user]="student" item-start [userId]="student.id" [courseId]="courseId"></ion-avatar>
                             <h2>{{ student.fullname }}</h2>
                             <core-progress-bar [progress]="student.bestgrade"></core-progress-bar>
diff --git a/src/addon/mod/quiz/components/index/addon-mod-quiz-index.html b/src/addon/mod/quiz/components/index/addon-mod-quiz-index.html
index a522eae7b..88de59576 100644
--- a/src/addon/mod/quiz/components/index/addon-mod-quiz-index.html
+++ b/src/addon/mod/quiz/components/index/addon-mod-quiz-index.html
@@ -52,7 +52,7 @@
                 </ion-row>
             </ion-item>
             <!-- List of attempts. -->
-            <a ion-item text-wrap *ngFor="let attempt of attempts" [ngClass]='{"addon-mod_quiz-highlighted core-white-push-arrow": attempt.highlightGrade}' [navPush]="'AddonModQuizAttemptPage'" [navParams]="{courseId: courseId, quizId: quiz.id, attemptId: attempt.id}" [attr.aria-label]="'core.seemoredetail' | translate">
+            <a ion-item text-wrap *ngFor="let attempt of attempts" [ngClass]='{"addon-mod_quiz-highlighted core-white-push-arrow": attempt.highlightGrade}' navPush="AddonModQuizAttemptPage" [navParams]="{courseId: courseId, quizId: quiz.id, attemptId: attempt.id}" [attr.aria-label]="'core.seemoredetail' | translate">
                 <ion-row align-items-center>
                     <ion-col text-center *ngIf="quiz.showAttemptColumn && attempt.preview">{{ 'addon.mod_quiz.preview' | translate }}</ion-col>
                     <ion-col text-center *ngIf="quiz.showAttemptColumn && !attempt.preview">{{ attempt.attempt }}</ion-col>
diff --git a/src/addon/mod/quiz/pages/attempt/attempt.html b/src/addon/mod/quiz/pages/attempt/attempt.html
index 2998605d7..791991ada 100644
--- a/src/addon/mod/quiz/pages/attempt/attempt.html
+++ b/src/addon/mod/quiz/pages/attempt/attempt.html
@@ -31,7 +31,7 @@
                 <p><core-format-text [component]="component" [componentId]="componentId" [text]="attempt.feedback" contextLevel="module" [contextInstanceId]="quiz.coursemodule" [courseId]="courseId"></core-format-text></p>
             </ion-item>
             <ion-item *ngIf="quiz.showReviewColumn && attempt.finished">
-                <button ion-button block icon-start [navPush]="'AddonModQuizReviewPage'" [navParams]="{courseId: courseId, quizId: quiz.id, attemptId: attempt.id}">
+                <button ion-button block icon-start navPush="AddonModQuizReviewPage" [navParams]="{courseId: courseId, quizId: quiz.id, attemptId: attempt.id}">
                     <ion-icon name="search"></ion-icon>
                     {{ 'addon.mod_quiz.review' | translate }}
                 </button>
diff --git a/src/core/login/pages/credentials/credentials.html b/src/core/login/pages/credentials/credentials.html
index d2659a77f..a1b2f1069 100644
--- a/src/core/login/pages/credentials/credentials.html
+++ b/src/core/login/pages/credentials/credentials.html
@@ -3,7 +3,7 @@
         <ion-title>{{ 'core.login.login' | translate }}</ion-title>
 
         <ion-buttons end>
-            <button *ngIf="isFixedUrlSet" ion-button icon-only [navPush]="'CoreAppSettingsPage'" [attr.aria-label]="'core.settings.appsettings' | translate">
+            <button *ngIf="isFixedUrlSet" ion-button icon-only navPush="CoreAppSettingsPage" [attr.aria-label]="'core.settings.appsettings' | translate">
                 <core-icon name="fa-cogs"></core-icon>
             </button>
         </ion-buttons>
diff --git a/src/core/login/pages/site/site.html b/src/core/login/pages/site/site.html
index ac2c2bae8..6a4b40f36 100644
--- a/src/core/login/pages/site/site.html
+++ b/src/core/login/pages/site/site.html
@@ -3,7 +3,7 @@
         <ion-title>{{ 'core.login.connecttomoodle' | translate }}</ion-title>
 
         <ion-buttons end>
-            <button ion-button icon-only [navPush]="'CoreAppSettingsPage'" [attr.aria-label]="'core.settings.appsettings' | translate">
+            <button ion-button icon-only navPush="CoreAppSettingsPage" [attr.aria-label]="'core.settings.appsettings' | translate">
                 <core-icon name="fa-cogs"></core-icon>
             </button>
             <button ion-button icon-only (click)="showHelp()" [attr.aria-label]="'core.help' | translate">
diff --git a/src/core/login/pages/sites/sites.html b/src/core/login/pages/sites/sites.html
index 84be5e4b9..0cca17952 100644
--- a/src/core/login/pages/sites/sites.html
+++ b/src/core/login/pages/sites/sites.html
@@ -3,7 +3,7 @@
         <ion-title>{{ 'core.settings.sites' | translate }}</ion-title>
 
         <ion-buttons end>
-            <button ion-button icon-only [navPush]="'CoreAppSettingsPage'" [attr.aria-label]="'core.settings.appsettings' | translate">
+            <button ion-button icon-only navPush="CoreAppSettingsPage" [attr.aria-label]="'core.settings.appsettings' | translate">
                 <core-icon name="fa-cogs"></core-icon>
             </button>
             <button *ngIf="sites && sites.length > 0" ion-button icon-only (click)="toggleDelete()" [attr.aria-label]="'core.delete' | translate">
diff --git a/src/core/sitehome/components/all-course-list/core-sitehome-all-course-list.html b/src/core/sitehome/components/all-course-list/core-sitehome-all-course-list.html
index 4ae3a0095..615f2251c 100644
--- a/src/core/sitehome/components/all-course-list/core-sitehome-all-course-list.html
+++ b/src/core/sitehome/components/all-course-list/core-sitehome-all-course-list.html
@@ -1,4 +1,4 @@
-<a *ngIf="show" ion-item text-wrap [navPush]="'CoreCoursesAvailableCoursesPage'">
+<a *ngIf="show" ion-item text-wrap navPush="CoreCoursesAvailableCoursesPage">
     <core-icon name="fa-graduation-cap" fixed-width item-start></core-icon>
     <h2>{{ 'core.courses.availablecourses' | translate}}</h2>
 </a>
diff --git a/src/core/sitehome/components/categories/core-sitehome-categories.html b/src/core/sitehome/components/categories/core-sitehome-categories.html
index 9ecbba6da..24f9365a8 100644
--- a/src/core/sitehome/components/categories/core-sitehome-categories.html
+++ b/src/core/sitehome/components/categories/core-sitehome-categories.html
@@ -1,4 +1,4 @@
-<a *ngIf="show" ion-item text-wrap [navPush]="'CoreCoursesCategoriesPage'">
+<a *ngIf="show" ion-item text-wrap navPush="CoreCoursesCategoriesPage">
     <ion-icon name="folder" item-start></ion-icon>
     <h2>{{ 'core.courses.categories' | translate}}</h2>
 </a>
diff --git a/src/core/sitehome/components/course-search/core-sitehome-course-search.html b/src/core/sitehome/components/course-search/core-sitehome-course-search.html
index e67ae19ee..c420ae151 100644
--- a/src/core/sitehome/components/course-search/core-sitehome-course-search.html
+++ b/src/core/sitehome/components/course-search/core-sitehome-course-search.html
@@ -1,4 +1,4 @@
-<a *ngIf="show" ion-item text-wrap [navPush]="'CoreCoursesSearchPage'">
+<a *ngIf="show" ion-item text-wrap navPush="CoreCoursesSearchPage">
     <ion-icon name="search" item-start></ion-icon>
     <h2>{{ 'core.courses.searchcourses' | translate}}</h2>
 </a>
diff --git a/src/core/sitehome/components/enrolled-course-list/core-sitehome-enrolled-course-list.html b/src/core/sitehome/components/enrolled-course-list/core-sitehome-enrolled-course-list.html
index 9de854ec5..0d917350a 100644
--- a/src/core/sitehome/components/enrolled-course-list/core-sitehome-enrolled-course-list.html
+++ b/src/core/sitehome/components/enrolled-course-list/core-sitehome-enrolled-course-list.html
@@ -1,4 +1,4 @@
-<a *ngIf="show" ion-item text-wrap [navPush]="'CoreCoursesMyCoursesPage'">
+<a *ngIf="show" ion-item text-wrap navPush="CoreCoursesMyCoursesPage">
     <core-icon name="fa-graduation-cap" fixed-width item-start></core-icon>
     <h2>{{ 'core.courses.mycourses' | translate}}</h2>
 </a>