From 461666fd9905c2f9e7582f98e0dcaaabc00c631d Mon Sep 17 00:00:00 2001 From: Dani Palou Date: Fri, 11 May 2018 14:20:16 +0200 Subject: [PATCH] MOBILE-2403 core: Fix embedded videos --- config.xml | 2 ++ src/directives/external-content.ts | 2 +- src/directives/format-text.ts | 6 ------ 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/config.xml b/config.xml index 49ab9744e..5b9064b2c 100644 --- a/config.xml +++ b/config.xml @@ -25,10 +25,12 @@ + + diff --git a/src/directives/external-content.ts b/src/directives/external-content.ts index e57585817..e16187522 100644 --- a/src/directives/external-content.ts +++ b/src/directives/external-content.ts @@ -68,7 +68,7 @@ export class CoreExternalContentDirective implements AfterViewInit { } else if (tagName === 'AUDIO' || tagName === 'VIDEO' || tagName === 'SOURCE' || tagName === 'TRACK') { targetAttr = 'src'; - sourceAttr = 'targetSrc'; + sourceAttr = 'target-src'; if (tagName === 'VIDEO') { const poster = ( this.element).poster; diff --git a/src/directives/format-text.ts b/src/directives/format-text.ts index a79cc2f1c..d024f1440 100644 --- a/src/directives/format-text.ts +++ b/src/directives/format-text.ts @@ -309,17 +309,11 @@ export class CoreFormatTextDirective implements OnChanges { audios.forEach((audio) => { this.treatMedia(audio); - if (this.platform.is('ios')) { - // Set data-tap-disabled="true" to make slider work in iOS. - audio.setAttribute('data-tap-disabled', true); - } }); videos.forEach((video) => { this.treatVideoFilters(video); this.treatMedia(video); - // Set data-tap-disabled="true" to make controls work in Android (see MOBILE-1452). - video.setAttribute('data-tap-disabled', true); }); iframes.forEach((iframe) => {