From 1a44478da19587635ec9cd25551d888cd6f0f6e5 Mon Sep 17 00:00:00 2001 From: Dani Palou Date: Wed, 11 Oct 2023 08:25:06 +0200 Subject: [PATCH 1/3] MOBILE-4362 lesson: Fix retake badges alignment in phone --- src/addons/mod/lesson/pages/user-retake/user-retake.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/addons/mod/lesson/pages/user-retake/user-retake.scss b/src/addons/mod/lesson/pages/user-retake/user-retake.scss index 88e4e2989..8c364a127 100644 --- a/src/addons/mod/lesson/pages/user-retake/user-retake.scss +++ b/src/addons/mod/lesson/pages/user-retake/user-retake.scss @@ -17,7 +17,7 @@ opacity: 0.5; } - .addon-mod_lesson-answer-success { - @include margin-horizontal(4px, null); + .addon-mod_lesson-answer-stats { + @include margin-horizontal(null, 4px); } } From 4e98e9f64ae51ac6e706e99900dacc5b840a1047 Mon Sep 17 00:00:00 2001 From: Dani Palou Date: Wed, 11 Oct 2023 11:08:34 +0200 Subject: [PATCH 2/3] MOBILE-4362 comments: Fix delete button displayed when it shouldn't The show delete button icon now also changes so it's clearer that something happened, otherwise if you cannot delete any of the comments you see it could seem that the button does nothing --- src/core/components/message/message.html | 4 ++-- src/core/features/comments/pages/viewer/viewer.html | 3 ++- src/core/features/comments/pages/viewer/viewer.ts | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/core/components/message/message.html b/src/core/components/message/message.html index c4815fdb9..9380c0137 100644 --- a/src/core/components/message/message.html +++ b/src/core/components/message/message.html @@ -35,8 +35,8 @@ color="danger" (click)="delete($event)" [attr.aria-label]="'addon.messages.deletemessage' | translate" class="delete-button"> - + diff --git a/src/core/features/comments/pages/viewer/viewer.html b/src/core/features/comments/pages/viewer/viewer.html index b941f87e2..cee1b18af 100644 --- a/src/core/features/comments/pages/viewer/viewer.html +++ b/src/core/features/comments/pages/viewer/viewer.html @@ -12,7 +12,8 @@ - + + Date: Wed, 11 Oct 2023 15:06:28 +0200 Subject: [PATCH 3/3] MOBILE-4362 glossary: Fix some entry links not handled properly If the entry link used the view.php endpoint, the index link handler treated it instead of the entry link handler --- src/addons/mod/glossary/services/handlers/index-link.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/addons/mod/glossary/services/handlers/index-link.ts b/src/addons/mod/glossary/services/handlers/index-link.ts index 3658be016..6dd91ec52 100644 --- a/src/addons/mod/glossary/services/handlers/index-link.ts +++ b/src/addons/mod/glossary/services/handlers/index-link.ts @@ -28,6 +28,13 @@ export class AddonModGlossaryIndexLinkHandlerService extends CoreContentLinksMod super('AddonModGlossary', 'glossary', 'g'); } + /** + * @inheritdoc + */ + async isEnabled(siteId: string, url: string, params: Record): Promise { + return !params.hook && !params.eid; + } + } export const AddonModGlossaryIndexLinkHandler = makeSingleton(AddonModGlossaryIndexLinkHandlerService);