From 3f8dece14e68dbc637fb21c03c058c533fda4e41 Mon Sep 17 00:00:00 2001
From: Dani Palou <dani@moodle.com>
Date: Wed, 24 Jan 2018 15:28:47 +0100
Subject: [PATCH] MOBILE-2309 core: Use popover interface in all selects

---
 src/addon/calendar/pages/event/event.html           | 2 +-
 src/addon/calendar/pages/settings/settings.html     | 2 +-
 src/components/site-picker/site-picker.html         | 2 +-
 src/core/course/components/format/format.html       | 2 +-
 src/core/courses/pages/my-overview/my-overview.html | 4 ++--
 src/core/login/pages/email-signup/email-signup.html | 2 +-
 src/core/login/pages/site/site.html                 | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/addon/calendar/pages/event/event.html b/src/addon/calendar/pages/event/event.html
index 598ae4c83..7e1087d80 100644
--- a/src/addon/calendar/pages/event/event.html
+++ b/src/addon/calendar/pages/event/event.html
@@ -40,7 +40,7 @@
         <ion-card list *ngIf="notificationsEnabled">
             <ion-item>
                 <ion-label>{{ 'addon.calendar.notifications' | translate }}</ion-label>
-                <ion-select [(ngModel)]="notificationTime" (ionChange)="updateNotificationTime($event)">
+                <ion-select [(ngModel)]="notificationTime" (ionChange)="updateNotificationTime($event)" interface="popover">
                     <ion-option value="-1">{{ 'core.defaultvalue' | translate :{$a: defaultTimeReadable} }}</ion-option>
                     <ion-option value="0">{{ 'core.settings.disabled' | translate }}</ion-option>
                     <ion-option value="10">{{ 600 | coreDuration }}</ion-option>
diff --git a/src/addon/calendar/pages/settings/settings.html b/src/addon/calendar/pages/settings/settings.html
index b32c35dcf..3d4557bc1 100644
--- a/src/addon/calendar/pages/settings/settings.html
+++ b/src/addon/calendar/pages/settings/settings.html
@@ -7,7 +7,7 @@
     <ion-list>
         <ion-item>
             <ion-label>{{ 'addon.calendar.defaultnotificationtime' | translate }}</ion-label>
-            <ion-select [(ngModel)]="defaultTime" (ionChange)="updateDefaultTime($event)">
+            <ion-select [(ngModel)]="defaultTime" (ionChange)="updateDefaultTime($event)" interface="popover">
                 <ion-option value="0">{{ 'core.settings.disabled' | translate }}</ion-option>
                 <ion-option value="10">{{ 600 | coreDuration }}</ion-option>
                 <ion-option value="30">{{ 1800 | coreDuration }}</ion-option>
diff --git a/src/components/site-picker/site-picker.html b/src/components/site-picker/site-picker.html
index ee5fc727c..c10dbe49f 100644
--- a/src/components/site-picker/site-picker.html
+++ b/src/components/site-picker/site-picker.html
@@ -1,6 +1,6 @@
 <ion-item>
     <ion-label>{{ 'core.site' | translate }}</ion-label>
-    <ion-select [(ngModel)]="selectedSite" (ngModelChange)="siteSelected.emit(selectedSite)">
+    <ion-select [(ngModel)]="selectedSite" (ngModelChange)="siteSelected.emit(selectedSite)" interface="popover">
         <ion-option *ngFor="let site of sites" [value]="site.id">{{ site.fullNameAndSiteName }}</ion-option>
     </ion-select>
 </ion-item>
diff --git a/src/core/course/components/format/format.html b/src/core/course/components/format/format.html
index 60289795a..a0fbe654f 100644
--- a/src/core/course/components/format/format.html
+++ b/src/core/course/components/format/format.html
@@ -12,7 +12,7 @@
         <!-- Section selector. -->
         <div *ngIf="!componentInstances.sectionSelector && displaySectionSelector && sections && sections.length" no-padding class="clearfix">
             <!-- @todo: How to display availabilityinfo and not visible messages? -->
-            <ion-select [ngModel]="selectedSection" (ngModelChange)="sectionChanged($event)" [compareWith]="compareSections" [selectOptions]="selectOptions" float-start>
+            <ion-select [ngModel]="selectedSection" (ngModelChange)="sectionChanged($event)" [compareWith]="compareSections" [selectOptions]="selectOptions" float-start interface="popover">
                 <ion-option *ngFor="let section of sections" [value]="section">{{section.formattedName || section.name}}</ion-option>
             </ion-select>
             <!-- Section download. -->
diff --git a/src/core/courses/pages/my-overview/my-overview.html b/src/core/courses/pages/my-overview/my-overview.html
index 76123c08d..2813939ce 100644
--- a/src/core/courses/pages/my-overview/my-overview.html
+++ b/src/core/courses/pages/my-overview/my-overview.html
@@ -30,7 +30,7 @@
                     </ion-refresher>
 
                     <div no-padding [hidden]="!(timeline.loaded || timelineCourses.loaded)">
-                        <ion-select [(ngModel)]="timeline.sort" (ngModelChange)="switchSort()">
+                        <ion-select [(ngModel)]="timeline.sort" (ngModelChange)="switchSort()" interface="popover">
                             <ion-option value="sortbydates">{{ 'core.courses.sortbydates' | translate }}</ion-option>
                             <ion-option value="sortbycourses">{{ 'core.courses.sortbycourses' | translate }}</ion-option>
                         </ion-select>
@@ -65,7 +65,7 @@
                     <core-loading [hideUntil]="courses.loaded" class="core-loading-center">
                         <!-- "Time" selector. -->
                         <div no-padding class="clearfix" [hidden]="showFilter">
-                            <ion-select [title]="'core.show' | translate" [(ngModel)]="courses.selected" float-start (ngModelChange)="selectedChanged()">
+                            <ion-select [title]="'core.show' | translate" [(ngModel)]="courses.selected" float-start (ngModelChange)="selectedChanged()" interface="popover">
                                 <ion-option value="inprogress">{{ 'core.courses.inprogress' | translate }}</ion-option>
                                 <ion-option value="future">{{ 'core.courses.future' | translate }}</ion-option>
                                 <ion-option value="past">{{ 'core.courses.past' | translate }}</ion-option>
diff --git a/src/core/login/pages/email-signup/email-signup.html b/src/core/login/pages/email-signup/email-signup.html
index e284fd771..e90bddbb5 100644
--- a/src/core/login/pages/email-signup/email-signup.html
+++ b/src/core/login/pages/email-signup/email-signup.html
@@ -69,7 +69,7 @@
             </ion-item>
             <ion-item text-wrap>
                 <ion-label stacked id="core-login-signup-country">{{ 'core.user.country' | translate }}</ion-label>
-                <ion-select name="country" formControlName="country" aria-labelledby="core-login-signup-country">
+                <ion-select name="country" formControlName="country" aria-labelledby="core-login-signup-country" interface="popover">
                     <ion-option value="">{{ 'core.login.selectacountry' | translate }}</ion-option>
                     <ion-option *ngFor="let key of countriesKeys" [value]="key">{{countries[key]}}</ion-option>
                 </ion-select>
diff --git a/src/core/login/pages/site/site.html b/src/core/login/pages/site/site.html
index 29dcac83f..a23e975ff 100644
--- a/src/core/login/pages/site/site.html
+++ b/src/core/login/pages/site/site.html
@@ -29,7 +29,7 @@
                 <ion-item *ngIf="!displayAsButtons">
                     <!-- @todo: Display label and select in different lines. -->
                     <ion-label for="siteSelect">{{ 'core.login.selectsite' | translate }}</ion-label>
-                    <ion-select formControlName="siteUrl" name="url" placeholder="{{ 'core.login.siteaddress' | translate }}">
+                    <ion-select formControlName="siteUrl" name="url" placeholder="{{ 'core.login.siteaddress' | translate }}" interface="popover">
                         <ion-option *ngFor="let site of fixedSites" [value]="site.url">{{site.name}}</ion-option>
                     </ion-select>
                 </ion-item>