EVOgeek
/
Vmeda.Online
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MOBILE-2428 core: Remove unneeded todo

main
Dani Palou 2018-06-14 08:39:17 +02:00
parent d61a2e597c
commit 3d2e056a79
4 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/compile/providers/compile.ts
View File

@ -83,7 +83,7 @@ import { CoreSitePluginsQuizAccessRuleComponent } from '@core/siteplugins/compon
import { CoreSitePluginsAssignFeedbackComponent } from '@core/siteplugins/components/assign-feedback/assign-feedback'; import { CoreSitePluginsAssignFeedbackComponent } from '@core/siteplugins/components/assign-feedback/assign-feedback';
import { CoreSitePluginsAssignSubmissionComponent } from '@core/siteplugins/components/assign-submission/assign-submission'; import { CoreSitePluginsAssignSubmissionComponent } from '@core/siteplugins/components/assign-submission/assign-submission';
// Import addon providers. Do not import database module because it causes circular dependencies. @todo workshop // Import addon providers. Do not import database module because it causes circular dependencies.
import { ADDON_BADGES_PROVIDERS } from '@addon/badges/badges.module'; import { ADDON_BADGES_PROVIDERS } from '@addon/badges/badges.module';
import { ADDON_CALENDAR_PROVIDERS } from '@addon/calendar/calendar.module'; import { ADDON_CALENDAR_PROVIDERS } from '@addon/calendar/calendar.module';
import { ADDON_COMPETENCY_PROVIDERS } from '@addon/competency/competency.module'; import { ADDON_COMPETENCY_PROVIDERS } from '@addon/competency/competency.module';

2
src/core/course/providers/helper.ts
View File

@ -819,8 +819,6 @@ export class CoreCourseHelperProvider {
moduleInfo.sizeReadable = this.textUtils.bytesToSize(moduleSize, 2); moduleInfo.sizeReadable = this.textUtils.bytesToSize(moduleSize, 2);
})); }));
// @todo: Decide what to display instead of timemodified. Last check_updates?
promises.push(this.prefetchDelegate.getModuleStatus(module, courseId).then((moduleStatus) => { promises.push(this.prefetchDelegate.getModuleStatus(module, courseId).then((moduleStatus) => {
moduleInfo.status = moduleStatus; moduleInfo.status = moduleStatus;
switch (moduleStatus) { switch (moduleStatus) {

1
src/directives/external-content.ts
View File

@ -187,7 +187,6 @@ export class CoreExternalContentDirective implements AfterViewInit {
this.logger.debug('Using URL ' + finalUrl + ' for ' + url); this.logger.debug('Using URL ' + finalUrl + ' for ' + url);
if (tagName === 'SOURCE') { if (tagName === 'SOURCE') {
// The browser does not catch changes in SRC, we need to add a new source. // The browser does not catch changes in SRC, we need to add a new source.
// @todo: Check if changing src works in Android 4.4, maybe the problem was only in 4.1-4.3.
this.addSource(finalUrl); this.addSource(finalUrl);
} else { } else {
this.element.setAttribute(targetAttr, finalUrl); this.element.setAttribute(targetAttr, finalUrl);

1
src/directives/format-text.ts
View File

@ -186,7 +186,6 @@ export class CoreFormatTextDirective implements OnChanges {
this.element.innerHTML = ''; // Remove current contents. this.element.innerHTML = ''; // Remove current contents.
if (this.maxHeight && div.innerHTML != '') { if (this.maxHeight && div.innerHTML != '') {
// Move the children to the current element to be able to calculate the height. // Move the children to the current element to be able to calculate the height.
// @todo: Display the element?
this.domUtils.moveChildren(div, this.element); this.domUtils.moveChildren(div, this.element);
// Height cannot be calculated if the element is not shown while calculating. // Height cannot be calculated if the element is not shown while calculating.