MOBILE-4081 chore: Mixed Code smell fixes
parent
16a4e62f3b
commit
3a9b10a90c
|
@ -673,7 +673,7 @@ export class AddonModGlossaryProvider {
|
||||||
* @return Promise resolved with all entrries.
|
* @return Promise resolved with all entrries.
|
||||||
*/
|
*/
|
||||||
fetchAllEntries(
|
fetchAllEntries(
|
||||||
fetchFunction: (options?: AddonModGlossaryGetEntriesOptions) => AddonModGlossaryGetEntriesWSResponse,
|
fetchFunction: (options?: AddonModGlossaryGetEntriesOptions) => Promise<AddonModGlossaryGetEntriesWSResponse>,
|
||||||
options: CoreCourseCommonModWSOptions = {},
|
options: CoreCourseCommonModWSOptions = {},
|
||||||
): Promise<AddonModGlossaryEntry[]> {
|
): Promise<AddonModGlossaryEntry[]> {
|
||||||
options.siteId = options.siteId || CoreSites.getCurrentSiteId();
|
options.siteId = options.siteId || CoreSites.getCurrentSiteId();
|
||||||
|
@ -681,7 +681,7 @@ export class AddonModGlossaryProvider {
|
||||||
const entries: AddonModGlossaryEntry[] = [];
|
const entries: AddonModGlossaryEntry[] = [];
|
||||||
|
|
||||||
const fetchMoreEntries = async (): Promise<AddonModGlossaryEntry[]> => {
|
const fetchMoreEntries = async (): Promise<AddonModGlossaryEntry[]> => {
|
||||||
const result = fetchFunction({
|
const result = await fetchFunction({
|
||||||
from: entries.length,
|
from: entries.length,
|
||||||
...options, // Include all options.
|
...options, // Include all options.
|
||||||
});
|
});
|
||||||
|
|
|
@ -41,7 +41,6 @@ const MOODLEAPP_VERSION_PREFIX = 'moodleapp-';
|
||||||
@Component({
|
@Component({
|
||||||
selector: 'app-root',
|
selector: 'app-root',
|
||||||
templateUrl: 'app.component.html',
|
templateUrl: 'app.component.html',
|
||||||
styleUrls: ['app.component.scss'],
|
|
||||||
})
|
})
|
||||||
export class AppComponent implements OnInit, AfterViewInit {
|
export class AppComponent implements OnInit, AfterViewInit {
|
||||||
|
|
||||||
|
|
|
@ -16,7 +16,7 @@
|
||||||
<core-empty-box *ngIf="rows && rows.length === 0" icon="fas-chart-bar" [message]="'core.grades.nogradesreturned' | translate">
|
<core-empty-box *ngIf="rows && rows.length === 0" icon="fas-chart-bar" [message]="'core.grades.nogradesreturned' | translate">
|
||||||
</core-empty-box>
|
</core-empty-box>
|
||||||
<div *ngIf="rows && rows.length > 0" class="core-grades-container">
|
<div *ngIf="rows && rows.length > 0" class="core-grades-container">
|
||||||
<table cellspacing="0" cellpadding="0" class="core-grades-table" [class.summary]="showSummary">
|
<table class="core-grades-table" [class.summary]="showSummary">
|
||||||
<thead>
|
<thead>
|
||||||
<tr>
|
<tr>
|
||||||
<th *ngFor="let column of columns" id="{{column.name}}" class="ion-text-start"
|
<th *ngFor="let column of columns" id="{{column.name}}" class="ion-text-start"
|
||||||
|
|
Loading…
Reference in New Issue