EVOgeek
/
Vmeda.Online
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #2349 from nguyenphuctien/MOBILE-3331_integration 

MOBILE-3331 accessibility: Fix issues of Open in browser & PDF icons
main
Dani Palou 2020-04-28 12:30:24 +02:00 committed by GitHub
parent f819331f50 e97d4adafa
commit 38b0f2c391
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/addon/mod/url/providers/module-handler.ts
View File

@ -118,7 +118,7 @@ export class AddonModUrlModuleHandler implements CoreCourseModuleHandler {
buttons: [ {
hidden: true, // Hide it until we calculate if it should be displayed or not.
icon: 'link',
label: 'core.openinbrowser',
label: 'core.openmodinbrowser',
action: (event: Event, navCtrl: NavController, module: any, courseId: number): void => {
handler.openUrl(module, courseId);
}

1
src/assets/lang/en.json
View File

@ -1855,6 +1855,7 @@
"core.online": "Online",
"core.openfullimage": "Click here to display the full size image",
"core.openinbrowser": "Open in browser",
"core.openmodinbrowser": "Open {{$a}} in browser",
"core.othergroups": "Other groups",
"core.pagea": "Page {{$a}}",
"core.parentlanguage": "",

6
src/core/course/components/module/core-course-module.html
View File

@ -1,8 +1,8 @@
<ion-item *ngIf="module && module.visibleoncoursepage !== 0 && !module.handlerData.loading" text-wrap id="core-course-module-{{module.id}}" class="core-course-module-handler {{module.handlerData.class}}" (click)="moduleClicked($event)" [ngClass]="{'item-media': module.handlerData.icon, 'core-not-clickable': !module.handlerData.action || module.uservisible === false, 'item-dimmed': module.visible === 0 || module.uservisible === false}" [title]="module.handlerData.a11yTitle" detail-none>
<img item-start *ngIf="module.handlerData.icon" [src]="module.handlerData.icon" [alt]="module.modnametranslated" class="core-module-icon">
<img item-start *ngIf="module.handlerData.icon" [src]="module.handlerData.icon" [alt]="module.modnametranslated" [attr.aria-hidden]="true" class="core-module-icon">
<div class="core-module-title">
<core-format-text [text]="module.handlerData.title" contextLevel="module" [contextInstanceId]="module.id" [courseId]="courseId"></core-format-text>
<core-format-text [text]="module.handlerData.title" contextLevel="module" [contextInstanceId]="module.id" [courseId]="courseId" [attr.aria-label]="module.handlerData.a11yTitle + ', ' + module.modnametranslated"></core-format-text>
<!-- Buttons. -->
<div item-end *ngIf="module.uservisible !== false" class="buttons core-module-buttons" [ngClass]="{'core-button-completion': module.completiondata}">
@ -13,7 +13,7 @@
<core-download-refresh [status]="downloadStatus" [enabled]="downloadEnabled" [loading]="spinner || module.handlerData.spinner" [canTrustDownload]="canCheckUpdates" (action)="download($event)"></core-download-refresh>
<!-- Buttons defined by the module handler. -->
<button ion-button icon-only clear *ngFor="let button of module.handlerData.buttons" [hidden]="button.hidden || spinner || module.handlerData.spinner" (click)="buttonClicked($event, button)" color="dark" class="core-animate-show-hide" [attr.aria-label]="button.label | translate">
<button ion-button icon-only clear *ngFor="let button of module.handlerData.buttons" [hidden]="button.hidden || spinner || module.handlerData.spinner" (click)="buttonClicked($event, button)" color="dark" class="core-animate-show-hide" [attr.aria-label]="button.label | translate:{$a: module.handlerData.title}">
<core-icon [name]="button.icon" [ios]="button.iosIcon || ''" [md]="button.mdIcon || ''"></core-icon>
</button>
</div>

1
src/lang/en.json
View File

@ -195,6 +195,7 @@
"online": "Online",
"openfullimage": "Click here to display the full size image",
"openinbrowser": "Open in browser",
"openmodinbrowser": "Open {{$a}} in browser",
"othergroups": "Other groups",
"pagea": "Page {{$a}}",
"parentlanguage": "",