Merge pull request #3677 from NoelDeMartin/MOBILE-4270

MOBILE-4270: QA Tweaks
main
Dani Palou 2023-05-11 17:40:59 +02:00 committed by GitHub
commit 383291d82d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 3 deletions

View File

@ -80,7 +80,7 @@
<p class="addon-mod-forum-discussion-title ion-text-wrap item-heading">
<ion-icon name="fas-map-pin" *ngIf="discussion.pinned"
[attr.aria-label]="'addon.mod_forum.discussionpinned' | translate"></ion-icon>
<ion-icon name="fas-star" class="addon-forum-star" *ngIf="!discussion.pinned && discussion.starred"
<ion-icon name="fas-star" class="addon-forum-star" *ngIf="discussion.starred"
[attr.aria-label]="'addon.mod_forum.favourites' | translate"></ion-icon>
<core-format-text [text]="discussion.subject" contextLevel="module" [contextInstanceId]="module && module.id"
[courseId]="courseId">

View File

@ -49,6 +49,12 @@ export const ADDON_MOD_GLOSSARY_SERVICES: Type<unknown>[] = [
];
const mainMenuRoutes: Routes = [
// Link handlers navigation.
{
path: `${AddonModGlossaryModuleHandlerService.PAGE_NAME}/entry/:entrySlug`,
loadChildren: () => import('./glossary-entry-lazy.module').then(m => m.AddonModGlossaryEntryLazyModule),
},
// Course activity navigation.
{
path: AddonModGlossaryModuleHandlerService.PAGE_NAME,

View File

@ -56,8 +56,14 @@ export class AddonModGlossaryEntryLinkHandlerService extends CoreContentLinksHan
);
await CoreNavigator.navigateToSitePath(
AddonModGlossaryModuleHandlerService.PAGE_NAME + `/${module.course}/${module.id}/entry/${entryId}`,
{ siteId },
`${AddonModGlossaryModuleHandlerService.PAGE_NAME}/entry/${entryId}`,
{
siteId,
params: {
courseId: module.course,
cmId: module.id,
},
},
);
} catch (error) {
CoreDomUtils.showErrorModalDefault(error, 'addon.mod_glossary.errorloadingentry', true);