MOBILE-3825 DX: Fix ionic:serve hook

main
Noel De Martin 2021-08-02 13:27:15 +02:00
parent 36f4d33f6b
commit 30b2c9af4f
2 changed files with 33 additions and 1 deletions

View File

@ -33,7 +33,7 @@
"test:coverage": "NODE_ENV=testing gulp && jest --coverage", "test:coverage": "NODE_ENV=testing gulp && jest --coverage",
"lint": "NODE_OPTIONS=--max-old-space-size=4096 ng lint", "lint": "NODE_OPTIONS=--max-old-space-size=4096 ng lint",
"ionic:serve:before": "gulp", "ionic:serve:before": "gulp",
"ionic:serve": "gulp watch & NODE_OPTIONS=--max-old-space-size=4096 ng serve", "ionic:serve": "./scripts/serve.sh",
"ionic:build:before": "gulp" "ionic:build:before": "gulp"
}, },
"dependencies": { "dependencies": {

32
scripts/serve.sh 100755
View File

@ -0,0 +1,32 @@
#!/bin/bash
# This script is necessary because @ionic/cli is passing one argument to the ionic:serve hook
# that is unsupported by angular cli: https://github.com/ionic-team/ionic-cli/issues/4743
#
# Once the issue is fixed, this script can be replaced adding the following npm script:
#
# "ionic:serve": "gulp watch & NODE_OPTIONS=--max-old-space-size=4096 ng serve"
#
# Run gulp watch.
echo "> gulp watch &"
gulp watch &
# Remove unknown arguments and prepare angular target.
args=("$@")
angulartarget="serve"
total=${#args[@]}
for ((i=0; i<total; ++i)); do
case ${args[i]} in
--project=*)
unset args[i];
;;
--platform=*)
angulartarget="ionic-cordova-serve";
;;
esac
done
# Serve app.
echo "> NODE_OPTIONS=--max-old-space-size=4096 ng run app:$angulartarget ${args[@]}"
NODE_OPTIONS=--max-old-space-size=4096 ng run "app:$angulartarget" ${args[@]}