From 29483572b7fe8acef0514c0aa17923bdca5cf129 Mon Sep 17 00:00:00 2001 From: Dani Palou Date: Thu, 11 May 2023 11:44:45 +0200 Subject: [PATCH] MOBILE-4270 forum: Fix discussion link handler in tablet This part of code changed in 1fbb4c3880e4789832c593270bb5dd6efe5f8502 to fix navigation, but now it didn't work in tablets because it tried to load the forum index page. Maybe this change breaks a case we haven't detected --- src/addons/mod/forum/services/handlers/discussion-link.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/addons/mod/forum/services/handlers/discussion-link.ts b/src/addons/mod/forum/services/handlers/discussion-link.ts index edb09160b..f00ed9ed5 100644 --- a/src/addons/mod/forum/services/handlers/discussion-link.ts +++ b/src/addons/mod/forum/services/handlers/discussion-link.ts @@ -65,12 +65,8 @@ export class AddonModForumDiscussionLinkHandlerService extends CoreContentLinksH pageParams.parent = parseInt(params.parent); } - const path = cmId && courseId - ? `${AddonModForumModuleHandlerService.PAGE_NAME}/${courseId}/${cmId}/${discussionId}` - : `${AddonModForumModuleHandlerService.PAGE_NAME}/discussion/${discussionId}`; - CoreNavigator.navigateToSitePath( - path, + `${AddonModForumModuleHandlerService.PAGE_NAME}/discussion/${discussionId}`, { siteId, params: pageParams }, ); },