From 19d366595ef7db19e8e992ee121bfa4ee8f585ab Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= <crazyserver@gmail.com>
Date: Fri, 6 Aug 2021 11:25:43 +0200
Subject: [PATCH] MOBILE-3783 login: Remove unused multisite selectors

---
 src/core/features/login/pages/site/site.ts       | 16 +++-------------
 src/core/features/login/services/login-helper.ts |  6 ++++++
 src/types/config.d.ts                            |  3 ++-
 3 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/src/core/features/login/pages/site/site.ts b/src/core/features/login/pages/site/site.ts
index e158b5016..ea3f85f98 100644
--- a/src/core/features/login/pages/site/site.ts
+++ b/src/core/features/login/pages/site/site.ts
@@ -20,7 +20,7 @@ import { CoreConfig } from '@services/config';
 import { CoreSites, CoreSiteCheckResponse, CoreLoginSiteInfo, CoreSitesDemoSiteData } from '@services/sites';
 import { CoreUtils } from '@services/utils/utils';
 import { CoreDomUtils } from '@services/utils/dom';
-import { CoreLoginHelper, CoreLoginHelperProvider } from '@features/login/services/login-helper';
+import { CoreLoginHelper, CoreLoginHelperProvider, CoreLoginSiteSelectorListMethod } from '@features/login/services/login-helper';
 import { CoreSite } from '@classes/site';
 import { CoreError } from '@classes/errors/error';
 import { CoreConstants } from '@/core/constants';
@@ -49,7 +49,7 @@ export class CoreLoginSitePage implements OnInit {
     siteForm: FormGroup;
     fixedSites?: CoreLoginSiteInfoExtended[];
     filteredSites?: CoreLoginSiteInfoExtended[];
-    siteSelector = 'sitefinder';
+    siteSelector: CoreLoginSiteSelectorListMethod = 'sitefinder';
     showKeyboard = false;
     filter = '';
     sites: CoreLoginSiteInfoExtended[] = [];
@@ -124,24 +124,14 @@ export class CoreLoginSitePage implements OnInit {
      * @return URL of the first site.
      */
     protected initSiteSelector(): string {
-        // Deprecate listnourl on 3.9.3, remove this block on the following release.
-        if (this.siteSelector == 'listnourl') {
-            this.siteSelector = 'list';
-            this.siteFinderSettings.displayurl = false;
-        }
-
         this.fixedSites = this.extendCoreLoginSiteInfo(<CoreLoginSiteInfoExtended[]> CoreLoginHelper.getFixedSites());
+        this.siteSelector = 'list'; // In case it's not defined
 
         // Do not show images if none are set.
         if (!this.fixedSites.some((site) => !!site.imageurl)) {
             this.siteFinderSettings.displayimage = false;
         }
 
-        // Autoselect if not defined.
-        if (this.siteSelector != 'list' && this.siteSelector != 'buttons') {
-            this.siteSelector = this.fixedSites.length > 3 ? 'list' : 'buttons';
-        }
-
         this.filteredSites = this.fixedSites;
 
         return this.fixedSites[0].url;
diff --git a/src/core/features/login/services/login-helper.ts b/src/core/features/login/services/login-helper.ts
index 6f0d6ba67..68a8f63d4 100644
--- a/src/core/features/login/services/login-helper.ts
+++ b/src/core/features/login/services/login-helper.ts
@@ -1443,3 +1443,9 @@ type StoredLoginLaunchData = {
     pageOptions: CoreNavigationOptions;
     ssoUrlParams: CoreUrlParams;
 };
+
+export type CoreLoginSiteSelectorListMethod =
+    'url'|
+    'sitefinder'|
+    'list'|
+    '';
diff --git a/src/types/config.d.ts b/src/types/config.d.ts
index 497a3b8a4..25d7151f8 100644
--- a/src/types/config.d.ts
+++ b/src/types/config.d.ts
@@ -16,6 +16,7 @@ import { CoreColorScheme, CoreZoomLevel } from '@features/settings/services/sett
 import { CoreMainMenuLocalizedCustomItem } from '@features/mainmenu/services/mainmenu';
 import { CoreSitesDemoSiteData } from '@services/sites';
 import { OpenFileAction } from '@services/utils/utils';
+import { CoreLoginSiteSelectorListMethod } from '@features/login/services/login-helper';
 
 /* eslint-disable @typescript-eslint/naming-convention */
 
@@ -37,7 +38,7 @@ export interface EnvironmentConfig {
     customurlscheme: string;
     siteurl: string;
     sitename: string;
-    multisitesdisplay: string;
+    multisitesdisplay: CoreLoginSiteSelectorListMethod;
     sitefindersettings: Record<string, unknown>;
     onlyallowlistedsites: boolean;
     skipssoconfirmation: boolean;